53dfa408b4
This fixes null bp2build builds. When running bp2build, out/soong/.bootstrap/build-globs.ninja wasn't generated, therefore none of the globs in out/soong/.primary/globs have actions to generate them. This makes bp2build always re-run on a null build, because it depends on those non-existent globs in its depfile. Fix the above by generating a build-globs.ninja file with the globs that bp2build encounters during conversion, and add tests to verify that null builds and bp2build -> soong workflows correctly regenerates the build-globs.ninja file. Test: soong integration tests for null soong->soong, bp2build->bp2build and bp2build->soong builds. Fixes: 193650250 Change-Id: Icfbad351dfa85541d1ea451f73e65cac87097926
171 lines
4.8 KiB
Bash
Executable file
171 lines
4.8 KiB
Bash
Executable file
#!/bin/bash -eu
|
|
|
|
set -o pipefail
|
|
|
|
# Test that bp2build and Bazel can play nicely together
|
|
|
|
source "$(dirname "$0")/lib.sh"
|
|
|
|
readonly GENERATED_BUILD_FILE_NAME="BUILD.bazel"
|
|
|
|
function test_bp2build_null_build() {
|
|
setup
|
|
run_bp2build
|
|
local output_mtime1=$(stat -c "%y" out/soong/.bootstrap/bp2build_workspace_marker)
|
|
|
|
run_bp2build
|
|
local output_mtime2=$(stat -c "%y" out/soong/.bootstrap/bp2build_workspace_marker)
|
|
|
|
if [[ "$output_mtime1" != "$output_mtime2" ]]; then
|
|
fail "Output bp2build marker file changed on null build"
|
|
fi
|
|
}
|
|
|
|
test_bp2build_null_build
|
|
|
|
function test_bp2build_null_build_with_globs() {
|
|
setup
|
|
|
|
mkdir -p foo/bar
|
|
cat > foo/bar/Android.bp <<'EOF'
|
|
filegroup {
|
|
name: "globs",
|
|
srcs: ["*.txt"],
|
|
}
|
|
EOF
|
|
touch foo/bar/a.txt foo/bar/b.txt
|
|
|
|
run_bp2build
|
|
local output_mtime1=$(stat -c "%y" out/soong/.bootstrap/bp2build_workspace_marker)
|
|
|
|
run_bp2build
|
|
local output_mtime2=$(stat -c "%y" out/soong/.bootstrap/bp2build_workspace_marker)
|
|
|
|
if [[ "$output_mtime1" != "$output_mtime2" ]]; then
|
|
fail "Output bp2build marker file changed on null build"
|
|
fi
|
|
}
|
|
|
|
test_bp2build_null_build_with_globs
|
|
|
|
function test_soong_after_bp2build_regenerates_build_globs_ninja() {
|
|
setup
|
|
|
|
mkdir -p foo/bar
|
|
cat > foo/bar/Android.bp <<'EOF'
|
|
filegroup {
|
|
name: "bp2build-files",
|
|
srcs: ["bp2build.*"],
|
|
bazel_module: { bp2build_available: true },
|
|
}
|
|
|
|
filegroup {
|
|
name: "soong-files",
|
|
srcs: ["soong.*"],
|
|
}
|
|
EOF
|
|
touch foo/bar/bp2build.txt foo/bar/soong.txt
|
|
|
|
build_globs_file="out/soong/.bootstrap/build-globs.ninja"
|
|
|
|
# Test: the build-globs file for bp2build should only contain the bp2build-files
|
|
# glob, whereas the build-globs file for soong should contain both bp2build-files
|
|
# and soong-files globs.
|
|
|
|
run_bp2build
|
|
local output_mtime1=$(stat -c "%y" "${build_globs_file}")
|
|
|
|
if ! grep "\"foo/bar/bp2build.*\"" "${build_globs_file}"; then
|
|
fail "bp2build filegroup globs not found in bp2build's globs file"
|
|
fi
|
|
|
|
if grep "\"foo/bar/soong.*\"" "${build_globs_file}"; then
|
|
fail "soong filegroup globs unexpectedly found in bp2build's globs file"
|
|
fi
|
|
|
|
run_soong
|
|
local output_mtime2=$(stat -c "%y" "${build_globs_file}")
|
|
|
|
if [[ "$output_mtime1" == "$output_mtime2" ]]; then
|
|
fail "Output build-globs.ninja file did not change"
|
|
fi
|
|
|
|
if ! grep "\"foo/bar/bp2build.*\"" "${build_globs_file}"; then
|
|
fail "bp2build filegroup globs not found in bp2build's globs file"
|
|
fi
|
|
|
|
if ! grep "\"foo/bar/soong.*\"" "${build_globs_file}"; then
|
|
fail "soong filegroup globs not found in bp2build's globs file"
|
|
fi
|
|
|
|
}
|
|
|
|
test_soong_after_bp2build_regenerates_build_globs_ninja
|
|
|
|
function test_bp2build_generates_all_buildfiles {
|
|
setup
|
|
create_mock_bazel
|
|
|
|
mkdir -p foo/convertible_soong_module
|
|
cat > foo/convertible_soong_module/Android.bp <<'EOF'
|
|
genrule {
|
|
name: "the_answer",
|
|
cmd: "echo '42' > $(out)",
|
|
out: [
|
|
"the_answer.txt",
|
|
],
|
|
bazel_module: {
|
|
bp2build_available: true,
|
|
},
|
|
}
|
|
EOF
|
|
|
|
mkdir -p foo/unconvertible_soong_module
|
|
cat > foo/unconvertible_soong_module/Android.bp <<'EOF'
|
|
genrule {
|
|
name: "not_the_answer",
|
|
cmd: "echo '43' > $(out)",
|
|
out: [
|
|
"not_the_answer.txt",
|
|
],
|
|
bazel_module: {
|
|
bp2build_available: false,
|
|
},
|
|
}
|
|
EOF
|
|
|
|
run_bp2build
|
|
|
|
if [[ ! -f "./out/soong/workspace/foo/convertible_soong_module/${GENERATED_BUILD_FILE_NAME}" ]]; then
|
|
fail "./out/soong/workspace/foo/convertible_soong_module/${GENERATED_BUILD_FILE_NAME} was not generated"
|
|
fi
|
|
|
|
if [[ ! -f "./out/soong/workspace/foo/unconvertible_soong_module/${GENERATED_BUILD_FILE_NAME}" ]]; then
|
|
fail "./out/soong/workspace/foo/unconvertible_soong_module/${GENERATED_BUILD_FILE_NAME} was not generated"
|
|
fi
|
|
|
|
if ! grep "the_answer" "./out/soong/workspace/foo/convertible_soong_module/${GENERATED_BUILD_FILE_NAME}"; then
|
|
fail "missing BUILD target the_answer in convertible_soong_module/${GENERATED_BUILD_FILE_NAME}"
|
|
fi
|
|
|
|
if grep "not_the_answer" "./out/soong/workspace/foo/unconvertible_soong_module/${GENERATED_BUILD_FILE_NAME}"; then
|
|
fail "found unexpected BUILD target not_the_answer in unconvertible_soong_module/${GENERATED_BUILD_FILE_NAME}"
|
|
fi
|
|
|
|
if ! grep "filegroup" "./out/soong/workspace/foo/unconvertible_soong_module/${GENERATED_BUILD_FILE_NAME}"; then
|
|
fail "missing filegroup in unconvertible_soong_module/${GENERATED_BUILD_FILE_NAME}"
|
|
fi
|
|
|
|
# NOTE: We don't actually use the extra BUILD file for anything here
|
|
run_bazel build --package_path=out/soong/workspace //foo/...
|
|
|
|
local the_answer_file="bazel-out/k8-fastbuild/bin/foo/convertible_soong_module/the_answer.txt"
|
|
if [[ ! -f "${the_answer_file}" ]]; then
|
|
fail "Expected '${the_answer_file}' to be generated, but was missing"
|
|
fi
|
|
if ! grep 42 "${the_answer_file}"; then
|
|
fail "Expected to find 42 in '${the_answer_file}'"
|
|
fi
|
|
}
|
|
|
|
test_bp2build_generates_all_buildfiles
|