0c4de1f234
In other words, if, in bp2build, module "foo" would generate "foo", and "foo_two", and "foo_two" already exists in a build file, bp2build should label "foo" as being unconvertible. Fixes: 301321658 Fixes: 301312582 Bug: 285631638 Test: Unit tests Test: Verified that `m bp2build` results in bit-for-bit identical contents for out/soong/bp2build before and after this change. Change-Id: Icbbdd69fce83579ec9b172d04b2bf1f294698f70
338 lines
10 KiB
Go
338 lines
10 KiB
Go
// Copyright 2021 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package bp2build
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"android/soong/android"
|
|
"android/soong/cc"
|
|
"android/soong/java"
|
|
)
|
|
|
|
func runJavaBinaryHostTestCase(t *testing.T, tc Bp2buildTestCase) {
|
|
t.Helper()
|
|
(&tc).ModuleTypeUnderTest = "java_binary_host"
|
|
(&tc).ModuleTypeUnderTestFactory = java.BinaryHostFactory
|
|
tc.StubbedBuildDefinitions = append(tc.StubbedBuildDefinitions, "//other:jni-lib-1")
|
|
RunBp2BuildTestCase(t, func(ctx android.RegistrationContext) {
|
|
ctx.RegisterModuleType("cc_library_host_shared", cc.LibraryHostSharedFactory)
|
|
ctx.RegisterModuleType("java_library", java.LibraryFactory)
|
|
ctx.RegisterModuleType("java_import_host", java.ImportFactory)
|
|
}, tc)
|
|
}
|
|
|
|
var testFs = map[string]string{
|
|
"test.mf": "Main-Class: com.android.test.MainClass",
|
|
"other/Android.bp": `cc_library_host_shared {
|
|
name: "jni-lib-1",
|
|
stl: "none",
|
|
}`,
|
|
}
|
|
|
|
func TestJavaBinaryHost(t *testing.T) {
|
|
runJavaBinaryHostTestCase(t, Bp2buildTestCase{
|
|
Description: "java_binary_host with srcs, exclude_srcs, jni_libs, javacflags, and manifest.",
|
|
Filesystem: testFs,
|
|
Blueprint: `java_binary_host {
|
|
name: "java-binary-host-1",
|
|
srcs: ["a.java", "b.java"],
|
|
exclude_srcs: ["b.java"],
|
|
manifest: "test.mf",
|
|
jni_libs: ["jni-lib-1"],
|
|
javacflags: ["-Xdoclint:all/protected"],
|
|
bazel_module: { bp2build_available: true },
|
|
java_version: "8",
|
|
}`,
|
|
ExpectedBazelTargets: []string{
|
|
MakeBazelTarget("java_library", "java-binary-host-1_lib", AttrNameToString{
|
|
"srcs": `["a.java"]`,
|
|
"deps": `["//other:jni-lib-1"]`,
|
|
"java_version": `"8"`,
|
|
"javacopts": `["-Xdoclint:all/protected"]`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
}),
|
|
MakeBazelTarget("java_binary", "java-binary-host-1", AttrNameToString{
|
|
"main_class": `"com.android.test.MainClass"`,
|
|
"jvm_flags": `["-Djava.library.path=$${RUNPATH}other/jni-lib-1"]`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
"runtime_deps": `[":java-binary-host-1_lib"]`,
|
|
}),
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestJavaBinaryHostRuntimeDeps(t *testing.T) {
|
|
runJavaBinaryHostTestCase(t, Bp2buildTestCase{
|
|
Description: "java_binary_host with srcs, exclude_srcs, jni_libs, javacflags, and manifest.",
|
|
Filesystem: testFs,
|
|
StubbedBuildDefinitions: []string{"java-dep-1"},
|
|
Blueprint: `java_binary_host {
|
|
name: "java-binary-host-1",
|
|
static_libs: ["java-dep-1"],
|
|
manifest: "test.mf",
|
|
bazel_module: { bp2build_available: true },
|
|
}
|
|
|
|
java_library {
|
|
name: "java-dep-1",
|
|
srcs: ["a.java"],
|
|
}
|
|
`,
|
|
ExpectedBazelTargets: []string{
|
|
MakeBazelTarget("java_binary", "java-binary-host-1", AttrNameToString{
|
|
"main_class": `"com.android.test.MainClass"`,
|
|
"runtime_deps": `[":java-dep-1"]`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
}),
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestJavaBinaryHostLibs(t *testing.T) {
|
|
runJavaBinaryHostTestCase(t, Bp2buildTestCase{
|
|
Description: "java_binary_host with srcs, libs.",
|
|
Filesystem: testFs,
|
|
StubbedBuildDefinitions: []string{"java-lib-dep-1", "java-lib-dep-1-neverlink"},
|
|
Blueprint: `java_binary_host {
|
|
name: "java-binary-host-libs",
|
|
libs: ["java-lib-dep-1"],
|
|
manifest: "test.mf",
|
|
srcs: ["a.java"],
|
|
}
|
|
|
|
java_import_host{
|
|
name: "java-lib-dep-1",
|
|
jars: ["foo.jar"],
|
|
}
|
|
`,
|
|
ExpectedBazelTargets: []string{
|
|
MakeBazelTarget("java_library", "java-binary-host-libs_lib", AttrNameToString{
|
|
"srcs": `["a.java"]`,
|
|
"deps": `[":java-lib-dep-1-neverlink"]`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
}),
|
|
MakeBazelTarget("java_binary", "java-binary-host-libs", AttrNameToString{
|
|
"main_class": `"com.android.test.MainClass"`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
"runtime_deps": `[":java-binary-host-libs_lib"]`,
|
|
}),
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestJavaBinaryHostKotlinSrcs(t *testing.T) {
|
|
runJavaBinaryHostTestCase(t, Bp2buildTestCase{
|
|
Description: "java_binary_host with srcs, libs.",
|
|
Filesystem: testFs,
|
|
Blueprint: `java_binary_host {
|
|
name: "java-binary-host",
|
|
manifest: "test.mf",
|
|
srcs: ["a.java", "b.kt"],
|
|
}
|
|
`,
|
|
ExpectedBazelTargets: []string{
|
|
MakeBazelTarget("kt_jvm_library", "java-binary-host_lib", AttrNameToString{
|
|
"srcs": `[
|
|
"a.java",
|
|
"b.kt",
|
|
]`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
}),
|
|
MakeBazelTarget("java_binary", "java-binary-host", AttrNameToString{
|
|
"main_class": `"com.android.test.MainClass"`,
|
|
"runtime_deps": `[":java-binary-host_lib"]`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
}),
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestJavaBinaryHostKotlinCommonSrcs(t *testing.T) {
|
|
runJavaBinaryHostTestCase(t, Bp2buildTestCase{
|
|
Description: "java_binary_host with common_srcs",
|
|
Filesystem: testFs,
|
|
Blueprint: `java_binary_host {
|
|
name: "java-binary-host",
|
|
manifest: "test.mf",
|
|
srcs: ["a.java"],
|
|
common_srcs: ["b.kt"],
|
|
}
|
|
`,
|
|
ExpectedBazelTargets: []string{
|
|
MakeBazelTarget("kt_jvm_library", "java-binary-host_lib", AttrNameToString{
|
|
"srcs": `["a.java"]`,
|
|
"common_srcs": `["b.kt"]`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
}),
|
|
MakeBazelTarget("java_binary", "java-binary-host", AttrNameToString{
|
|
"main_class": `"com.android.test.MainClass"`,
|
|
"runtime_deps": `[":java-binary-host_lib"]`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
}),
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestJavaBinaryHostKotlinWithResourceDir(t *testing.T) {
|
|
runJavaBinaryHostTestCase(t, Bp2buildTestCase{
|
|
Description: "java_binary_host with srcs, libs, resource dir .",
|
|
Filesystem: map[string]string{
|
|
"test.mf": "Main-Class: com.android.test.MainClass",
|
|
"res/a.res": "",
|
|
"res/dir1/b.res": "",
|
|
},
|
|
Blueprint: `java_binary_host {
|
|
name: "java-binary-host",
|
|
manifest: "test.mf",
|
|
srcs: ["a.java", "b.kt"],
|
|
java_resource_dirs: ["res"],
|
|
}
|
|
`,
|
|
ExpectedBazelTargets: []string{
|
|
MakeBazelTarget("kt_jvm_library", "java-binary-host_lib", AttrNameToString{
|
|
"srcs": `[
|
|
"a.java",
|
|
"b.kt",
|
|
]`,
|
|
"resources": `[
|
|
"res/a.res",
|
|
"res/dir1/b.res",
|
|
]`,
|
|
"resource_strip_prefix": `"res"`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
}),
|
|
MakeBazelTarget("java_binary", "java-binary-host", AttrNameToString{
|
|
"main_class": `"com.android.test.MainClass"`,
|
|
"runtime_deps": `[":java-binary-host_lib"]`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
}),
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestJavaBinaryHostKotlinWithResources(t *testing.T) {
|
|
runJavaBinaryHostTestCase(t, Bp2buildTestCase{
|
|
Description: "java_binary_host with srcs, libs, resources.",
|
|
Filesystem: map[string]string{
|
|
"adir/test.mf": "Main-Class: com.android.test.MainClass",
|
|
"adir/res/a.res": "",
|
|
"adir/res/b.res": "",
|
|
"adir/Android.bp": `java_binary_host {
|
|
name: "java-binary-host",
|
|
manifest: "test.mf",
|
|
srcs: ["a.java", "b.kt"],
|
|
java_resources: ["res/a.res", "res/b.res"],
|
|
bazel_module: { bp2build_available: true },
|
|
}
|
|
`,
|
|
},
|
|
Dir: "adir",
|
|
Blueprint: "",
|
|
ExpectedBazelTargets: []string{
|
|
MakeBazelTarget("kt_jvm_library", "java-binary-host_lib", AttrNameToString{
|
|
"srcs": `[
|
|
"a.java",
|
|
"b.kt",
|
|
]`,
|
|
"resources": `[
|
|
"res/a.res",
|
|
"res/b.res",
|
|
]`,
|
|
"resource_strip_prefix": `"adir"`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
}),
|
|
MakeBazelTarget("java_binary", "java-binary-host", AttrNameToString{
|
|
"main_class": `"com.android.test.MainClass"`,
|
|
"runtime_deps": `[":java-binary-host_lib"]`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
}),
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestJavaBinaryHostKotlinCflags(t *testing.T) {
|
|
runJavaBinaryHostTestCase(t, Bp2buildTestCase{
|
|
Description: "java_binary_host with kotlincflags",
|
|
Filesystem: testFs,
|
|
Blueprint: `java_binary_host {
|
|
name: "java-binary-host",
|
|
manifest: "test.mf",
|
|
srcs: ["a.kt"],
|
|
kotlincflags: ["-flag1", "-flag2"],
|
|
}
|
|
`,
|
|
ExpectedBazelTargets: []string{
|
|
MakeBazelTarget("kt_jvm_library", "java-binary-host_lib", AttrNameToString{
|
|
"srcs": `["a.kt"]`,
|
|
"kotlincflags": `[
|
|
"-flag1",
|
|
"-flag2",
|
|
]`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
}),
|
|
MakeBazelTarget("java_binary", "java-binary-host", AttrNameToString{
|
|
"main_class": `"com.android.test.MainClass"`,
|
|
"runtime_deps": `[":java-binary-host_lib"]`,
|
|
"target_compatible_with": `select({
|
|
"//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
|
|
"//conditions:default": [],
|
|
})`,
|
|
}),
|
|
},
|
|
})
|
|
}
|