d7ddf051d3
For Rust dylibs we generate a file suffix of .dylib.so. rustc seems to split the output filename for the gcno file at the first '.', so instead of libfoo.dylib.gcno (which our build system expects), it produces libfoo.gcno. This fixes the mismatch so the build system can find the gcno file that gets produced for Rust dylibs. Bug: 170983066 Test: CLANG_COVERAGE=true NATIVE_COVERAGE_PATHS=external/rust/crates \ m libandroid_log_sys Change-Id: Icba48bf10ab06c255bd17053d57feb889b1f9ee5
187 lines
7.2 KiB
Go
187 lines
7.2 KiB
Go
// Copyright 2020 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rust
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"android/soong/android"
|
|
)
|
|
|
|
// Test that coverage flags are being correctly generated.
|
|
func TestCoverageFlags(t *testing.T) {
|
|
ctx := testRustCov(t, `
|
|
rust_library {
|
|
name: "libfoo_cov",
|
|
srcs: ["foo.rs"],
|
|
crate_name: "foo",
|
|
}
|
|
rust_binary {
|
|
name: "fizz_cov",
|
|
srcs: ["foo.rs"],
|
|
}
|
|
rust_binary {
|
|
name: "buzzNoCov",
|
|
srcs: ["foo.rs"],
|
|
native_coverage: false,
|
|
}
|
|
rust_library {
|
|
name: "libbar_nocov",
|
|
srcs: ["foo.rs"],
|
|
crate_name: "bar",
|
|
native_coverage: false,
|
|
}`)
|
|
|
|
// Make sure native_coverage: false isn't creating a coverage variant.
|
|
if android.InList("android_arm64_armv8-a_dylib_cov", ctx.ModuleVariantsForTests("libbar_nocov")) {
|
|
t.Fatalf("coverage variant created for module 'libbar_nocov' with native coverage disabled")
|
|
}
|
|
|
|
// Just test the dylib variants unless the library coverage logic changes to distinguish between the types.
|
|
libfooCov := ctx.ModuleForTests("libfoo_cov", "android_arm64_armv8-a_dylib_cov").Rule("rustc")
|
|
libbarNoCov := ctx.ModuleForTests("libbar_nocov", "android_arm64_armv8-a_dylib").Rule("rustc")
|
|
fizzCov := ctx.ModuleForTests("fizz_cov", "android_arm64_armv8-a_cov").Rule("rustc")
|
|
buzzNoCov := ctx.ModuleForTests("buzzNoCov", "android_arm64_armv8-a").Rule("rustc")
|
|
|
|
rustcCoverageFlags := []string{"-Z profile", " -g ", "-C opt-level=0", "-C link-dead-code"}
|
|
for _, flag := range rustcCoverageFlags {
|
|
missingErrorStr := "missing rustc flag '%s' for '%s' module with coverage enabled; rustcFlags: %#v"
|
|
containsErrorStr := "contains rustc flag '%s' for '%s' module with coverage disabled; rustcFlags: %#v"
|
|
|
|
if !strings.Contains(fizzCov.Args["rustcFlags"], flag) {
|
|
t.Fatalf(missingErrorStr, flag, "fizz_cov", fizzCov.Args["rustcFlags"])
|
|
}
|
|
if !strings.Contains(libfooCov.Args["rustcFlags"], flag) {
|
|
t.Fatalf(missingErrorStr, flag, "libfoo_cov dylib", libfooCov.Args["rustcFlags"])
|
|
}
|
|
if strings.Contains(buzzNoCov.Args["rustcFlags"], flag) {
|
|
t.Fatalf(containsErrorStr, flag, "buzzNoCov", buzzNoCov.Args["rustcFlags"])
|
|
}
|
|
if strings.Contains(libbarNoCov.Args["rustcFlags"], flag) {
|
|
t.Fatalf(containsErrorStr, flag, "libbar_cov", libbarNoCov.Args["rustcFlags"])
|
|
}
|
|
}
|
|
|
|
linkCoverageFlags := []string{"--coverage", " -g "}
|
|
for _, flag := range linkCoverageFlags {
|
|
missingErrorStr := "missing rust linker flag '%s' for '%s' module with coverage enabled; rustcFlags: %#v"
|
|
containsErrorStr := "contains rust linker flag '%s' for '%s' module with coverage disabled; rustcFlags: %#v"
|
|
|
|
if !strings.Contains(fizzCov.Args["linkFlags"], flag) {
|
|
t.Fatalf(missingErrorStr, flag, "fizz_cov", fizzCov.Args["linkFlags"])
|
|
}
|
|
if !strings.Contains(libfooCov.Args["linkFlags"], flag) {
|
|
t.Fatalf(missingErrorStr, flag, "libfoo_cov dylib", libfooCov.Args["linkFlags"])
|
|
}
|
|
if strings.Contains(buzzNoCov.Args["linkFlags"], flag) {
|
|
t.Fatalf(containsErrorStr, flag, "buzzNoCov", buzzNoCov.Args["linkFlags"])
|
|
}
|
|
if strings.Contains(libbarNoCov.Args["linkFlags"], flag) {
|
|
t.Fatalf(containsErrorStr, flag, "libbar_cov", libbarNoCov.Args["linkFlags"])
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
// Test coverage files are included correctly
|
|
func TestCoverageZip(t *testing.T) {
|
|
ctx := testRustCov(t, `
|
|
rust_library {
|
|
name: "libfoo",
|
|
srcs: ["foo.rs"],
|
|
rlibs: ["librlib"],
|
|
crate_name: "foo",
|
|
}
|
|
rust_ffi_static {
|
|
name: "libbaz",
|
|
srcs: ["foo.rs"],
|
|
rlibs: ["librlib"],
|
|
crate_name: "baz",
|
|
}
|
|
rust_library_rlib {
|
|
name: "librlib",
|
|
srcs: ["foo.rs"],
|
|
crate_name: "rlib",
|
|
}
|
|
rust_binary {
|
|
name: "fizz",
|
|
rlibs: ["librlib"],
|
|
static_libs: ["libbaz"],
|
|
srcs: ["foo.rs"],
|
|
}
|
|
cc_binary {
|
|
name: "buzz",
|
|
static_libs: ["libbaz"],
|
|
srcs: ["foo.c"],
|
|
}
|
|
cc_library {
|
|
name: "libbar",
|
|
static_libs: ["libbaz"],
|
|
compile_multilib: "64",
|
|
srcs: ["foo.c"],
|
|
}`)
|
|
|
|
fizzZipInputs := ctx.ModuleForTests("fizz", "android_arm64_armv8-a_cov").Rule("zip").Inputs.Strings()
|
|
libfooZipInputs := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_dylib_cov").Rule("zip").Inputs.Strings()
|
|
buzzZipInputs := ctx.ModuleForTests("buzz", "android_arm64_armv8-a_cov").Rule("zip").Inputs.Strings()
|
|
libbarZipInputs := ctx.ModuleForTests("libbar", "android_arm64_armv8-a_shared_cov").Rule("zip").Inputs.Strings()
|
|
|
|
// Make sure the expected number of input files are included.
|
|
if len(fizzZipInputs) != 3 {
|
|
t.Fatalf("expected only 3 coverage inputs for rust 'fizz' binary, got %#v: %#v", len(fizzZipInputs), fizzZipInputs)
|
|
}
|
|
if len(libfooZipInputs) != 2 {
|
|
t.Fatalf("expected only 2 coverage inputs for rust 'libfoo' library, got %#v: %#v", len(libfooZipInputs), libfooZipInputs)
|
|
}
|
|
if len(buzzZipInputs) != 2 {
|
|
t.Fatalf("expected only 2 coverage inputs for cc 'buzz' binary, got %#v: %#v", len(buzzZipInputs), buzzZipInputs)
|
|
}
|
|
if len(libbarZipInputs) != 2 {
|
|
t.Fatalf("expected only 2 coverage inputs for cc 'libbar' library, got %#v: %#v", len(libbarZipInputs), libbarZipInputs)
|
|
}
|
|
|
|
// Make sure the expected inputs are provided to the zip rule.
|
|
if !android.SuffixInList(fizzZipInputs, "android_arm64_armv8-a_rlib_dylib-std_cov/librlib.gcno") ||
|
|
!android.SuffixInList(fizzZipInputs, "android_arm64_armv8-a_static_cov/libbaz.gcno") ||
|
|
!android.SuffixInList(fizzZipInputs, "android_arm64_armv8-a_cov/fizz.gcno") {
|
|
t.Fatalf("missing expected coverage files for rust 'fizz' binary: %#v", fizzZipInputs)
|
|
}
|
|
if !android.SuffixInList(libfooZipInputs, "android_arm64_armv8-a_rlib_dylib-std_cov/librlib.gcno") ||
|
|
!android.SuffixInList(libfooZipInputs, "android_arm64_armv8-a_dylib_cov/libfoo.gcno") {
|
|
t.Fatalf("missing expected coverage files for rust 'fizz' binary: %#v", libfooZipInputs)
|
|
}
|
|
if !android.SuffixInList(buzzZipInputs, "android_arm64_armv8-a_cov/obj/foo.gcno") ||
|
|
!android.SuffixInList(buzzZipInputs, "android_arm64_armv8-a_static_cov/libbaz.gcno") {
|
|
t.Fatalf("missing expected coverage files for cc 'buzz' binary: %#v", buzzZipInputs)
|
|
}
|
|
if !android.SuffixInList(libbarZipInputs, "android_arm64_armv8-a_static_cov/obj/foo.gcno") ||
|
|
!android.SuffixInList(libbarZipInputs, "android_arm64_armv8-a_static_cov/libbaz.gcno") {
|
|
t.Fatalf("missing expected coverage files for cc 'libbar' library: %#v", libbarZipInputs)
|
|
}
|
|
}
|
|
|
|
func TestCoverageDeps(t *testing.T) {
|
|
ctx := testRustCov(t, `
|
|
rust_binary {
|
|
name: "fizz",
|
|
srcs: ["foo.rs"],
|
|
}`)
|
|
|
|
fizz := ctx.ModuleForTests("fizz", "android_arm64_armv8-a_cov").Rule("rustc")
|
|
if !strings.Contains(fizz.Args["linkFlags"], "libprofile-extras.a") {
|
|
t.Fatalf("missing expected coverage 'libprofile-extras' dependency in linkFlags: %#v", fizz.Args["linkFlags"])
|
|
}
|
|
}
|