40067de675
This CL adds support to bp2build for declaring the location of the Starlark rule definition when creating BazelTargetModules. This is needed for non-native rules that needs to be loaded from .bzl files somewhere in the tree. Since load statements are aggregated at the top of the BUILD file, away from the targets that actually use them, this CL also introduces an abstraction to group BazelTargets together and compute their load statements and target string representations separately, allowing load statements to be decoupled and written into a BUILD file before the targets themselves. Test: soong tests Test: TH Test: GENERATE_BAZEL_FILES=true m nothing && build/bazel/scripts/bp2build-sync.sh write && bazel cquery //bionic/... Fixes: 178531760 Test: TH Change-Id: Ie5f793a00006eb024eaef07ddd9fde7aaefc054e
208 lines
5.6 KiB
Go
208 lines
5.6 KiB
Go
// Copyright 2020 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package bp2build
|
|
|
|
import (
|
|
"android/soong/android"
|
|
"io/ioutil"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
var buildDir string
|
|
|
|
func setUp() {
|
|
var err error
|
|
buildDir, err = ioutil.TempDir("", "bazel_queryview_test")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
}
|
|
|
|
func tearDown() {
|
|
os.RemoveAll(buildDir)
|
|
}
|
|
|
|
func TestMain(m *testing.M) {
|
|
run := func() int {
|
|
setUp()
|
|
defer tearDown()
|
|
|
|
return m.Run()
|
|
}
|
|
|
|
os.Exit(run())
|
|
}
|
|
|
|
func TestGenerateModuleRuleShims(t *testing.T) {
|
|
moduleTypeFactories := map[string]android.ModuleFactory{
|
|
"custom": customModuleFactoryBase,
|
|
"custom_test": customTestModuleFactoryBase,
|
|
"custom_defaults": customDefaultsModuleFactoryBasic,
|
|
}
|
|
ruleShims := CreateRuleShims(moduleTypeFactories)
|
|
|
|
if len(ruleShims) != 1 {
|
|
t.Errorf("Expected to generate 1 rule shim, but got %d", len(ruleShims))
|
|
}
|
|
|
|
ruleShim := ruleShims["bp2build"]
|
|
expectedRules := []string{
|
|
"custom",
|
|
"custom_defaults",
|
|
"custom_test_",
|
|
}
|
|
|
|
if len(ruleShim.rules) != len(expectedRules) {
|
|
t.Errorf("Expected %d rules, but got %d", len(expectedRules), len(ruleShim.rules))
|
|
}
|
|
|
|
for i, rule := range ruleShim.rules {
|
|
if rule != expectedRules[i] {
|
|
t.Errorf("Expected rule shim to contain %s, but got %s", expectedRules[i], rule)
|
|
}
|
|
}
|
|
expectedBzl := `load("//build/bazel/queryview_rules:providers.bzl", "SoongModuleInfo")
|
|
|
|
def _custom_impl(ctx):
|
|
return [SoongModuleInfo()]
|
|
|
|
custom = rule(
|
|
implementation = _custom_impl,
|
|
attrs = {
|
|
"soong_module_name": attr.string(mandatory = True),
|
|
"soong_module_variant": attr.string(),
|
|
"soong_module_deps": attr.label_list(providers = [SoongModuleInfo]),
|
|
"bool_prop": attr.bool(),
|
|
"bool_ptr_prop": attr.bool(),
|
|
"int64_ptr_prop": attr.int(),
|
|
# nested_props start
|
|
# "nested_prop": attr.string(),
|
|
# nested_props end
|
|
# nested_props_ptr start
|
|
# "nested_prop": attr.string(),
|
|
# nested_props_ptr end
|
|
"string_list_prop": attr.string_list(),
|
|
"string_prop": attr.string(),
|
|
"string_ptr_prop": attr.string(),
|
|
},
|
|
)
|
|
|
|
def _custom_defaults_impl(ctx):
|
|
return [SoongModuleInfo()]
|
|
|
|
custom_defaults = rule(
|
|
implementation = _custom_defaults_impl,
|
|
attrs = {
|
|
"soong_module_name": attr.string(mandatory = True),
|
|
"soong_module_variant": attr.string(),
|
|
"soong_module_deps": attr.label_list(providers = [SoongModuleInfo]),
|
|
"bool_prop": attr.bool(),
|
|
"bool_ptr_prop": attr.bool(),
|
|
"int64_ptr_prop": attr.int(),
|
|
# nested_props start
|
|
# "nested_prop": attr.string(),
|
|
# nested_props end
|
|
# nested_props_ptr start
|
|
# "nested_prop": attr.string(),
|
|
# nested_props_ptr end
|
|
"string_list_prop": attr.string_list(),
|
|
"string_prop": attr.string(),
|
|
"string_ptr_prop": attr.string(),
|
|
},
|
|
)
|
|
|
|
def _custom_test__impl(ctx):
|
|
return [SoongModuleInfo()]
|
|
|
|
custom_test_ = rule(
|
|
implementation = _custom_test__impl,
|
|
attrs = {
|
|
"soong_module_name": attr.string(mandatory = True),
|
|
"soong_module_variant": attr.string(),
|
|
"soong_module_deps": attr.label_list(providers = [SoongModuleInfo]),
|
|
"bool_prop": attr.bool(),
|
|
"bool_ptr_prop": attr.bool(),
|
|
"int64_ptr_prop": attr.int(),
|
|
# nested_props start
|
|
# "nested_prop": attr.string(),
|
|
# nested_props end
|
|
# nested_props_ptr start
|
|
# "nested_prop": attr.string(),
|
|
# nested_props_ptr end
|
|
"string_list_prop": attr.string_list(),
|
|
"string_prop": attr.string(),
|
|
"string_ptr_prop": attr.string(),
|
|
# test_prop start
|
|
# "test_string_prop": attr.string(),
|
|
# test_prop end
|
|
},
|
|
)
|
|
`
|
|
|
|
if ruleShim.content != expectedBzl {
|
|
t.Errorf(
|
|
"Expected the generated rule shim bzl to be:\n%s\nbut got:\n%s",
|
|
expectedBzl,
|
|
ruleShim.content)
|
|
}
|
|
}
|
|
|
|
func TestGenerateSoongModuleBzl(t *testing.T) {
|
|
ruleShims := map[string]RuleShim{
|
|
"file1": RuleShim{
|
|
rules: []string{"a", "b"},
|
|
content: "irrelevant",
|
|
},
|
|
"file2": RuleShim{
|
|
rules: []string{"c", "d"},
|
|
content: "irrelevant",
|
|
},
|
|
}
|
|
files := CreateBazelFiles(ruleShims, make(map[string]BazelTargets), QueryView)
|
|
|
|
var actualSoongModuleBzl BazelFile
|
|
for _, f := range files {
|
|
if f.Basename == "soong_module.bzl" {
|
|
actualSoongModuleBzl = f
|
|
}
|
|
}
|
|
|
|
expectedLoad := `load("//build/bazel/queryview_rules:file1.bzl", "a", "b")
|
|
load("//build/bazel/queryview_rules:file2.bzl", "c", "d")
|
|
`
|
|
expectedRuleMap := `soong_module_rule_map = {
|
|
"a": a,
|
|
"b": b,
|
|
"c": c,
|
|
"d": d,
|
|
}`
|
|
if !strings.Contains(actualSoongModuleBzl.Contents, expectedLoad) {
|
|
t.Errorf(
|
|
"Generated soong_module.bzl:\n\n%s\n\n"+
|
|
"Could not find the load statement in the generated soong_module.bzl:\n%s",
|
|
actualSoongModuleBzl.Contents,
|
|
expectedLoad)
|
|
}
|
|
|
|
if !strings.Contains(actualSoongModuleBzl.Contents, expectedRuleMap) {
|
|
t.Errorf(
|
|
"Generated soong_module.bzl:\n\n%s\n\n"+
|
|
"Could not find the module -> rule map in the generated soong_module.bzl:\n%s",
|
|
actualSoongModuleBzl.Contents,
|
|
expectedRuleMap)
|
|
}
|
|
}
|