a0171822be
Since aosp/872653 and aosp/904233 landed, prebuilt_etc_xml has been broken. aosp/872653: Enable arch variant properties in prebuilt_etc. aosp/904233: Add a prebuilt module type for usr/share. This change fixes 1) pass baseDir "etc" to initialize PrebuiltEtc struct 2) change "multlib" argument to MultilibFirst to reflect aosp/872653 Bug: 138082739 Test: m com.google.vr.platform.xml && see if it is installed in /system/etc Change-Id: I4802107fd8ccf28a1170d7d165700c92df32e341
107 lines
2.9 KiB
Go
107 lines
2.9 KiB
Go
// Copyright 2018 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package xml
|
|
|
|
import (
|
|
"android/soong/android"
|
|
"io/ioutil"
|
|
"os"
|
|
"testing"
|
|
)
|
|
|
|
func testXml(t *testing.T, bp string) *android.TestContext {
|
|
config, buildDir := setup(t)
|
|
defer teardown(buildDir)
|
|
ctx := android.NewTestArchContext()
|
|
ctx.RegisterModuleType("prebuilt_etc", android.ModuleFactoryAdaptor(android.PrebuiltEtcFactory))
|
|
ctx.RegisterModuleType("prebuilt_etc_xml", android.ModuleFactoryAdaptor(PrebuiltEtcXmlFactory))
|
|
ctx.Register()
|
|
mockFiles := map[string][]byte{
|
|
"Android.bp": []byte(bp),
|
|
"foo.xml": nil,
|
|
"foo.dtd": nil,
|
|
"bar.xml": nil,
|
|
"bar.xsd": nil,
|
|
"baz.xml": nil,
|
|
}
|
|
ctx.MockFileSystem(mockFiles)
|
|
_, errs := ctx.ParseFileList(".", []string{"Android.bp"})
|
|
android.FailIfErrored(t, errs)
|
|
_, errs = ctx.PrepareBuildActions(config)
|
|
android.FailIfErrored(t, errs)
|
|
|
|
return ctx
|
|
}
|
|
|
|
func setup(t *testing.T) (config android.Config, buildDir string) {
|
|
buildDir, err := ioutil.TempDir("", "soong_xml_test")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
config = android.TestArchConfig(buildDir, nil)
|
|
|
|
return
|
|
}
|
|
|
|
func teardown(buildDir string) {
|
|
os.RemoveAll(buildDir)
|
|
}
|
|
|
|
func assertEqual(t *testing.T, name, expected, actual string) {
|
|
t.Helper()
|
|
if expected != actual {
|
|
t.Errorf(name+" expected %q != got %q", expected, actual)
|
|
}
|
|
}
|
|
|
|
// Minimal test
|
|
func TestPrebuiltEtcXml(t *testing.T) {
|
|
ctx := testXml(t, `
|
|
prebuilt_etc_xml {
|
|
name: "foo.xml",
|
|
src: "foo.xml",
|
|
schema: "foo.dtd",
|
|
}
|
|
prebuilt_etc_xml {
|
|
name: "bar.xml",
|
|
src: "bar.xml",
|
|
schema: "bar.xsd",
|
|
}
|
|
prebuilt_etc_xml {
|
|
name: "baz.xml",
|
|
src: "baz.xml",
|
|
}
|
|
`)
|
|
|
|
for _, tc := range []struct {
|
|
rule, input, schemaType, schema string
|
|
}{
|
|
{rule: "xmllint-dtd", input: "foo.xml", schemaType: "dtd", schema: "foo.dtd"},
|
|
{rule: "xmllint-xsd", input: "bar.xml", schemaType: "xsd", schema: "bar.xsd"},
|
|
{rule: "xmllint-minimal", input: "baz.xml"},
|
|
} {
|
|
t.Run(tc.schemaType, func(t *testing.T) {
|
|
rule := ctx.ModuleForTests(tc.input, "android_arm64_armv8-a").Rule(tc.rule)
|
|
assertEqual(t, "input", tc.input, rule.Input.String())
|
|
if tc.schemaType != "" {
|
|
assertEqual(t, "schema", tc.schema, rule.Args[tc.schemaType])
|
|
}
|
|
})
|
|
}
|
|
|
|
m := ctx.ModuleForTests("foo.xml", "android_arm64_armv8-a").Module().(*prebuiltEtcXml)
|
|
assertEqual(t, "installDir", "target/product/test_device/system/etc", m.InstallDirPath().RelPathString())
|
|
}
|