platform_build_soong/cmd/symbol_inject/elf.go
Colin Cross 8673b5b959 Rewrite symbol_inject to be testable
Parse the machine-specific symbol tables into a custom symbol table
object and use a single function to find the offset and size of the
symbol in the custom table.  Make the functions to convert a
machine-specific symbol table into the custom table also take mocks,
and provide functions to dump mocks from real files.  Add tests
that take the mocks and verify they produce the right offset and
size.

Test: cmd/symbol_inject/*_test.go
Change-Id: I25654032b5017dd13a9a1fe29f8b8826ce5bc82b
2018-03-02 16:47:13 -08:00

160 lines
4 KiB
Go
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

// Copyright 2018 Google Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package main
import (
"debug/elf"
"fmt"
"io"
)
type mockableElfFile interface {
Symbols() ([]elf.Symbol, error)
Sections() []elf.SectionHeader
Type() elf.Type
}
var _ mockableElfFile = elfFileWrapper{}
type elfFileWrapper struct {
*elf.File
}
func (f elfFileWrapper) Sections() []elf.SectionHeader {
ret := make([]elf.SectionHeader, len(f.File.Sections))
for i, section := range f.File.Sections {
ret[i] = section.SectionHeader
}
return ret
}
func (f elfFileWrapper) Type() elf.Type {
return f.File.Type
}
type mockElfFile struct {
symbols []elf.Symbol
sections []elf.SectionHeader
t elf.Type
}
func (f mockElfFile) Sections() []elf.SectionHeader { return f.sections }
func (f mockElfFile) Symbols() ([]elf.Symbol, error) { return f.symbols, nil }
func (f mockElfFile) Type() elf.Type { return f.t }
func elfSymbolsFromFile(r io.ReaderAt) (*File, error) {
elfFile, err := elf.NewFile(r)
if err != nil {
return nil, cantParseError{err}
}
return extractElfSymbols(elfFileWrapper{elfFile})
}
func extractElfSymbols(elfFile mockableElfFile) (*File, error) {
symbols, err := elfFile.Symbols()
if err != nil {
return nil, err
}
file := &File{}
for _, section := range elfFile.Sections() {
file.Sections = append(file.Sections, &Section{
Name: section.Name,
Addr: section.Addr,
Offset: section.Offset,
Size: section.Size,
})
}
_ = elf.Section{}
for _, symbol := range symbols {
if elf.ST_TYPE(symbol.Info) != elf.STT_OBJECT {
continue
}
if symbol.Section == elf.SHN_UNDEF || symbol.Section >= elf.SHN_LORESERVE {
continue
}
if int(symbol.Section) >= len(file.Sections) {
return nil, fmt.Errorf("invalid section index %d", symbol.Section)
}
section := file.Sections[symbol.Section]
var addr uint64
switch elfFile.Type() {
case elf.ET_REL:
// "In relocatable files, st_value holds a section offset for a defined symbol.
// That is, st_value is an offset from the beginning of the section that st_shndx identifies."
addr = symbol.Value
case elf.ET_EXEC, elf.ET_DYN:
// "In executable and shared object files, st_value holds a virtual address. To make these
// files symbols more useful for the dynamic linker, the section offset (file interpretation)
// gives way to a virtual address (memory interpretation) for which the section number is
// irrelevant."
if symbol.Value < section.Addr {
return nil, fmt.Errorf("symbol starts before the start of its section")
}
addr = symbol.Value - section.Addr
if addr+symbol.Size > section.Size {
return nil, fmt.Errorf("symbol extends past the end of its section")
}
default:
return nil, fmt.Errorf("unsupported elf file type %d", elfFile.Type())
}
file.Symbols = append(file.Symbols, &Symbol{
Name: symbol.Name,
Addr: addr,
Size: symbol.Size,
Section: section,
})
}
return file, nil
}
func dumpElfSymbols(r io.ReaderAt) error {
elfFile, err := elf.NewFile(r)
if err != nil {
return cantParseError{err}
}
symbols, err := elfFile.Symbols()
if err != nil {
return err
}
fmt.Println("mockElfFile{")
fmt.Printf("\tt: %#v,\n", elfFile.Type)
fmt.Println("\tsections: []elf.SectionHeader{")
for _, section := range elfFile.Sections {
fmt.Printf("\t\t%#v,\n", section.SectionHeader)
}
fmt.Println("\t},")
fmt.Println("\tsymbols: []elf.Symbol{")
for _, symbol := range symbols {
fmt.Printf("\t\t%#v,\n", symbol)
}
fmt.Println("\t},")
fmt.Println("}")
return nil
}