08693d2bf2
Improve the androidmk makefile parser based on ideas from go/ast and
friends:
- Use type switching instead of the As* mess
- Don't store endPos for every node, compute it based on the last
known position in the node plus the length of the last token
- Store positions as only the offset into the file, and then unpack
them into Line/Column scanner.Position objects later
Change-Id: I87eb6661859951e6c2ea5a85db6229fa5561d615
96 lines
1.9 KiB
Go
96 lines
1.9 KiB
Go
package parser
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
var splitNTestCases = []struct {
|
|
in *MakeString
|
|
expected []*MakeString
|
|
sep string
|
|
n int
|
|
}{
|
|
{
|
|
in: &MakeString{
|
|
Strings: []string{
|
|
"a b c",
|
|
"d e f",
|
|
" h i j",
|
|
},
|
|
Variables: []Variable{
|
|
Variable{Name: SimpleMakeString("var1", NoPos)},
|
|
Variable{Name: SimpleMakeString("var2", NoPos)},
|
|
},
|
|
},
|
|
sep: " ",
|
|
n: -1,
|
|
expected: []*MakeString{
|
|
SimpleMakeString("a", NoPos),
|
|
SimpleMakeString("b", NoPos),
|
|
&MakeString{
|
|
Strings: []string{"c", "d"},
|
|
Variables: []Variable{
|
|
Variable{Name: SimpleMakeString("var1", NoPos)},
|
|
},
|
|
},
|
|
SimpleMakeString("e", NoPos),
|
|
&MakeString{
|
|
Strings: []string{"f", ""},
|
|
Variables: []Variable{
|
|
Variable{Name: SimpleMakeString("var2", NoPos)},
|
|
},
|
|
},
|
|
SimpleMakeString("h", NoPos),
|
|
SimpleMakeString("i", NoPos),
|
|
SimpleMakeString("j", NoPos),
|
|
},
|
|
},
|
|
{
|
|
in: &MakeString{
|
|
Strings: []string{
|
|
"a b c",
|
|
"d e f",
|
|
" h i j",
|
|
},
|
|
Variables: []Variable{
|
|
Variable{Name: SimpleMakeString("var1", NoPos)},
|
|
Variable{Name: SimpleMakeString("var2", NoPos)},
|
|
},
|
|
},
|
|
sep: " ",
|
|
n: 3,
|
|
expected: []*MakeString{
|
|
SimpleMakeString("a", NoPos),
|
|
SimpleMakeString("b", NoPos),
|
|
&MakeString{
|
|
Strings: []string{"c", "d e f", " h i j"},
|
|
Variables: []Variable{
|
|
Variable{Name: SimpleMakeString("var1", NoPos)},
|
|
Variable{Name: SimpleMakeString("var2", NoPos)},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
func TestMakeStringSplitN(t *testing.T) {
|
|
for _, test := range splitNTestCases {
|
|
got := test.in.SplitN(test.sep, test.n)
|
|
gotString := dumpArray(got)
|
|
expectedString := dumpArray(test.expected)
|
|
if gotString != expectedString {
|
|
t.Errorf("expected:\n%s\ngot:\n%s", expectedString, gotString)
|
|
}
|
|
}
|
|
}
|
|
|
|
func dumpArray(a []*MakeString) string {
|
|
ret := make([]string, len(a))
|
|
|
|
for i, s := range a {
|
|
ret[i] = s.Dump()
|
|
}
|
|
|
|
return strings.Join(ret, "|||")
|
|
}
|