a03cf6d322
For every file which we can run clang-tidy (C/C++ clang-built), we add a new build node that depends on the object file (since clang-tidy does not export a depfile), and is depended on by the link step. This is better than how we're doing it in make, since calling tidy can be turned on or off without needing to rebuild the object files. This does not attempt to port WITH_TIDY_ONLY from Make, since the way that it works is broken (due to the lack of a depfile). Bug: 32244182 Test: WITH_TIDY=true mmma -j bionic/libc Test: ./soong (Setting ClangTidy: true) Change-Id: I40bbb5bb00d292d72bf1c293b93080b5f9f6d8ea
111 lines
2.8 KiB
Go
111 lines
2.8 KiB
Go
// Copyright 2015 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package cc
|
|
|
|
import (
|
|
"fmt"
|
|
"regexp"
|
|
"strings"
|
|
|
|
"android/soong/android"
|
|
)
|
|
|
|
// Efficiently converts a list of include directories to a single string
|
|
// of cflags with -I prepended to each directory.
|
|
func includeDirsToFlags(dirs android.Paths) string {
|
|
return android.JoinWithPrefix(dirs.Strings(), "-I")
|
|
}
|
|
|
|
func includeFilesToFlags(files android.Paths) string {
|
|
return android.JoinWithPrefix(files.Strings(), "-include ")
|
|
}
|
|
|
|
func ldDirsToFlags(dirs []string) string {
|
|
return android.JoinWithPrefix(dirs, "-L")
|
|
}
|
|
|
|
func libNamesToFlags(names []string) string {
|
|
return android.JoinWithPrefix(names, "-l")
|
|
}
|
|
|
|
func indexList(s string, list []string) int {
|
|
for i, l := range list {
|
|
if l == s {
|
|
return i
|
|
}
|
|
}
|
|
|
|
return -1
|
|
}
|
|
|
|
func inList(s string, list []string) bool {
|
|
return indexList(s, list) != -1
|
|
}
|
|
|
|
func filterList(list []string, filter []string) (remainder []string, filtered []string) {
|
|
for _, l := range list {
|
|
if inList(l, filter) {
|
|
filtered = append(filtered, l)
|
|
} else {
|
|
remainder = append(remainder, l)
|
|
}
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
func removeFromList(s string, list []string) (bool, []string) {
|
|
i := indexList(s, list)
|
|
if i != -1 {
|
|
return true, append(list[:i], list[i+1:]...)
|
|
} else {
|
|
return false, list
|
|
}
|
|
}
|
|
|
|
var libNameRegexp = regexp.MustCompile(`^lib(.*)$`)
|
|
|
|
func moduleToLibName(module string) (string, error) {
|
|
matches := libNameRegexp.FindStringSubmatch(module)
|
|
if matches == nil {
|
|
return "", fmt.Errorf("Library module name %s does not start with lib", module)
|
|
}
|
|
return matches[1], nil
|
|
}
|
|
|
|
func flagsToBuilderFlags(in Flags) builderFlags {
|
|
return builderFlags{
|
|
globalFlags: strings.Join(in.GlobalFlags, " "),
|
|
asFlags: strings.Join(in.AsFlags, " "),
|
|
cFlags: strings.Join(in.CFlags, " "),
|
|
conlyFlags: strings.Join(in.ConlyFlags, " "),
|
|
cppFlags: strings.Join(in.CppFlags, " "),
|
|
yaccFlags: strings.Join(in.YaccFlags, " "),
|
|
protoFlags: strings.Join(in.protoFlags, " "),
|
|
ldFlags: strings.Join(in.LdFlags, " "),
|
|
libFlags: strings.Join(in.libFlags, " "),
|
|
tidyFlags: strings.Join(in.TidyFlags, " "),
|
|
toolchain: in.Toolchain,
|
|
clang: in.Clang,
|
|
tidy: in.Tidy,
|
|
}
|
|
}
|
|
|
|
func addPrefix(list []string, prefix string) []string {
|
|
for i := range list {
|
|
list[i] = prefix + list[i]
|
|
}
|
|
return list
|
|
}
|