f3c706868a
Previously, Soong's phony simply added "required" or "host_required"
to LOCAL_REQUIRED_MODULES and `include BUILD_PHONY_PACKAGE` without
correctly adding them to the dependency list.
This change add a new `phony_rule` module type to Soong that acts like
`.PHONY` instead of `BUILD_PHONY_PACKAGE`
Bug: 316838256
Bug: 309730110
Test: 1. Use `phony_rule` and adding "phony_deps: [dep_modules]" to
Android.bp.
2. make target and check the dep_modules be built.
Change-Id: I3e9e9ac26ecc456668f1b6baf5c08f9c9139b3b2
111 lines
3.3 KiB
Go
111 lines
3.3 KiB
Go
// Copyright 2016 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package phony
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"strings"
|
|
|
|
"android/soong/android"
|
|
)
|
|
|
|
func init() {
|
|
android.RegisterModuleType("phony", PhonyFactory)
|
|
android.RegisterModuleType("phony_rule", PhonyRuleFactory)
|
|
}
|
|
|
|
type phony struct {
|
|
android.ModuleBase
|
|
requiredModuleNames []string
|
|
hostRequiredModuleNames []string
|
|
targetRequiredModuleNames []string
|
|
}
|
|
|
|
func PhonyFactory() android.Module {
|
|
module := &phony{}
|
|
|
|
android.InitAndroidArchModule(module, android.HostAndDeviceSupported, android.MultilibCommon)
|
|
return module
|
|
}
|
|
|
|
func (p *phony) GenerateAndroidBuildActions(ctx android.ModuleContext) {
|
|
p.requiredModuleNames = ctx.RequiredModuleNames()
|
|
p.hostRequiredModuleNames = ctx.HostRequiredModuleNames()
|
|
p.targetRequiredModuleNames = ctx.TargetRequiredModuleNames()
|
|
}
|
|
|
|
func (p *phony) AndroidMk() android.AndroidMkData {
|
|
return android.AndroidMkData{
|
|
Custom: func(w io.Writer, name, prefix, moduleDir string, data android.AndroidMkData) {
|
|
fmt.Fprintln(w, "\ninclude $(CLEAR_VARS)", " # phony.phony")
|
|
fmt.Fprintln(w, "LOCAL_PATH :=", moduleDir)
|
|
fmt.Fprintln(w, "LOCAL_MODULE :=", name)
|
|
if p.Host() {
|
|
fmt.Fprintln(w, "LOCAL_IS_HOST_MODULE := true")
|
|
}
|
|
if len(p.requiredModuleNames) > 0 {
|
|
fmt.Fprintln(w, "LOCAL_REQUIRED_MODULES :=",
|
|
strings.Join(p.requiredModuleNames, " "))
|
|
}
|
|
if len(p.hostRequiredModuleNames) > 0 {
|
|
fmt.Fprintln(w, "LOCAL_HOST_REQUIRED_MODULES :=",
|
|
strings.Join(p.hostRequiredModuleNames, " "))
|
|
}
|
|
if len(p.targetRequiredModuleNames) > 0 {
|
|
fmt.Fprintln(w, "LOCAL_TARGET_REQUIRED_MODULES :=",
|
|
strings.Join(p.targetRequiredModuleNames, " "))
|
|
}
|
|
fmt.Fprintln(w, "include $(BUILD_PHONY_PACKAGE)")
|
|
},
|
|
}
|
|
}
|
|
|
|
type PhonyRule struct {
|
|
android.ModuleBase
|
|
|
|
properties PhonyProperties
|
|
}
|
|
|
|
type PhonyProperties struct {
|
|
// The Phony_deps is the set of all dependencies for this target,
|
|
// and it can function similarly to .PHONY in a makefile.
|
|
// Additionally, dependencies within it can even include genrule.
|
|
Phony_deps []string
|
|
}
|
|
|
|
// The phony_rule provides functionality similar to the .PHONY in a makefile.
|
|
// It can create a phony target and include relevant dependencies associated with it.
|
|
func PhonyRuleFactory() android.Module {
|
|
module := &PhonyRule{}
|
|
android.InitAndroidModule(module)
|
|
module.AddProperties(&module.properties)
|
|
return module
|
|
}
|
|
|
|
func (p *PhonyRule) GenerateAndroidBuildActions(ctx android.ModuleContext) {
|
|
}
|
|
|
|
func (p *PhonyRule) AndroidMk() android.AndroidMkData {
|
|
return android.AndroidMkData{
|
|
Custom: func(w io.Writer, name, prefix, moduleDir string, data android.AndroidMkData) {
|
|
if len(p.properties.Phony_deps) > 0 {
|
|
depModulesStr := strings.Join(p.properties.Phony_deps, " ")
|
|
fmt.Fprintln(w, ".PHONY:", name)
|
|
fmt.Fprintln(w, name, ":", depModulesStr)
|
|
}
|
|
},
|
|
}
|
|
}
|