c9508aac4c
There are a number of instances where we are exporting information from soong to bazel via soong_injection. This could be more bazel-centric if the information was instead held in bzl files, and both bazel and soong read it from there. Add a starlark package that will run //build/bazel/constants_exported_to_soong.bzl at initialization time, and then results can be retreived with GetStarlarkValue. Since changes to the starlark files mean that soong has to rerun, add them as ninja deps. Unfortunately, the starlark code has to be run at runtime rather than pregenerating their results, because tests run from intellij wouldn't go through any pregeneration steps. This means that starlark is run multiple times during the build, once per test package and once per primary builder invocation. (currently 3, could be reduced to 2 if we made the symlink forest generation into its own standalone tool) The starlark code we have so far in this cl is very fast, roughly half a millisecond, so it's not a big deal for now, but something to keep an eye on as we add more starlark constants. Bug: 279095899 Test: go test Change-Id: I1e7ca1df1d8d67333cbfc46e8396e229820e4476
53 lines
1.4 KiB
Go
53 lines
1.4 KiB
Go
// Copyright 2020 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package android
|
|
|
|
import (
|
|
"android/soong/starlark_import"
|
|
"sort"
|
|
)
|
|
|
|
func (c *config) addNinjaFileDeps(deps ...string) {
|
|
for _, dep := range deps {
|
|
c.ninjaFileDepsSet.Store(dep, true)
|
|
}
|
|
}
|
|
|
|
func (c *config) ninjaFileDeps() []string {
|
|
var deps []string
|
|
c.ninjaFileDepsSet.Range(func(key, value interface{}) bool {
|
|
deps = append(deps, key.(string))
|
|
return true
|
|
})
|
|
sort.Strings(deps)
|
|
return deps
|
|
}
|
|
|
|
func ninjaDepsSingletonFactory() Singleton {
|
|
return &ninjaDepsSingleton{}
|
|
}
|
|
|
|
type ninjaDepsSingleton struct{}
|
|
|
|
func (ninjaDepsSingleton) GenerateBuildActions(ctx SingletonContext) {
|
|
ctx.AddNinjaFileDeps(ctx.Config().ninjaFileDeps()...)
|
|
|
|
deps, err := starlark_import.GetNinjaDeps()
|
|
if err != nil {
|
|
ctx.Errorf("Error running starlark code: %s", err)
|
|
} else {
|
|
ctx.AddNinjaFileDeps(deps...)
|
|
}
|
|
}
|