6e511a9a9f
dependencyTag uses a set of predefined tags to identify different types
of dependencies. There are already multiple bits of metadata stored
in the dependency tag (Library, Shared, ReexportFlags), and supporting
them all requires a combinatorial explosion of predefined tags and
causes issues when using equality comparisons if a new bit of metadata
is added.
Add a new libraryDependencyTag type that will contain the metadata
bits, and replace the quality comparisons with checks on the metadata
bits.
There are 5 TODOs where modifying the checks identified problems with
the existing checks. These were left in place to produce identical
build output and will be fixed separately.
Bug: 162437057
Test: no change to build.ninja or {Android,make_vars,late}-${TARGET_PRODUCT}.mk
Change-Id: I72d4207dcf381c07c92e00e5a03968ebb5ed8d30
101 lines
3 KiB
Go
101 lines
3 KiB
Go
// Copyright 2017 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package cc
|
|
|
|
import (
|
|
"strings"
|
|
"sync"
|
|
|
|
"android/soong/android"
|
|
"android/soong/cc/config"
|
|
)
|
|
|
|
var (
|
|
lsdumpPaths []string
|
|
sabiLock sync.Mutex
|
|
)
|
|
|
|
type SAbiProperties struct {
|
|
CreateSAbiDumps bool `blueprint:"mutated"`
|
|
ReexportedIncludes []string `blueprint:"mutated"`
|
|
}
|
|
|
|
type sabi struct {
|
|
Properties SAbiProperties
|
|
}
|
|
|
|
func (sabimod *sabi) props() []interface{} {
|
|
return []interface{}{&sabimod.Properties}
|
|
}
|
|
|
|
func (sabimod *sabi) begin(ctx BaseModuleContext) {}
|
|
|
|
func (sabimod *sabi) deps(ctx BaseModuleContext, deps Deps) Deps {
|
|
return deps
|
|
}
|
|
|
|
func inListWithPrefixSearch(flag string, filter []string) bool {
|
|
// Assuming the filter is small enough.
|
|
// If the suffix of a filter element is *, try matching prefixes as well.
|
|
for _, f := range filter {
|
|
if (f == flag) || (strings.HasSuffix(f, "*") && strings.HasPrefix(flag, strings.TrimSuffix(f, "*"))) {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
func filterOutWithPrefix(list []string, filter []string) (remainder []string) {
|
|
// Go through the filter, matching and optionally doing a prefix search for list elements.
|
|
for _, l := range list {
|
|
if !inListWithPrefixSearch(l, filter) {
|
|
remainder = append(remainder, l)
|
|
}
|
|
}
|
|
return
|
|
}
|
|
|
|
func (sabimod *sabi) flags(ctx ModuleContext, flags Flags) Flags {
|
|
// Assuming that the cflags which clang LibTooling tools cannot
|
|
// understand have not been converted to ninja variables yet.
|
|
flags.Local.ToolingCFlags = filterOutWithPrefix(flags.Local.CFlags, config.ClangLibToolingUnknownCflags)
|
|
flags.Global.ToolingCFlags = filterOutWithPrefix(flags.Global.CFlags, config.ClangLibToolingUnknownCflags)
|
|
flags.Local.ToolingCppFlags = filterOutWithPrefix(flags.Local.CppFlags, config.ClangLibToolingUnknownCflags)
|
|
flags.Global.ToolingCppFlags = filterOutWithPrefix(flags.Global.CppFlags, config.ClangLibToolingUnknownCflags)
|
|
|
|
return flags
|
|
}
|
|
|
|
func sabiDepsMutator(mctx android.TopDownMutatorContext) {
|
|
if c, ok := mctx.Module().(*Module); ok &&
|
|
((c.IsVndk() && c.UseVndk()) || c.isLlndk(mctx.Config()) ||
|
|
(c.sabi != nil && c.sabi.Properties.CreateSAbiDumps)) {
|
|
mctx.VisitDirectDeps(func(m android.Module) {
|
|
if tag, ok := mctx.OtherModuleDependencyTag(m).(libraryDependencyTag); ok && tag.static() {
|
|
cc, _ := m.(*Module)
|
|
if cc == nil {
|
|
return
|
|
}
|
|
cc.sabi.Properties.CreateSAbiDumps = true
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func addLsdumpPath(lsdumpPath string) {
|
|
sabiLock.Lock()
|
|
lsdumpPaths = append(lsdumpPaths, lsdumpPath)
|
|
sabiLock.Unlock()
|
|
}
|