ff2aa69a86
Prior to this FixtureFactory was basically a FixturePreparer with the additional support for buildDirSupplier. This makes that a reality by moving the functionality of FixtureFactory into FixturePreparer and making FixtureFactory extend that with buildDirSupplier. This also deprecates the Extend() method in favour of simply using the GroupFixturePreparers() method. Once all usages of buildDir have been removed so the buildDirSupplier is no longer required then FixtureFactory will be removed altogether. In the meantime follow up changes will migrate those tests that do not require a buildDirSupplier to just use FixturePreparers in preparation for the eventual removal of FixtureFactory. Bug: 183235980 Test: m nothing Change-Id: Ibb4e5bfec2f76ee34dd7de6aed6bbbfe27d337b8
85 lines
3.1 KiB
Go
85 lines
3.1 KiB
Go
// Copyright 2021 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package android
|
|
|
|
import (
|
|
"testing"
|
|
)
|
|
|
|
// Make sure that FixturePreparer instances are only called once per fixture and in the order in
|
|
// which they were added.
|
|
func TestFixtureDedup(t *testing.T) {
|
|
list := []string{}
|
|
|
|
appendToList := func(s string) FixturePreparer {
|
|
return FixtureModifyConfig(func(_ Config) {
|
|
list = append(list, s)
|
|
})
|
|
}
|
|
|
|
preparer1 := appendToList("preparer1")
|
|
preparer2 := appendToList("preparer2")
|
|
preparer3 := appendToList("preparer3")
|
|
preparer4 := OptionalFixturePreparer(appendToList("preparer4"))
|
|
nilPreparer := OptionalFixturePreparer(nil)
|
|
|
|
preparer1Then2 := GroupFixturePreparers(preparer1, preparer2, nilPreparer)
|
|
|
|
preparer2Then1 := GroupFixturePreparers(preparer2, preparer1)
|
|
|
|
group := GroupFixturePreparers(preparer1, preparer2, preparer1, preparer1Then2)
|
|
|
|
extension := group.Extend(preparer4, preparer2)
|
|
|
|
extension.Fixture(t, preparer1, preparer2, preparer2Then1, preparer3)
|
|
|
|
AssertDeepEquals(t, "preparers called in wrong order",
|
|
[]string{"preparer1", "preparer2", "preparer4", "preparer3"}, list)
|
|
}
|
|
|
|
func TestFixtureValidateMockFS(t *testing.T) {
|
|
buildDir := "<unused>"
|
|
factory := NewFixtureFactory(&buildDir)
|
|
|
|
t.Run("absolute path", func(t *testing.T) {
|
|
AssertPanicMessageContains(t, "source path validation failed", "Path is outside directory: /abs/path/Android.bp", func() {
|
|
factory.Fixture(t, FixtureAddFile("/abs/path/Android.bp", nil))
|
|
})
|
|
})
|
|
t.Run("not canonical", func(t *testing.T) {
|
|
AssertPanicMessageContains(t, "source path validation failed", `path "path/with/../in/it/Android.bp" is not a canonical path, use "path/in/it/Android.bp" instead`, func() {
|
|
factory.Fixture(t, FixtureAddFile("path/with/../in/it/Android.bp", nil))
|
|
})
|
|
})
|
|
t.Run("FixtureAddFile", func(t *testing.T) {
|
|
AssertPanicMessageContains(t, "source path validation failed", `cannot add output path "out/Android.bp" to the mock file system`, func() {
|
|
factory.Fixture(t, FixtureAddFile("out/Android.bp", nil))
|
|
})
|
|
})
|
|
t.Run("FixtureMergeMockFs", func(t *testing.T) {
|
|
AssertPanicMessageContains(t, "source path validation failed", `cannot add output path "out/Android.bp" to the mock file system`, func() {
|
|
factory.Fixture(t, FixtureMergeMockFs(MockFS{
|
|
"out/Android.bp": nil,
|
|
}))
|
|
})
|
|
})
|
|
t.Run("FixtureModifyMockFS", func(t *testing.T) {
|
|
AssertPanicMessageContains(t, "source path validation failed", `cannot add output path "out/Android.bp" to the mock file system`, func() {
|
|
factory.Fixture(t, FixtureModifyMockFS(func(fs MockFS) {
|
|
fs["out/Android.bp"] = nil
|
|
}))
|
|
})
|
|
})
|
|
}
|