0773a60302
Create bp2build converters for the following module types - ndk_headers - versioned_ndk_headers Details - Partial bp2build conversion. Only `cc_api_headers` targets will be generted within the scope of this CL - Glob expansion. Aligned with other bp2build converters, this impl will expand globs in Android.bp so that all .h files are explicitly listed in the generated BUILD files. As an extreme example, the size of out/soong/workspace/bionic/libc/BUILD will increase from ~170KB to ~230KB (33% increase). This makes the BUILD files less readable, and `cc_api_headers` section of the BUILD file should probably not be checked into the tree in this format Test: b cquery //bionic/libc:libc_uapi --output=starlark --starlark:expr="providers(target).get('//build/bazel/rules/apis:cc_api_contribution.bzl%CcApiHeaderInfo')" Test: go test ./bp2build Test: go test ./cc Change-Id: I810d5380f72dc90f4cdf4aa508570f3a80d8d932
418 lines
13 KiB
Go
418 lines
13 KiB
Go
// Copyright 2016 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package cc
|
|
|
|
import (
|
|
"fmt"
|
|
"path/filepath"
|
|
|
|
"github.com/google/blueprint"
|
|
"github.com/google/blueprint/proptools"
|
|
|
|
"android/soong/android"
|
|
"android/soong/bazel"
|
|
)
|
|
|
|
var (
|
|
versionBionicHeaders = pctx.AndroidStaticRule("versionBionicHeaders",
|
|
blueprint.RuleParams{
|
|
// The `&& touch $out` isn't really necessary, but Blueprint won't
|
|
// let us have only implicit outputs.
|
|
Command: "$versionerCmd -o $outDir $srcDir $depsPath && touch $out",
|
|
CommandDeps: []string{"$versionerCmd"},
|
|
},
|
|
"depsPath", "srcDir", "outDir")
|
|
|
|
preprocessNdkHeader = pctx.AndroidStaticRule("preprocessNdkHeader",
|
|
blueprint.RuleParams{
|
|
Command: "$preprocessor -o $out $in",
|
|
CommandDeps: []string{"$preprocessor"},
|
|
},
|
|
"preprocessor")
|
|
)
|
|
|
|
func init() {
|
|
pctx.SourcePathVariable("versionerCmd", "prebuilts/clang-tools/${config.HostPrebuiltTag}/bin/versioner")
|
|
}
|
|
|
|
// Returns the NDK base include path for use with sdk_version current. Usable with -I.
|
|
func getCurrentIncludePath(ctx android.ModuleContext) android.InstallPath {
|
|
return getNdkSysrootBase(ctx).Join(ctx, "usr/include")
|
|
}
|
|
|
|
type headerProperties struct {
|
|
// Base directory of the headers being installed. As an example:
|
|
//
|
|
// ndk_headers {
|
|
// name: "foo",
|
|
// from: "include",
|
|
// to: "",
|
|
// srcs: ["include/foo/bar/baz.h"],
|
|
// }
|
|
//
|
|
// Will install $SYSROOT/usr/include/foo/bar/baz.h. If `from` were instead
|
|
// "include/foo", it would have installed $SYSROOT/usr/include/bar/baz.h.
|
|
From *string
|
|
|
|
// Install path within the sysroot. This is relative to usr/include.
|
|
To *string
|
|
|
|
// List of headers to install. Glob compatible. Common case is "include/**/*.h".
|
|
Srcs []string `android:"path"`
|
|
|
|
// Source paths that should be excluded from the srcs glob.
|
|
Exclude_srcs []string `android:"path"`
|
|
|
|
// Path to the NOTICE file associated with the headers.
|
|
License *string `android:"path"`
|
|
}
|
|
|
|
type headerModule struct {
|
|
android.ModuleBase
|
|
android.BazelModuleBase
|
|
|
|
properties headerProperties
|
|
|
|
installPaths android.Paths
|
|
licensePath android.Path
|
|
}
|
|
|
|
func getHeaderInstallDir(ctx android.ModuleContext, header android.Path, from string,
|
|
to string) android.InstallPath {
|
|
// Output path is the sysroot base + "usr/include" + to directory + directory component
|
|
// of the file without the leading from directory stripped.
|
|
//
|
|
// Given:
|
|
// sysroot base = "ndk/sysroot"
|
|
// from = "include/foo"
|
|
// to = "bar"
|
|
// header = "include/foo/woodly/doodly.h"
|
|
// output path = "ndk/sysroot/usr/include/bar/woodly/doodly.h"
|
|
|
|
// full/platform/path/to/include/foo
|
|
fullFromPath := android.PathForModuleSrc(ctx, from)
|
|
|
|
// full/platform/path/to/include/foo/woodly
|
|
headerDir := filepath.Dir(header.String())
|
|
|
|
// woodly
|
|
strippedHeaderDir, err := filepath.Rel(fullFromPath.String(), headerDir)
|
|
if err != nil {
|
|
ctx.ModuleErrorf("filepath.Rel(%q, %q) failed: %s", headerDir,
|
|
fullFromPath.String(), err)
|
|
}
|
|
|
|
// full/platform/path/to/sysroot/usr/include/bar/woodly
|
|
installDir := getCurrentIncludePath(ctx).Join(ctx, to, strippedHeaderDir)
|
|
|
|
// full/platform/path/to/sysroot/usr/include/bar/woodly/doodly.h
|
|
return installDir
|
|
}
|
|
|
|
func (m *headerModule) GenerateAndroidBuildActions(ctx android.ModuleContext) {
|
|
if String(m.properties.License) == "" {
|
|
ctx.PropertyErrorf("license", "field is required")
|
|
}
|
|
|
|
m.licensePath = android.PathForModuleSrc(ctx, String(m.properties.License))
|
|
|
|
srcFiles := android.PathsForModuleSrcExcludes(ctx, m.properties.Srcs, m.properties.Exclude_srcs)
|
|
for _, header := range srcFiles {
|
|
installDir := getHeaderInstallDir(ctx, header, String(m.properties.From),
|
|
String(m.properties.To))
|
|
installedPath := ctx.InstallFile(installDir, header.Base(), header)
|
|
installPath := installDir.Join(ctx, header.Base())
|
|
if installPath != installedPath {
|
|
panic(fmt.Sprintf(
|
|
"expected header install path (%q) not equal to actual install path %q",
|
|
installPath, installedPath))
|
|
}
|
|
m.installPaths = append(m.installPaths, installPath)
|
|
}
|
|
|
|
if len(m.installPaths) == 0 {
|
|
ctx.ModuleErrorf("srcs %q matched zero files", m.properties.Srcs)
|
|
}
|
|
}
|
|
|
|
const (
|
|
apiContributionSuffix = ".contribution"
|
|
)
|
|
|
|
// apiContributionTargetName returns the name of the cc_api(headers|contribution) bp2build target of ndk modules
|
|
// A suffix is necessary to prevent a name collision with the base ndk_(library|header) target in the same bp2build bazel package
|
|
func apiContributionTargetName(moduleName string) string {
|
|
return moduleName + apiContributionSuffix
|
|
}
|
|
|
|
// TODO(b/243196151): Populate `system` and `arch` metadata
|
|
type bazelCcApiHeadersAttributes struct {
|
|
Hdrs bazel.LabelListAttribute
|
|
Include_dir *string
|
|
}
|
|
|
|
func createCcApiHeadersTarget(ctx android.TopDownMutatorContext, includes []string, excludes []string, include_dir *string) {
|
|
props := bazel.BazelTargetModuleProperties{
|
|
Rule_class: "cc_api_headers",
|
|
Bzl_load_location: "//build/bazel/rules/apis:cc_api_contribution.bzl",
|
|
}
|
|
attrs := &bazelCcApiHeadersAttributes{
|
|
Hdrs: bazel.MakeLabelListAttribute(
|
|
android.BazelLabelForModuleSrcExcludes(
|
|
ctx,
|
|
includes,
|
|
excludes,
|
|
),
|
|
),
|
|
Include_dir: include_dir,
|
|
}
|
|
ctx.CreateBazelTargetModule(props, android.CommonAttributes{
|
|
Name: apiContributionTargetName(ctx.ModuleName()),
|
|
}, attrs)
|
|
}
|
|
|
|
func (h *headerModule) ConvertWithBp2build(ctx android.TopDownMutatorContext) {
|
|
// Generate `cc_api_headers` target for Multi-tree API export
|
|
createCcApiHeadersTarget(ctx, h.properties.Srcs, h.properties.Exclude_srcs, h.properties.From)
|
|
}
|
|
|
|
// ndk_headers installs the sets of ndk headers defined in the srcs property
|
|
// to the sysroot base + "usr/include" + to directory + directory component.
|
|
// ndk_headers requires the license file to be specified. Example:
|
|
//
|
|
// Given:
|
|
// sysroot base = "ndk/sysroot"
|
|
// from = "include/foo"
|
|
// to = "bar"
|
|
// header = "include/foo/woodly/doodly.h"
|
|
// output path = "ndk/sysroot/usr/include/bar/woodly/doodly.h"
|
|
func ndkHeadersFactory() android.Module {
|
|
module := &headerModule{}
|
|
module.AddProperties(&module.properties)
|
|
android.InitAndroidModule(module)
|
|
android.InitBazelModule(module)
|
|
return module
|
|
}
|
|
|
|
type versionedHeaderProperties struct {
|
|
// Base directory of the headers being installed. As an example:
|
|
//
|
|
// versioned_ndk_headers {
|
|
// name: "foo",
|
|
// from: "include",
|
|
// to: "",
|
|
// }
|
|
//
|
|
// Will install $SYSROOT/usr/include/foo/bar/baz.h. If `from` were instead
|
|
// "include/foo", it would have installed $SYSROOT/usr/include/bar/baz.h.
|
|
From *string
|
|
|
|
// Install path within the sysroot. This is relative to usr/include.
|
|
To *string
|
|
|
|
// Path to the NOTICE file associated with the headers.
|
|
License *string
|
|
}
|
|
|
|
// Like ndk_headers, but preprocesses the headers with the bionic versioner:
|
|
// https://android.googlesource.com/platform/bionic/+/master/tools/versioner/README.md.
|
|
//
|
|
// Unlike ndk_headers, we don't operate on a list of sources but rather a whole directory, the
|
|
// module does not have the srcs property, and operates on a full directory (the `from` property).
|
|
//
|
|
// Note that this is really only built to handle bionic/libc/include.
|
|
type versionedHeaderModule struct {
|
|
android.ModuleBase
|
|
android.BazelModuleBase
|
|
|
|
properties versionedHeaderProperties
|
|
|
|
installPaths android.Paths
|
|
licensePath android.Path
|
|
}
|
|
|
|
// Return the glob pattern to find all .h files beneath `dir`
|
|
func headerGlobPattern(dir string) string {
|
|
return filepath.Join(dir, "**", "*.h")
|
|
}
|
|
|
|
func (m *versionedHeaderModule) GenerateAndroidBuildActions(ctx android.ModuleContext) {
|
|
if String(m.properties.License) == "" {
|
|
ctx.PropertyErrorf("license", "field is required")
|
|
}
|
|
|
|
m.licensePath = android.PathForModuleSrc(ctx, String(m.properties.License))
|
|
|
|
fromSrcPath := android.PathForModuleSrc(ctx, String(m.properties.From))
|
|
toOutputPath := getCurrentIncludePath(ctx).Join(ctx, String(m.properties.To))
|
|
srcFiles := ctx.GlobFiles(headerGlobPattern(fromSrcPath.String()), nil)
|
|
var installPaths []android.WritablePath
|
|
for _, header := range srcFiles {
|
|
installDir := getHeaderInstallDir(ctx, header, String(m.properties.From), String(m.properties.To))
|
|
installPath := installDir.Join(ctx, header.Base())
|
|
installPaths = append(installPaths, installPath)
|
|
m.installPaths = append(m.installPaths, installPath)
|
|
}
|
|
|
|
if len(m.installPaths) == 0 {
|
|
ctx.ModuleErrorf("glob %q matched zero files", String(m.properties.From))
|
|
}
|
|
|
|
processHeadersWithVersioner(ctx, fromSrcPath, toOutputPath, srcFiles, installPaths)
|
|
}
|
|
|
|
func (h *versionedHeaderModule) ConvertWithBp2build(ctx android.TopDownMutatorContext) {
|
|
// Glob all .h files under `From`
|
|
includePattern := headerGlobPattern(proptools.String(h.properties.From))
|
|
// Generate `cc_api_headers` target for Multi-tree API export
|
|
createCcApiHeadersTarget(ctx, []string{includePattern}, []string{}, h.properties.From)
|
|
}
|
|
|
|
func processHeadersWithVersioner(ctx android.ModuleContext, srcDir, outDir android.Path,
|
|
srcFiles android.Paths, installPaths []android.WritablePath) android.Path {
|
|
// The versioner depends on a dependencies directory to simplify determining include paths
|
|
// when parsing headers. This directory contains architecture specific directories as well
|
|
// as a common directory, each of which contains symlinks to the actually directories to
|
|
// be included.
|
|
//
|
|
// ctx.Glob doesn't follow symlinks, so we need to do this ourselves so we correctly
|
|
// depend on these headers.
|
|
// TODO(http://b/35673191): Update the versioner to use a --sysroot.
|
|
depsPath := android.PathForSource(ctx, "bionic/libc/versioner-dependencies")
|
|
depsGlob := ctx.Glob(filepath.Join(depsPath.String(), "**/*"), nil)
|
|
for i, path := range depsGlob {
|
|
if ctx.IsSymlink(path) {
|
|
dest := ctx.Readlink(path)
|
|
// Additional .. to account for the symlink itself.
|
|
depsGlob[i] = android.PathForSource(
|
|
ctx, filepath.Clean(filepath.Join(path.String(), "..", dest)))
|
|
}
|
|
}
|
|
|
|
timestampFile := android.PathForModuleOut(ctx, "versioner.timestamp")
|
|
ctx.Build(pctx, android.BuildParams{
|
|
Rule: versionBionicHeaders,
|
|
Description: "versioner preprocess " + srcDir.Rel(),
|
|
Output: timestampFile,
|
|
Implicits: append(srcFiles, depsGlob...),
|
|
ImplicitOutputs: installPaths,
|
|
Args: map[string]string{
|
|
"depsPath": depsPath.String(),
|
|
"srcDir": srcDir.String(),
|
|
"outDir": outDir.String(),
|
|
},
|
|
})
|
|
|
|
return timestampFile
|
|
}
|
|
|
|
// versioned_ndk_headers preprocesses the headers with the bionic versioner:
|
|
// https://android.googlesource.com/platform/bionic/+/master/tools/versioner/README.md.
|
|
// Unlike the ndk_headers soong module, versioned_ndk_headers operates on a
|
|
// directory level specified in `from` property. This is only used to process
|
|
// the bionic/libc/include directory.
|
|
func versionedNdkHeadersFactory() android.Module {
|
|
module := &versionedHeaderModule{}
|
|
|
|
module.AddProperties(&module.properties)
|
|
|
|
android.InitAndroidModule(module)
|
|
android.InitBazelModule(module)
|
|
|
|
return module
|
|
}
|
|
|
|
// preprocessed_ndk_header {
|
|
//
|
|
// name: "foo",
|
|
// preprocessor: "foo.sh",
|
|
// srcs: [...],
|
|
// to: "android",
|
|
//
|
|
// }
|
|
//
|
|
// Will invoke the preprocessor as:
|
|
//
|
|
// $preprocessor -o $SYSROOT/usr/include/android/needs_preproc.h $src
|
|
//
|
|
// For each src in srcs.
|
|
type preprocessedHeadersProperties struct {
|
|
// The preprocessor to run. Must be a program inside the source directory
|
|
// with no dependencies.
|
|
Preprocessor *string
|
|
|
|
// Source path to the files to be preprocessed.
|
|
Srcs []string
|
|
|
|
// Source paths that should be excluded from the srcs glob.
|
|
Exclude_srcs []string
|
|
|
|
// Install path within the sysroot. This is relative to usr/include.
|
|
To *string
|
|
|
|
// Path to the NOTICE file associated with the headers.
|
|
License *string
|
|
}
|
|
|
|
type preprocessedHeadersModule struct {
|
|
android.ModuleBase
|
|
|
|
properties preprocessedHeadersProperties
|
|
|
|
installPaths android.Paths
|
|
licensePath android.Path
|
|
}
|
|
|
|
func (m *preprocessedHeadersModule) GenerateAndroidBuildActions(ctx android.ModuleContext) {
|
|
if String(m.properties.License) == "" {
|
|
ctx.PropertyErrorf("license", "field is required")
|
|
}
|
|
|
|
preprocessor := android.PathForModuleSrc(ctx, String(m.properties.Preprocessor))
|
|
m.licensePath = android.PathForModuleSrc(ctx, String(m.properties.License))
|
|
|
|
srcFiles := android.PathsForModuleSrcExcludes(ctx, m.properties.Srcs, m.properties.Exclude_srcs)
|
|
installDir := getCurrentIncludePath(ctx).Join(ctx, String(m.properties.To))
|
|
for _, src := range srcFiles {
|
|
installPath := installDir.Join(ctx, src.Base())
|
|
m.installPaths = append(m.installPaths, installPath)
|
|
|
|
ctx.Build(pctx, android.BuildParams{
|
|
Rule: preprocessNdkHeader,
|
|
Description: "preprocess " + src.Rel(),
|
|
Input: src,
|
|
Output: installPath,
|
|
Args: map[string]string{
|
|
"preprocessor": preprocessor.String(),
|
|
},
|
|
})
|
|
}
|
|
|
|
if len(m.installPaths) == 0 {
|
|
ctx.ModuleErrorf("srcs %q matched zero files", m.properties.Srcs)
|
|
}
|
|
}
|
|
|
|
// preprocessed_ndk_headers preprocesses all the ndk headers listed in the srcs
|
|
// property by executing the command defined in the preprocessor property.
|
|
func preprocessedNdkHeadersFactory() android.Module {
|
|
module := &preprocessedHeadersModule{}
|
|
|
|
module.AddProperties(&module.properties)
|
|
|
|
android.InitAndroidModule(module)
|
|
|
|
return module
|
|
}
|