6817bbb3c8
Soong supports string properties, but they are overloaded, and can mean one of three things: * path reference * module reference * string literal Bazel has different types: label and string attributes. Thus there needs to be a way to categorize them correctly in bp2build. This CL introduces a new function to be used on properties like apex_key.private_key / apex_key.public_key, as well as android_app.certificate / apex.certificate. It is important to disambiguate the prop betenn a string literal attribute or file/rule target label attribute, so this functions does just that. The new attributes are then further handled by their respective macros (apex_key, android_binary, apex). Bug: 253557437 Fixes: 253557437 Test: presubmits, new tests Change-Id: Id8111cdd60d3aabcae7d17fe9da84d0ee3966023
97 lines
3.3 KiB
Go
97 lines
3.3 KiB
Go
// Copyright 2021 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package bp2build
|
|
|
|
import (
|
|
"android/soong/android"
|
|
"android/soong/apex"
|
|
|
|
"testing"
|
|
)
|
|
|
|
func runApexKeyTestCase(t *testing.T, tc Bp2buildTestCase) {
|
|
t.Helper()
|
|
RunBp2BuildTestCase(t, registerApexKeyModuleTypes, tc)
|
|
}
|
|
|
|
func registerApexKeyModuleTypes(ctx android.RegistrationContext) {
|
|
ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
|
|
}
|
|
|
|
func TestApexKeySimple_KeysAreSrcFilesInSameDir(t *testing.T) {
|
|
runApexKeyTestCase(t, Bp2buildTestCase{
|
|
Description: "apex key - keys are src files, use key attributes",
|
|
ModuleTypeUnderTest: "apex_key",
|
|
ModuleTypeUnderTestFactory: apex.ApexKeyFactory,
|
|
Filesystem: map[string]string{
|
|
"com.android.apogee.avbpubkey": "",
|
|
"com.android.apogee.pem": "",
|
|
},
|
|
Blueprint: `
|
|
apex_key {
|
|
name: "com.android.apogee.key",
|
|
public_key: "com.android.apogee.avbpubkey",
|
|
private_key: "com.android.apogee.pem",
|
|
}
|
|
`,
|
|
ExpectedBazelTargets: []string{MakeBazelTargetNoRestrictions("apex_key", "com.android.apogee.key", AttrNameToString{
|
|
"private_key": `"com.android.apogee.pem"`,
|
|
"public_key": `"com.android.apogee.avbpubkey"`,
|
|
}),
|
|
}})
|
|
}
|
|
|
|
func TestApexKeySimple_KeysAreSrcFilesNotInDir(t *testing.T) {
|
|
runApexKeyTestCase(t, Bp2buildTestCase{
|
|
Description: "apex key - keys are not src or module, use key_name attributes",
|
|
ModuleTypeUnderTest: "apex_key",
|
|
ModuleTypeUnderTestFactory: apex.ApexKeyFactory,
|
|
Filesystem: map[string]string{
|
|
// deliberately left empty
|
|
},
|
|
Blueprint: `
|
|
apex_key {
|
|
name: "com.android.apogee.key",
|
|
public_key: "com.android.apogee.avbpubkey",
|
|
private_key: "com.android.apogee.pem",
|
|
}
|
|
`,
|
|
ExpectedBazelTargets: []string{MakeBazelTargetNoRestrictions("apex_key", "com.android.apogee.key", AttrNameToString{
|
|
"private_key_name": `"com.android.apogee.pem"`,
|
|
"public_key_name": `"com.android.apogee.avbpubkey"`,
|
|
}),
|
|
}})
|
|
}
|
|
|
|
func TestApexKey_KeysAreModules(t *testing.T) {
|
|
runApexKeyTestCase(t, Bp2buildTestCase{
|
|
Description: "apex key - keys are modules, use key attributes",
|
|
ModuleTypeUnderTest: "apex_key",
|
|
ModuleTypeUnderTestFactory: apex.ApexKeyFactory,
|
|
Filesystem: map[string]string{},
|
|
Blueprint: `
|
|
apex_key {
|
|
name: "com.android.apogee.key",
|
|
public_key: ":com.android.apogee.avbpubkey",
|
|
private_key: ":com.android.apogee.pem",
|
|
}
|
|
` + simpleModuleDoNotConvertBp2build("filegroup", "com.android.apogee.avbpubkey") +
|
|
simpleModuleDoNotConvertBp2build("filegroup", "com.android.apogee.pem"),
|
|
ExpectedBazelTargets: []string{MakeBazelTargetNoRestrictions("apex_key", "com.android.apogee.key", AttrNameToString{
|
|
"private_key": `":com.android.apogee.pem"`,
|
|
"public_key": `":com.android.apogee.avbpubkey"`,
|
|
}),
|
|
}})
|
|
}
|