5df7bd33f7
Previously, crt objects for APEX and vendor variants targetted API level 16 regardless of their context. For example, even if BOARD_VNDK_VERSION is set to 29, or an APEX has `min_sdk_version: "29"`, the target API level was from `min_sdk_version` property of the crt object which is set to 16. The meaning of min_sdk_version is quite different when it comes to crt objects. It means the lowest API level that it CAN target for. It does NOT mean the API level it SHOULD always target. This has caused some other problems like TLS segment underalignment for vendor libraries because the vendor libraries were all built with TLS layout from API level 16. This change fixes the problem by correctly implementing the different semantic of min_sdk_version for crt objects. Bug: N/A Test: m nothing Change-Id: I15328e0b6cbabbe151dd65c7469c6355e167b78a
109 lines
3.1 KiB
Go
109 lines
3.1 KiB
Go
// Copyright 2019 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package cc
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"android/soong/android"
|
|
)
|
|
|
|
func TestMinSdkVersionsOfCrtObjects(t *testing.T) {
|
|
ctx := testCc(t, `
|
|
cc_object {
|
|
name: "crt_foo",
|
|
srcs: ["foo.c"],
|
|
crt: true,
|
|
stl: "none",
|
|
min_sdk_version: "28",
|
|
vendor_available: true,
|
|
}`)
|
|
|
|
variants := []struct {
|
|
variant string
|
|
num string
|
|
}{
|
|
{"android_arm64_armv8-a", "10000"},
|
|
{"android_arm64_armv8-a_sdk_28", "28"},
|
|
{"android_arm64_armv8-a_sdk_29", "29"},
|
|
{"android_arm64_armv8-a_sdk_30", "30"},
|
|
{"android_arm64_armv8-a_sdk_current", "10000"},
|
|
{"android_vendor.29_arm64_armv8-a", "29"},
|
|
}
|
|
for _, v := range variants {
|
|
cflags := ctx.ModuleForTests("crt_foo", v.variant).Rule("cc").Args["cFlags"]
|
|
expected := "-target aarch64-linux-android" + v.num + " "
|
|
android.AssertStringDoesContain(t, "cflag", cflags, expected)
|
|
}
|
|
}
|
|
|
|
func TestUseCrtObjectOfCorrectVersion(t *testing.T) {
|
|
ctx := testCc(t, `
|
|
cc_binary {
|
|
name: "bin",
|
|
srcs: ["foo.c"],
|
|
stl: "none",
|
|
min_sdk_version: "29",
|
|
sdk_version: "current",
|
|
}
|
|
`)
|
|
|
|
// Sdk variant uses the crt object of the matching min_sdk_version
|
|
variant := "android_arm64_armv8-a_sdk"
|
|
crt := ctx.ModuleForTests("bin", variant).Rule("ld").Args["crtBegin"]
|
|
android.AssertStringDoesContain(t, "crt dep of sdk variant", crt,
|
|
variant+"_29/crtbegin_dynamic.o")
|
|
|
|
// platform variant uses the crt object built for platform
|
|
variant = "android_arm64_armv8-a"
|
|
crt = ctx.ModuleForTests("bin", variant).Rule("ld").Args["crtBegin"]
|
|
android.AssertStringDoesContain(t, "crt dep of platform variant", crt,
|
|
variant+"/crtbegin_dynamic.o")
|
|
}
|
|
|
|
func TestLinkerScript(t *testing.T) {
|
|
t.Run("script", func(t *testing.T) {
|
|
testCc(t, `
|
|
cc_object {
|
|
name: "foo",
|
|
srcs: ["baz.o"],
|
|
linker_script: "foo.lds",
|
|
}`)
|
|
})
|
|
}
|
|
|
|
func TestCcObjectWithBazel(t *testing.T) {
|
|
bp := `
|
|
cc_object {
|
|
name: "foo",
|
|
srcs: ["baz.o"],
|
|
bazel_module: { label: "//foo/bar:bar" },
|
|
}`
|
|
config := TestConfig(t.TempDir(), android.Android, nil, bp, nil)
|
|
config.BazelContext = android.MockBazelContext{
|
|
OutputBaseDir: "outputbase",
|
|
LabelToOutputFiles: map[string][]string{
|
|
"//foo/bar:bar": []string{"bazel_out.o"}}}
|
|
ctx := testCcWithConfig(t, config)
|
|
|
|
module := ctx.ModuleForTests("foo", "android_arm_armv7-a-neon").Module()
|
|
outputFiles, err := module.(android.OutputFileProducer).OutputFiles("")
|
|
if err != nil {
|
|
t.Errorf("Unexpected error getting cc_object outputfiles %s", err)
|
|
}
|
|
|
|
expectedOutputFiles := []string{"outputbase/execroot/__main__/bazel_out.o"}
|
|
android.AssertDeepEquals(t, "output files", expectedOutputFiles, outputFiles.Strings())
|
|
}
|