No description
Find a file
Paul Duffin c02e834ad6 Revert "Support libraries (not just boot jars) that have hiddenapi"
This reverts commit e5b5657f87.

The reverted change was added in order to gather the information about
the hiddenapi that is needed for the runtime to enforce the hiddenapi
accessibility rules. Without it the build broke with the following
error when the android.test.base library was not in the
PRODUCT_BOOT_JARS list:

AssertionError: Error processing: frameworks/base/config/hiddenapi-greylist.txt
The following entries were unexpected:
  Ljunit/framework/TestSuite;->isPublicTestMethod(Ljava/lang/reflect/Method;)Z
  Landroid/test/AndroidTestCase;->setTestContext(Landroid/content/Context;)V
  Landroid/test/InstrumentationTestCase;->runMethod(Ljava/lang/reflect/Method;I)V
  Landroid/test/AndroidTestCase;->getTestContext()Landroid/content/Context;
  Ljunit/framework/TestCase;->fName:Ljava/lang/String;
  Ljunit/framework/TestSuite;->isTestMethod(Ljava/lang/reflect/Method;)Z
  Please visit go/hiddenapi for more information.

However, it turns out that the runtime does not currently enforce
access to the hiddenapi of libraries that are not on the
PRODUCT_BOOT_JARS list. Gathering hiddenapi information for a library
not on the PRODUCT_BOOT_JARS list breaks the
CtsHiddenApiBlacklistApi27TestCases and
CtsHiddenApiBlacklistApi28TestCases test modules which use that
information to ensure that correct runtime behavior.

This change is being reverted simply because it does not work.

Bug: 126519737
Bug: 73711752
Test: make REMOVE_ATB_FROM_BCP=true droid and make droid
Change-Id: I1b4a7786b1061effa0e2d37832afa8570953a06e
2019-02-27 12:49:21 +00:00
android Merge "Split up Soong build doc." 2019-02-22 15:42:49 +00:00
androidmk Handle $(LOCAL_PATH) in androidmk 2019-02-25 15:19:06 -08:00
apex Include symlinks in flattened apexs 2019-02-25 10:14:55 -08:00
bpf Add common BPF helper to include path 2019-02-12 13:04:01 -05:00
bpfix Handle LOCAL_MODULE_PATH assignment for android_test modules 2019-02-22 15:10:08 -08:00
cc Fix: sysprop module can't be used with whole_static_libs 2019-02-26 10:26:44 +09:00
cmd soong_docs build link error fix. 2019-02-25 10:26:46 -08:00
dexpreopt Support for install multiple boot images. 2019-02-22 15:37:48 +00:00
docs Add support for generating Compdb file 2018-04-24 08:15:02 -07:00
env Support dependencies on environment variables 2015-03-26 14:13:49 -07:00
finder Fix go vet issues 2018-07-22 21:18:45 -07:00
genrule Remove empty DepsMutator methods 2019-02-01 17:17:58 -08:00
jar soong_zip: Add tests 2018-09-28 13:56:06 -07:00
java Revert "Support libraries (not just boot jars) that have hiddenapi" 2019-02-27 12:49:21 +00:00
phony Remove empty DepsMutator methods 2019-02-01 17:17:58 -08:00
python [SOONG] Not auto-generate test config if test_suite is cts 2019-02-19 22:25:50 +08:00
scripts Make manifest and APK agree on uncompressed native libs 2019-02-08 15:24:47 +00:00
shared Have Soong try to enforce that genrules declare all their outputs. 2017-06-09 17:57:18 +00:00
symbol_inject Add support to inject a uint64 symbol 2018-10-22 15:46:03 -07:00
sysprop Add recovery_available property to sysprop module 2019-02-26 10:27:13 +09:00
third_party/zip Strip extended-timestap extra block in zip2zip. 2017-09-19 21:01:18 -07:00
tradefed [SOONG] Not auto-generate test config if test_suite is cts 2019-02-19 22:25:50 +08:00
ui Use python / python2.7 prebuilts 2019-02-18 19:34:00 +00:00
xml Add prebuilt_etc_xml 2018-04-28 00:13:00 +09:00
zip Fix soong_zip printing warnings with --ignore_missing_files 2018-12-27 12:41:25 -08:00
Android.bp Refactor dexpreopt_bootjars.go to prepare for multiple boot images 2019-02-20 22:06:29 -08:00
bootstrap.bash Add license headers to all go and shell files 2017-11-17 23:05:26 +00:00
build_test.bash Unset BUILD_NUMBER in build_test.bash 2018-10-15 22:36:16 -07:00
doc.go Add soong_build primary builder 2015-03-13 20:28:16 -07:00
go.mod Add go.mod file for go1.11 2018-07-22 21:01:44 -07:00
navbar.md Add performance and best practices documentation 2018-02-07 10:13:36 -08:00
OWNERS Expand Jiyong's apex OWNERship 2019-01-31 18:57:00 +00:00
PREUPLOAD.cfg Fix gofmt problems and add gofmt to preupload checks 2016-10-20 18:48:20 -07:00
README.md Docs: update path to soong_build.html 2019-02-08 16:41:40 -08:00
root.bp Replace root.bp with a comment 2017-11-17 23:05:41 +00:00
soong.bash Add license headers to all go and shell files 2017-11-17 23:05:26 +00:00
soong.bootstrap.in Use SRCDIR as a working directory 2015-09-17 23:42:25 -07:00
soong_ui.bash Fix: soong_ui.bash's wrong check for TOP variable 2018-12-28 14:43:52 +09:00

Soong

Soong is the replacement for the old Android make-based build system. It replaces Android.mk files with Android.bp files, which are JSON-like simple declarative descriptions of modules to build.

See Simple Build Configuration on source.android.com to read how Soong is configured for testing.

Android.bp file format

By design, Android.bp files are very simple. There are no conditionals or control flow statements - any complexity is handled in build logic written in Go. The syntax and semantics of Android.bp files are intentionally similar to Bazel BUILD files when possible.

Modules

A module in an Android.bp file starts with a module type, followed by a set of properties in name: value, format:

cc_binary {
    name: "gzip",
    srcs: ["src/test/minigzip.c"],
    shared_libs: ["libz"],
    stl: "none",
}

Every module must have a name property, and the value must be unique across all Android.bp files.

For a list of valid module types and their properties see $OUT_DIR/soong/docs/soong_build.html.

Globs

Properties that take a list of files can also take glob patterns. Glob patterns can contain the normal Unix wildcard *, for example "*.java". Glob patterns can also contain a single ** wildcard as a path element, which will match zero or more path elements. For example, java/**/*.java will match java/Main.java and java/com/android/Main.java.

Variables

An Android.bp file may contain top-level variable assignments:

gzip_srcs = ["src/test/minigzip.c"],

cc_binary {
    name: "gzip",
    srcs: gzip_srcs,
    shared_libs: ["libz"],
    stl: "none",
}

Variables are scoped to the remainder of the file they are declared in, as well as any child blueprint files. Variables are immutable with one exception - they can be appended to with a += assignment, but only before they have been referenced.

Comments

Android.bp files can contain C-style multiline /* */ and C++ style single-line // comments.

Types

Variables and properties are strongly typed, variables dynamically based on the first assignment, and properties statically by the module type. The supported types are:

  • Bool (true or false)
  • Integers (int)
  • Strings ("string")
  • Lists of strings (["string1", "string2"])
  • Maps ({key1: "value1", key2: ["value2"]})

Maps may values of any type, including nested maps. Lists and maps may have trailing commas after the last value.

Operators

Strings, lists of strings, and maps can be appended using the + operator. Integers can be summed up using the + operator. Appending a map produces the union of keys in both maps, appending the values of any keys that are present in both maps.

Defaults modules

A defaults module can be used to repeat the same properties in multiple modules. For example:

cc_defaults {
    name: "gzip_defaults",
    shared_libs: ["libz"],
    stl: "none",
}

cc_binary {
    name: "gzip",
    defaults: ["gzip_defaults"],
    srcs: ["src/test/minigzip.c"],
}

Name resolution

Soong provides the ability for modules in different directories to specify the same name, as long as each module is declared within a separate namespace. A namespace can be declared like this:

soong_namespace {
    imports: ["path/to/otherNamespace1", "path/to/otherNamespace2"],
}

Each Soong module is assigned a namespace based on its location in the tree. Each Soong module is considered to be in the namespace defined by the soong_namespace found in an Android.bp in the current directory or closest ancestor directory, unless no such soong_namespace module is found, in which case the module is considered to be in the implicit root namespace.

When Soong attempts to resolve dependency D declared my module M in namespace N which imports namespaces I1, I2, I3..., then if D is a fully-qualified name of the form "//namespace:module", only the specified namespace will be searched for the specified module name. Otherwise, Soong will first look for a module named D declared in namespace N. If that module does not exist, Soong will look for a module named D in namespaces I1, I2, I3... Lastly, Soong will look in the root namespace.

Until we have fully converted from Make to Soong, it will be necessary for the Make product config to specify a value of PRODUCT_SOONG_NAMESPACES. Its value should be a space-separated list of namespaces that Soong export to Make to be built by the m command. After we have fully converted from Make to Soong, the details of enabling namespaces could potentially change.

Formatter

Soong includes a canonical formatter for blueprint files, similar to gofmt. To recursively reformat all Android.bp files in the current directory:

bpfmt -w .

The canonical format includes 4 space indents, newlines after every element of a multi-element list, and always includes a trailing comma in lists and maps.

Convert Android.mk files

Soong includes a tool perform a first pass at converting Android.mk files to Android.bp files:

androidmk Android.mk > Android.bp

The tool converts variables, modules, comments, and some conditionals, but any custom Makefile rules, complex conditionals or extra includes must be converted by hand.

Differences between Android.mk and Android.bp

  • Android.mk files often have multiple modules with the same name (for example for static and shared version of a library, or for host and device versions). Android.bp files require unique names for every module, but a single module can be built in multiple variants, for example by adding host_supported: true. The androidmk converter will produce multiple conflicting modules, which must be resolved by hand to a single module with any differences inside target: { android: { }, host: { } } blocks.

Build logic

The build logic is written in Go using the blueprint framework. Build logic receives module definitions parsed into Go structures using reflection and produces build rules. The build rules are collected by blueprint and written to a ninja build file.

Other documentation

FAQ

How do I write conditionals?

Soong deliberately does not support conditionals in Android.bp files. Instead, complexity in build rules that would require conditionals are handled in Go, where high level language features can be used and implicit dependencies introduced by conditionals can be tracked. Most conditionals are converted to a map property, where one of the values in the map will be selected and appended to the top level properties.

For example, to support architecture specific files:

cc_library {
    ...
    srcs: ["generic.cpp"],
    arch: {
        arm: {
            srcs: ["arm.cpp"],
        },
        x86: {
            srcs: ["x86.cpp"],
        },
    },
}

See art/build/art.go or external/llvm/soong/llvm.go for examples of more complex conditionals on product variables or environment variables.

Developing for Soong

To load Soong code in a Go-aware IDE, create a directory outside your android tree and then:

apt install bindfs
export GOPATH=<path to the directory you created>
build/soong/scripts/setup_go_workspace_for_soong.sh

This will bind mount the Soong source directories into the directory in the layout expected by the IDE.

Contact

Email android-building@googlegroups.com (external) for any questions, or see go/soong (internal).