a03cf6d322
For every file which we can run clang-tidy (C/C++ clang-built), we add a new build node that depends on the object file (since clang-tidy does not export a depfile), and is depended on by the link step. This is better than how we're doing it in make, since calling tidy can be turned on or off without needing to rebuild the object files. This does not attempt to port WITH_TIDY_ONLY from Make, since the way that it works is broken (due to the lack of a depfile). Bug: 32244182 Test: WITH_TIDY=true mmma -j bionic/libc Test: ./soong (Setting ClangTidy: true) Change-Id: I40bbb5bb00d292d72bf1c293b93080b5f9f6d8ea
272 lines
9 KiB
Go
272 lines
9 KiB
Go
// Copyright 2016 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package cc
|
|
|
|
import (
|
|
"fmt"
|
|
"path/filepath"
|
|
"sort"
|
|
"strings"
|
|
|
|
"android/soong/android"
|
|
"android/soong/cc/config"
|
|
)
|
|
|
|
func init() {
|
|
android.RegisterMakeVarsProvider(pctx, makeVarsProvider)
|
|
}
|
|
|
|
func makeVarsProvider(ctx android.MakeVarsContext) {
|
|
ctx.Strict("LLVM_PREBUILTS_VERSION", "${config.ClangVersion}")
|
|
ctx.Strict("LLVM_PREBUILTS_BASE", "${config.ClangBase}")
|
|
ctx.Strict("LLVM_PREBUILTS_PATH", "${config.ClangBin}")
|
|
ctx.Strict("CLANG", "${config.ClangBin}/clang")
|
|
ctx.Strict("CLANG_CXX", "${config.ClangBin}/clang++")
|
|
ctx.Strict("LLVM_AS", "${config.ClangBin}/llvm-as")
|
|
ctx.Strict("LLVM_LINK", "${config.ClangBin}/llvm-link")
|
|
ctx.Strict("PATH_TO_CLANG_TIDY", "${config.ClangBin}/clang-tidy")
|
|
ctx.StrictSorted("CLANG_CONFIG_UNKNOWN_CFLAGS", strings.Join(config.ClangUnknownCflags, " "))
|
|
|
|
ctx.Strict("GLOBAL_CFLAGS_NO_OVERRIDE", "${config.NoOverrideGlobalCflags}")
|
|
ctx.Strict("GLOBAL_CLANG_CFLAGS_NO_OVERRIDE", "${config.ClangExtraNoOverrideCflags}")
|
|
ctx.Strict("GLOBAL_CPPFLAGS_NO_OVERRIDE", "")
|
|
ctx.Strict("GLOBAL_CLANG_CPPFLAGS_NO_OVERRIDE", "")
|
|
ctx.Strict("NDK_PREBUILT_SHARED_LIBRARIES", strings.Join(ndkPrebuiltSharedLibs, " "))
|
|
|
|
ctx.Strict("ADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS", asanCflags)
|
|
ctx.Strict("ADDRESS_SANITIZER_CONFIG_EXTRA_LDFLAGS", asanLdflags)
|
|
ctx.Strict("ADDRESS_SANITIZER_CONFIG_EXTRA_STATIC_LIBRARIES", asanLibs)
|
|
|
|
ctx.Strict("DEFAULT_C_STD_VERSION", config.CStdVersion)
|
|
ctx.Strict("DEFAULT_CPP_STD_VERSION", config.CppStdVersion)
|
|
ctx.Strict("DEFAULT_GCC_CPP_STD_VERSION", config.GccCppStdVersion)
|
|
|
|
ctx.Strict("DEFAULT_GLOBAL_TIDY_CHECKS", "${config.TidyDefaultGlobalChecks}")
|
|
ctx.Strict("DEFAULT_LOCAL_TIDY_CHECKS", joinLocalTidyChecks(config.DefaultLocalTidyChecks))
|
|
ctx.Strict("DEFAULT_TIDY_HEADER_DIRS", "${config.TidyDefaultHeaderDirs}")
|
|
|
|
includeFlags, err := ctx.Eval("${config.CommonGlobalIncludes} ${config.CommonGlobalSystemIncludes}")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
includes, systemIncludes := splitSystemIncludes(ctx, includeFlags)
|
|
ctx.StrictRaw("SRC_HEADERS", strings.Join(includes, " "))
|
|
ctx.StrictRaw("SRC_SYSTEM_HEADERS", strings.Join(systemIncludes, " "))
|
|
|
|
sort.Strings(ndkMigratedLibs)
|
|
ctx.Strict("NDK_MIGRATED_LIBS", strings.Join(ndkMigratedLibs, " "))
|
|
|
|
hostTargets := ctx.Config().Targets[android.Host]
|
|
makeVarsToolchain(ctx, "", hostTargets[0])
|
|
if len(hostTargets) > 1 {
|
|
makeVarsToolchain(ctx, "2ND_", hostTargets[1])
|
|
}
|
|
|
|
crossTargets := ctx.Config().Targets[android.HostCross]
|
|
if len(crossTargets) > 0 {
|
|
makeVarsToolchain(ctx, "", crossTargets[0])
|
|
if len(crossTargets) > 1 {
|
|
makeVarsToolchain(ctx, "2ND_", crossTargets[1])
|
|
}
|
|
}
|
|
|
|
deviceTargets := ctx.Config().Targets[android.Device]
|
|
makeVarsToolchain(ctx, "", deviceTargets[0])
|
|
if len(deviceTargets) > 1 {
|
|
makeVarsToolchain(ctx, "2ND_", deviceTargets[1])
|
|
}
|
|
}
|
|
|
|
func makeVarsToolchain(ctx android.MakeVarsContext, secondPrefix string,
|
|
target android.Target) {
|
|
var typePrefix string
|
|
switch target.Os.Class {
|
|
case android.Host:
|
|
typePrefix = "HOST_"
|
|
case android.HostCross:
|
|
typePrefix = "HOST_CROSS_"
|
|
case android.Device:
|
|
typePrefix = "TARGET_"
|
|
}
|
|
makePrefix := secondPrefix + typePrefix
|
|
|
|
toolchain := config.FindToolchain(target.Os, target.Arch)
|
|
|
|
var productExtraCflags string
|
|
var productExtraLdflags string
|
|
|
|
hod := "Host"
|
|
if target.Os.Class == android.Device {
|
|
hod = "Device"
|
|
}
|
|
|
|
if target.Os.Class == android.Device && Bool(ctx.Config().ProductVariables.Brillo) {
|
|
productExtraCflags += "-D__BRILLO__"
|
|
}
|
|
if target.Os.Class == android.Host && Bool(ctx.Config().ProductVariables.HostStaticBinaries) {
|
|
productExtraLdflags += "-static"
|
|
}
|
|
|
|
ctx.Strict(makePrefix+"GLOBAL_CFLAGS", strings.Join([]string{
|
|
toolchain.Cflags(),
|
|
"${config.CommonGlobalCflags}",
|
|
fmt.Sprintf("${config.%sGlobalCflags}", hod),
|
|
toolchain.ToolchainCflags(),
|
|
productExtraCflags,
|
|
}, " "))
|
|
ctx.Strict(makePrefix+"GLOBAL_CONLYFLAGS", strings.Join([]string{
|
|
"${config.CommonGlobalConlyflags}",
|
|
}, " "))
|
|
ctx.Strict(makePrefix+"GLOBAL_CPPFLAGS", strings.Join([]string{
|
|
"${config.CommonGlobalCppflags}",
|
|
toolchain.Cppflags(),
|
|
}, " "))
|
|
ctx.Strict(makePrefix+"GLOBAL_LDFLAGS", strings.Join([]string{
|
|
toolchain.Ldflags(),
|
|
toolchain.ToolchainLdflags(),
|
|
productExtraLdflags,
|
|
}, " "))
|
|
|
|
includeFlags, err := ctx.Eval(toolchain.IncludeFlags())
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
includes, systemIncludes := splitSystemIncludes(ctx, includeFlags)
|
|
ctx.StrictRaw(makePrefix+"C_INCLUDES", strings.Join(includes, " "))
|
|
ctx.StrictRaw(makePrefix+"C_SYSTEM_INCLUDES", strings.Join(systemIncludes, " "))
|
|
|
|
if target.Arch.ArchType == android.Arm {
|
|
flags, err := toolchain.InstructionSetFlags("arm")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
ctx.Strict(makePrefix+"arm_CFLAGS", flags)
|
|
|
|
flags, err = toolchain.InstructionSetFlags("thumb")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
ctx.Strict(makePrefix+"thumb_CFLAGS", flags)
|
|
}
|
|
|
|
if toolchain.ClangSupported() {
|
|
clangPrefix := secondPrefix + "CLANG_" + typePrefix
|
|
clangExtras := "-target " + toolchain.ClangTriple()
|
|
if target.Os != android.Darwin {
|
|
clangExtras += " -B" + filepath.Join(toolchain.GccRoot(), toolchain.GccTriple(), "bin")
|
|
}
|
|
|
|
ctx.Strict(clangPrefix+"GLOBAL_CFLAGS", strings.Join([]string{
|
|
toolchain.ClangCflags(),
|
|
"${config.CommonClangGlobalCflags}",
|
|
fmt.Sprintf("${config.%sClangGlobalCflags}", hod),
|
|
toolchain.ToolchainClangCflags(),
|
|
clangExtras,
|
|
productExtraCflags,
|
|
}, " "))
|
|
ctx.Strict(clangPrefix+"GLOBAL_CPPFLAGS", strings.Join([]string{
|
|
"${config.CommonClangGlobalCppflags}",
|
|
toolchain.ClangCppflags(),
|
|
}, " "))
|
|
ctx.Strict(clangPrefix+"GLOBAL_LDFLAGS", strings.Join([]string{
|
|
toolchain.ClangLdflags(),
|
|
toolchain.ToolchainClangLdflags(),
|
|
productExtraLdflags,
|
|
clangExtras,
|
|
}, " "))
|
|
|
|
if target.Os.Class == android.Device {
|
|
ctx.Strict(secondPrefix+"ADDRESS_SANITIZER_RUNTIME_LIBRARY", strings.TrimSuffix(config.AddressSanitizerRuntimeLibrary(toolchain), ".so"))
|
|
ctx.Strict(secondPrefix+"UBSAN_RUNTIME_LIBRARY", strings.TrimSuffix(config.UndefinedBehaviorSanitizerRuntimeLibrary(toolchain), ".so"))
|
|
}
|
|
|
|
// This is used by external/gentoo/...
|
|
ctx.Strict("CLANG_CONFIG_"+target.Arch.ArchType.Name+"_"+typePrefix+"TRIPLE",
|
|
toolchain.ClangTriple())
|
|
}
|
|
|
|
ctx.Strict(makePrefix+"CC", gccCmd(toolchain, "gcc"))
|
|
ctx.Strict(makePrefix+"CXX", gccCmd(toolchain, "g++"))
|
|
|
|
if target.Os == android.Darwin {
|
|
ctx.Strict(makePrefix+"AR", "${config.MacArPath}")
|
|
} else {
|
|
ctx.Strict(makePrefix+"AR", gccCmd(toolchain, "ar"))
|
|
ctx.Strict(makePrefix+"READELF", gccCmd(toolchain, "readelf"))
|
|
ctx.Strict(makePrefix+"NM", gccCmd(toolchain, "nm"))
|
|
}
|
|
|
|
if target.Os == android.Windows {
|
|
ctx.Strict(makePrefix+"OBJDUMP", gccCmd(toolchain, "objdump"))
|
|
}
|
|
|
|
if target.Os.Class == android.Device {
|
|
ctx.Strict(makePrefix+"OBJCOPY", gccCmd(toolchain, "objcopy"))
|
|
ctx.Strict(makePrefix+"LD", gccCmd(toolchain, "ld"))
|
|
ctx.Strict(makePrefix+"STRIP", gccCmd(toolchain, "strip"))
|
|
ctx.Strict(makePrefix+"GCC_VERSION", toolchain.GccVersion())
|
|
ctx.Strict(makePrefix+"NDK_GCC_VERSION", toolchain.GccVersion())
|
|
ctx.Strict(makePrefix+"NDK_TRIPLE", toolchain.ClangTriple())
|
|
}
|
|
|
|
ctx.Strict(makePrefix+"TOOLCHAIN_ROOT", toolchain.GccRoot())
|
|
ctx.Strict(makePrefix+"TOOLS_PREFIX", gccCmd(toolchain, ""))
|
|
ctx.Strict(makePrefix+"SHLIB_SUFFIX", toolchain.ShlibSuffix())
|
|
ctx.Strict(makePrefix+"EXECUTABLE_SUFFIX", toolchain.ExecutableSuffix())
|
|
}
|
|
|
|
func splitSystemIncludes(ctx android.MakeVarsContext, val string) (includes, systemIncludes []string) {
|
|
flags, err := ctx.Eval(val)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
extract := func(flags string, dirs []string, prefix string) (string, []string, bool) {
|
|
if strings.HasPrefix(flags, prefix) {
|
|
flags = strings.TrimPrefix(flags, prefix)
|
|
flags = strings.TrimLeft(flags, " ")
|
|
s := strings.SplitN(flags, " ", 2)
|
|
dirs = append(dirs, s[0])
|
|
if len(s) > 1 {
|
|
return strings.TrimLeft(s[1], " "), dirs, true
|
|
}
|
|
return "", dirs, true
|
|
} else {
|
|
return flags, dirs, false
|
|
}
|
|
}
|
|
|
|
flags = strings.TrimLeft(flags, " ")
|
|
for flags != "" {
|
|
found := false
|
|
flags, includes, found = extract(flags, includes, "-I")
|
|
if !found {
|
|
flags, systemIncludes, found = extract(flags, systemIncludes, "-isystem ")
|
|
}
|
|
if !found {
|
|
panic(fmt.Errorf("Unexpected flag in %q", flags))
|
|
}
|
|
}
|
|
|
|
return includes, systemIncludes
|
|
}
|
|
|
|
func joinLocalTidyChecks(checks []config.PathBasedTidyCheck) string {
|
|
rets := make([]string, len(checks))
|
|
for i, check := range config.DefaultLocalTidyChecks {
|
|
rets[i] = check.PathPrefix + ":" + check.Checks
|
|
}
|
|
return strings.Join(rets, " ")
|
|
}
|