0a468a4f3b
Whenever any two Rust static libraries are included as static libraries anywhere in a CC dependency tree, we sometimes get duplicate symbol errors. To avoid this, we no longer directly link multiple rust static libs to CC modules. Instead, we build rust_ffi_rlib modules and produce the actual static library that gets linked against the CC module based on that CC module's full list of Rust rlib dependencies. This introduces a new static_rlibs property for cc modules to define the rust_ffi_rlib dependencies, which are then used to generate the module above. This CL is intended to deprecate rust_ffi_static. It leaves rust_ffi_static and rust_ffi static variants in place until the remaining rust_ffi_static declarations and uses can be removed. In the meantime, rust_ffi_static produces rust_ffi_rlib variants as well to make the transition easier. Bug: 254469782 Test: m # with no changes Test: m libapexsupport # with static_rlibs Test: m libunwindstack # with static_rlibs Test: m netsimd # with static_rlibs, no duplicate symbols Test: m blueprint_tests # New Soong tests Change-Id: I47e27ac967ef0cad46d398ebf59d8275929ae28a
96 lines
3.4 KiB
Go
96 lines
3.4 KiB
Go
// Copyright 2020 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rust
|
|
|
|
import (
|
|
"github.com/google/blueprint"
|
|
|
|
"android/soong/cc"
|
|
)
|
|
|
|
var CovLibraryName = "libprofile-clang-extras"
|
|
var ProfilerBuiltins = "libprofiler_builtins.rust_sysroot"
|
|
|
|
// Add '%c' to default specifier after we resolve http://b/210012154
|
|
const profileInstrFlag = "-fprofile-instr-generate=/data/misc/trace/clang-%p-%m.profraw"
|
|
|
|
type coverage struct {
|
|
Properties cc.CoverageProperties
|
|
|
|
// Whether binaries containing this module need --coverage added to their ldflags
|
|
linkCoverage bool
|
|
}
|
|
|
|
func (cov *coverage) props() []interface{} {
|
|
return []interface{}{&cov.Properties}
|
|
}
|
|
|
|
func (cov *coverage) deps(ctx DepsContext, deps Deps) Deps {
|
|
if cov.Properties.NeedCoverageVariant {
|
|
if ctx.Device() {
|
|
ctx.AddVariationDependencies([]blueprint.Variation{
|
|
{Mutator: "link", Variation: "static"},
|
|
}, cc.CoverageDepTag, CovLibraryName)
|
|
}
|
|
|
|
// no_std modules are missing libprofiler_builtins which provides coverage, so we need to add it as a dependency.
|
|
if rustModule, ok := ctx.Module().(*Module); ok && rustModule.compiler.noStdlibs() {
|
|
ctx.AddVariationDependencies([]blueprint.Variation{{Mutator: "rust_libraries", Variation: "rlib"}, {Mutator: "link", Variation: ""}}, rlibDepTag, ProfilerBuiltins)
|
|
}
|
|
}
|
|
|
|
return deps
|
|
}
|
|
|
|
func (cov *coverage) flags(ctx ModuleContext, flags Flags, deps PathDeps) (Flags, PathDeps) {
|
|
|
|
if !ctx.DeviceConfig().NativeCoverageEnabled() {
|
|
return flags, deps
|
|
}
|
|
|
|
if cov.Properties.CoverageEnabled {
|
|
flags.Coverage = true
|
|
flags.RustFlags = append(flags.RustFlags,
|
|
"-C instrument-coverage", "-g")
|
|
if ctx.Device() {
|
|
coverage := ctx.GetDirectDepWithTag(CovLibraryName, cc.CoverageDepTag).(cc.LinkableInterface)
|
|
flags.LinkFlags = append(flags.LinkFlags,
|
|
profileInstrFlag, "-g", coverage.OutputFile().Path().String(), "-Wl,--wrap,open")
|
|
deps.StaticLibs = append(deps.StaticLibs, coverage.OutputFile().Path())
|
|
}
|
|
|
|
// no_std modules are missing libprofiler_builtins which provides coverage, so we need to add it as a dependency.
|
|
if rustModule, ok := ctx.Module().(*Module); ok && rustModule.compiler.noStdlibs() {
|
|
profiler_builtins := ctx.GetDirectDepWithTag(ProfilerBuiltins, rlibDepTag).(*Module)
|
|
deps.RLibs = append(deps.RLibs, RustLibrary{Path: profiler_builtins.OutputFile().Path(), CrateName: profiler_builtins.CrateName()})
|
|
}
|
|
|
|
if cc.EnableContinuousCoverage(ctx) {
|
|
flags.RustFlags = append(flags.RustFlags, "-C llvm-args=--runtime-counter-relocation")
|
|
flags.LinkFlags = append(flags.LinkFlags, "-Wl,-mllvm,-runtime-counter-relocation")
|
|
}
|
|
}
|
|
|
|
return flags, deps
|
|
}
|
|
|
|
func (cov *coverage) begin(ctx BaseModuleContext) {
|
|
if ctx.Host() {
|
|
// Host coverage not yet supported.
|
|
} else {
|
|
// Update useSdk and sdkVersion args if Rust modules become SDK aware.
|
|
cov.Properties = cc.SetCoverageProperties(ctx, cov.Properties, ctx.RustModule().nativeCoverage(), false, "")
|
|
}
|
|
}
|