95fad7a56e
Always propagate LANG, LC_MESSAGES and PYTHONDONTWRITEBYTECODE to RBE to get more consistent behavior between local actions and RBE. Bug: 182415460 Bug: 190593001 Test: treehugger Change-Id: I726e6f02fd3ef77e158baf6fde77ffb7247a1375
99 lines
3.8 KiB
Go
99 lines
3.8 KiB
Go
// Copyright 2020 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package remoteexec
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
)
|
|
|
|
func TestTemplate(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
params *REParams
|
|
want string
|
|
}{
|
|
{
|
|
name: "basic",
|
|
params: &REParams{
|
|
Labels: map[string]string{"type": "compile", "lang": "cpp", "compiler": "clang"},
|
|
Inputs: []string{"$in"},
|
|
OutputFiles: []string{"$out"},
|
|
Platform: map[string]string{
|
|
ContainerImageKey: DefaultImage,
|
|
PoolKey: "default",
|
|
},
|
|
},
|
|
want: fmt.Sprintf("${android.RBEWrapper} --labels=compiler=clang,lang=cpp,type=compile --platform=\"Pool=default,container-image=%s\" --exec_strategy=local --inputs=$in --output_files=$out --env_var_allowlist=LANG,LC_MESSAGES,PYTHONDONTWRITEBYTECODE -- ", DefaultImage),
|
|
},
|
|
{
|
|
name: "all params",
|
|
params: &REParams{
|
|
Labels: map[string]string{"type": "compile", "lang": "cpp", "compiler": "clang"},
|
|
Inputs: []string{"$in"},
|
|
OutputFiles: []string{"$out"},
|
|
ExecStrategy: "remote",
|
|
RSPFiles: []string{"$out.rsp", "out2.rsp"},
|
|
ToolchainInputs: []string{"clang++"},
|
|
Platform: map[string]string{
|
|
ContainerImageKey: DefaultImage,
|
|
PoolKey: "default",
|
|
},
|
|
},
|
|
want: fmt.Sprintf("${android.RBEWrapper} --labels=compiler=clang,lang=cpp,type=compile --platform=\"Pool=default,container-image=%s\" --exec_strategy=remote --inputs=$in --input_list_paths=$out.rsp,out2.rsp --output_files=$out --toolchain_inputs=clang++ --env_var_allowlist=LANG,LC_MESSAGES,PYTHONDONTWRITEBYTECODE -- ", DefaultImage),
|
|
},
|
|
}
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
if got := test.params.Template(); got != test.want {
|
|
t.Errorf("Template() returned\n%s\nwant\n%s", got, test.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNoVarTemplate(t *testing.T) {
|
|
params := &REParams{
|
|
Labels: map[string]string{"type": "compile", "lang": "cpp", "compiler": "clang"},
|
|
Inputs: []string{"$in"},
|
|
OutputFiles: []string{"$out"},
|
|
Platform: map[string]string{
|
|
ContainerImageKey: DefaultImage,
|
|
PoolKey: "default",
|
|
},
|
|
}
|
|
want := fmt.Sprintf("prebuilts/remoteexecution-client/live/rewrapper --labels=compiler=clang,lang=cpp,type=compile --platform=\"Pool=default,container-image=%s\" --exec_strategy=local --inputs=$in --output_files=$out --env_var_allowlist=LANG,LC_MESSAGES,PYTHONDONTWRITEBYTECODE -- ", DefaultImage)
|
|
if got := params.NoVarTemplate(DefaultWrapperPath); got != want {
|
|
t.Errorf("NoVarTemplate() returned\n%s\nwant\n%s", got, want)
|
|
}
|
|
}
|
|
|
|
func TestTemplateDeterminism(t *testing.T) {
|
|
r := &REParams{
|
|
Labels: map[string]string{"type": "compile", "lang": "cpp", "compiler": "clang"},
|
|
Inputs: []string{"$in"},
|
|
OutputFiles: []string{"$out"},
|
|
Platform: map[string]string{
|
|
ContainerImageKey: DefaultImage,
|
|
PoolKey: "default",
|
|
},
|
|
}
|
|
want := fmt.Sprintf("${android.RBEWrapper} --labels=compiler=clang,lang=cpp,type=compile --platform=\"Pool=default,container-image=%s\" --exec_strategy=local --inputs=$in --output_files=$out --env_var_allowlist=LANG,LC_MESSAGES,PYTHONDONTWRITEBYTECODE -- ", DefaultImage)
|
|
for i := 0; i < 1000; i++ {
|
|
if got := r.Template(); got != want {
|
|
t.Fatalf("Template() returned\n%s\nwant\n%s", got, want)
|
|
}
|
|
}
|
|
}
|