593b3c9fb0
Exports visibility and package mutator registration functions so they can be used in sdk testing. Updates sdk test to support visibility and package modules. Adds EffectiveVisibility(...)[]string function to make the effective visibility rules available to sdk snapshot creation. Extracts compositeRule.Strings() []string from compositeRule.String() method so that it can be used by above func. Adds visibility property to sdk snapshot and prebuilt modules along with a test to ensure it works properly. Adds dir parameter to CheckSnapshot so that it can check the snapshot generated for a non-root package. That is required in order to ensure that visibility of :__subpackages__ on a source module in package <pkg> is resolved to an effective visibility of //<pkg>:__subpackages__ on its corresponding prebuilt. Test: m conscrypt-module-sdk Bug: 143678475 Change-Id: Icaacac5b9c04726d28e6fec93e49715ac45df7f4
103 lines
2.4 KiB
Go
103 lines
2.4 KiB
Go
package android
|
|
|
|
import (
|
|
"testing"
|
|
)
|
|
|
|
var packageTests = []struct {
|
|
name string
|
|
fs map[string][]byte
|
|
expectedErrors []string
|
|
}{
|
|
// Package default_visibility handling is tested in visibility_test.go
|
|
{
|
|
name: "package must not accept visibility and name properties",
|
|
fs: map[string][]byte{
|
|
"top/Blueprints": []byte(`
|
|
package {
|
|
name: "package",
|
|
visibility: ["//visibility:private"],
|
|
}`),
|
|
},
|
|
expectedErrors: []string{
|
|
`top/Blueprints:3:10: mutated field name cannot be set in a Blueprint file`,
|
|
`top/Blueprints:4:16: unrecognized property "visibility"`,
|
|
},
|
|
},
|
|
{
|
|
name: "multiple packages in separate directories",
|
|
fs: map[string][]byte{
|
|
"top/Blueprints": []byte(`
|
|
package {
|
|
}`),
|
|
"other/Blueprints": []byte(`
|
|
package {
|
|
}`),
|
|
"other/nested/Blueprints": []byte(`
|
|
package {
|
|
}`),
|
|
},
|
|
},
|
|
{
|
|
name: "package must not be specified more than once per package",
|
|
fs: map[string][]byte{
|
|
"top/Blueprints": []byte(`
|
|
package {
|
|
default_visibility: ["//visibility:private"],
|
|
}
|
|
|
|
package {
|
|
}`),
|
|
},
|
|
expectedErrors: []string{
|
|
`module "//top": package {...} specified multiple times`,
|
|
},
|
|
},
|
|
}
|
|
|
|
func TestPackage(t *testing.T) {
|
|
for _, test := range packageTests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
_, errs := testPackage(test.fs)
|
|
|
|
expectedErrors := test.expectedErrors
|
|
if expectedErrors == nil {
|
|
FailIfErrored(t, errs)
|
|
} else {
|
|
for _, expectedError := range expectedErrors {
|
|
FailIfNoMatchingErrors(t, expectedError, errs)
|
|
}
|
|
if len(errs) > len(expectedErrors) {
|
|
t.Errorf("additional errors found, expected %d, found %d", len(expectedErrors), len(errs))
|
|
for i, expectedError := range expectedErrors {
|
|
t.Errorf("expectedErrors[%d] = %s", i, expectedError)
|
|
}
|
|
for i, err := range errs {
|
|
t.Errorf("errs[%d] = %s", i, err)
|
|
}
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func testPackage(fs map[string][]byte) (*TestContext, []error) {
|
|
|
|
// Create a new config per test as visibility information is stored in the config.
|
|
config := TestArchConfig(buildDir, nil)
|
|
|
|
ctx := NewTestArchContext()
|
|
ctx.RegisterModuleType("package", PackageFactory)
|
|
ctx.PreArchMutators(RegisterPackageRenamer)
|
|
ctx.Register()
|
|
|
|
ctx.MockFileSystem(fs)
|
|
|
|
_, errs := ctx.ParseBlueprintsFiles(".")
|
|
if len(errs) > 0 {
|
|
return ctx, errs
|
|
}
|
|
|
|
_, errs = ctx.PrepareBuildActions(config)
|
|
return ctx, errs
|
|
}
|