362c1883d1
- Soong generates the rules to compare prebuilts/abi-dumps/vndk and the intermediate dumps tagged with LLNDK. - The LLNDK ABI diff report names contain ".llndk". Because LLNDK versioning has not been implemented, the reports are identical to those for NDK and PLATFORM. - optInAbiDiff does not take isLlndkOrNdk as a parameter, as it is false for all known use cases. Test: m libnativewindow Bug: 314010764 Change-Id: I17097505472b9d6ab97a605f3f8dca8ea53d22c8
255 lines
7.8 KiB
Go
255 lines
7.8 KiB
Go
// Copyright 2017 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package cc
|
|
|
|
import (
|
|
"sync"
|
|
|
|
"android/soong/android"
|
|
"android/soong/cc/config"
|
|
)
|
|
|
|
var (
|
|
lsdumpPaths []string
|
|
lsdumpPathsLock sync.Mutex
|
|
)
|
|
|
|
type lsdumpTag string
|
|
|
|
const (
|
|
llndkLsdumpTag lsdumpTag = "LLNDK"
|
|
ndkLsdumpTag lsdumpTag = "NDK"
|
|
platformLsdumpTag lsdumpTag = "PLATFORM"
|
|
productLsdumpTag lsdumpTag = "PRODUCT"
|
|
vendorLsdumpTag lsdumpTag = "VENDOR"
|
|
)
|
|
|
|
// Return the prebuilt ABI dump directory for a tag; an empty string for an opt-in dump.
|
|
func (tag *lsdumpTag) dirName() string {
|
|
switch *tag {
|
|
case ndkLsdumpTag:
|
|
return "ndk"
|
|
case llndkLsdumpTag:
|
|
return "vndk"
|
|
case platformLsdumpTag:
|
|
return "platform"
|
|
default:
|
|
return ""
|
|
}
|
|
}
|
|
|
|
// Properties for ABI compatibility checker in Android.bp.
|
|
type headerAbiCheckerProperties struct {
|
|
// Enable ABI checks (even if this is not an LLNDK/VNDK lib)
|
|
Enabled *bool
|
|
|
|
// Path to a symbol file that specifies the symbols to be included in the generated
|
|
// ABI dump file
|
|
Symbol_file *string `android:"path"`
|
|
|
|
// Symbol versions that should be ignored from the symbol file
|
|
Exclude_symbol_versions []string
|
|
|
|
// Symbol tags that should be ignored from the symbol file
|
|
Exclude_symbol_tags []string
|
|
|
|
// Run checks on all APIs (in addition to the ones referred by
|
|
// one of exported ELF symbols.)
|
|
Check_all_apis *bool
|
|
|
|
// Extra flags passed to header-abi-diff
|
|
Diff_flags []string
|
|
|
|
// Opt-in reference dump directories
|
|
Ref_dump_dirs []string
|
|
}
|
|
|
|
func (props *headerAbiCheckerProperties) enabled() bool {
|
|
return Bool(props.Enabled)
|
|
}
|
|
|
|
func (props *headerAbiCheckerProperties) explicitlyDisabled() bool {
|
|
return !BoolDefault(props.Enabled, true)
|
|
}
|
|
|
|
type SAbiProperties struct {
|
|
// Whether ABI dump should be created for this module.
|
|
// Set by `sabiDepsMutator` if this module is a shared library that needs ABI check, or a static
|
|
// library that is depended on by an ABI checked library.
|
|
ShouldCreateSourceAbiDump bool `blueprint:"mutated"`
|
|
|
|
// Include directories that may contain ABI information exported by a library.
|
|
// These directories are passed to the header-abi-dumper.
|
|
ReexportedIncludes []string `blueprint:"mutated"`
|
|
}
|
|
|
|
type sabi struct {
|
|
Properties SAbiProperties
|
|
}
|
|
|
|
func (sabi *sabi) props() []interface{} {
|
|
return []interface{}{&sabi.Properties}
|
|
}
|
|
|
|
func (sabi *sabi) flags(ctx ModuleContext, flags Flags) Flags {
|
|
// Filter out flags which libTooling don't understand.
|
|
// This is here for legacy reasons and future-proof, in case the version of libTooling and clang
|
|
// diverge.
|
|
flags.Local.ToolingCFlags = config.ClangLibToolingFilterUnknownCflags(flags.Local.CFlags)
|
|
flags.Global.ToolingCFlags = config.ClangLibToolingFilterUnknownCflags(flags.Global.CFlags)
|
|
flags.Local.ToolingCppFlags = config.ClangLibToolingFilterUnknownCflags(flags.Local.CppFlags)
|
|
flags.Global.ToolingCppFlags = config.ClangLibToolingFilterUnknownCflags(flags.Global.CppFlags)
|
|
return flags
|
|
}
|
|
|
|
// Returns true if ABI dump should be created for this library, either because library is ABI
|
|
// checked or is depended on by an ABI checked library.
|
|
// Could be called as a nil receiver.
|
|
func (sabi *sabi) shouldCreateSourceAbiDump() bool {
|
|
return sabi != nil && sabi.Properties.ShouldCreateSourceAbiDump
|
|
}
|
|
|
|
// Returns a slice of strings that represent the ABI dumps generated for this module.
|
|
func classifySourceAbiDump(ctx android.BaseModuleContext) []lsdumpTag {
|
|
result := []lsdumpTag{}
|
|
m := ctx.Module().(*Module)
|
|
headerAbiChecker := m.library.getHeaderAbiCheckerProperties(ctx)
|
|
if headerAbiChecker.explicitlyDisabled() {
|
|
return result
|
|
}
|
|
if !m.InProduct() && !m.InVendor() {
|
|
if m.isImplementationForLLNDKPublic() {
|
|
result = append(result, llndkLsdumpTag)
|
|
}
|
|
// Return NDK if the library is both NDK and APEX.
|
|
// TODO(b/309880485): Split NDK and APEX ABI.
|
|
if m.IsNdk(ctx.Config()) {
|
|
result = append(result, ndkLsdumpTag)
|
|
} else if m.library.hasStubsVariants() || headerAbiChecker.enabled() {
|
|
result = append(result, platformLsdumpTag)
|
|
}
|
|
} else if headerAbiChecker.enabled() {
|
|
if m.InProduct() {
|
|
result = append(result, productLsdumpTag)
|
|
}
|
|
if m.InVendor() {
|
|
result = append(result, vendorLsdumpTag)
|
|
}
|
|
}
|
|
return result
|
|
}
|
|
|
|
// Called from sabiDepsMutator to check whether ABI dumps should be created for this module.
|
|
// ctx should be wrapping a native library type module.
|
|
func shouldCreateSourceAbiDumpForLibrary(ctx android.BaseModuleContext) bool {
|
|
// Only generate ABI dump for device modules.
|
|
if !ctx.Device() {
|
|
return false
|
|
}
|
|
|
|
m := ctx.Module().(*Module)
|
|
|
|
// Only create ABI dump for native library module types.
|
|
if m.library == nil {
|
|
return false
|
|
}
|
|
|
|
// Create ABI dump for static libraries only if they are dependencies of ABI checked libraries.
|
|
if m.library.static() {
|
|
return m.sabi.shouldCreateSourceAbiDump()
|
|
}
|
|
|
|
// Module is shared library type.
|
|
|
|
// Don't check uninstallable modules.
|
|
if m.IsHideFromMake() {
|
|
return false
|
|
}
|
|
|
|
// Don't check ramdisk or recovery variants. Only check core, vendor or product variants.
|
|
if m.InRamdisk() || m.InVendorRamdisk() || m.InRecovery() {
|
|
return false
|
|
}
|
|
|
|
// Don't create ABI dump for prebuilts.
|
|
if m.Prebuilt() != nil || m.IsSnapshotPrebuilt() {
|
|
return false
|
|
}
|
|
|
|
// Coverage builds have extra symbols.
|
|
if m.isCoverageVariant() {
|
|
return false
|
|
}
|
|
|
|
// Some sanitizer variants may have different ABI.
|
|
if m.sanitize != nil && !m.sanitize.isVariantOnProductionDevice() {
|
|
return false
|
|
}
|
|
|
|
// Don't create ABI dump for stubs.
|
|
if m.isNDKStubLibrary() || m.IsLlndk() || m.IsStubs() {
|
|
return false
|
|
}
|
|
|
|
apexInfo, _ := android.ModuleProvider(ctx, android.ApexInfoProvider)
|
|
if apexInfo.IsForPlatform() {
|
|
// Bionic libraries that are installed to the bootstrap directory are not ABI checked.
|
|
// Only the runtime APEX variants, which are the implementation libraries of bionic NDK stubs,
|
|
// are checked.
|
|
if InstallToBootstrap(m.BaseModuleName(), ctx.Config()) {
|
|
return false
|
|
}
|
|
} else {
|
|
// Don't create ABI dump if this library is for APEX but isn't exported.
|
|
if !m.HasStubsVariants() {
|
|
return false
|
|
}
|
|
}
|
|
return len(classifySourceAbiDump(ctx)) > 0
|
|
}
|
|
|
|
// Mark the direct and transitive dependencies of libraries that need ABI check, so that ABI dumps
|
|
// of their dependencies would be generated.
|
|
func sabiDepsMutator(mctx android.TopDownMutatorContext) {
|
|
// Escape hatch to not check any ABI dump.
|
|
if mctx.Config().IsEnvTrue("SKIP_ABI_CHECKS") {
|
|
return
|
|
}
|
|
// Only create ABI dump for native shared libraries and their static library dependencies.
|
|
if m, ok := mctx.Module().(*Module); ok && m.sabi != nil {
|
|
if shouldCreateSourceAbiDumpForLibrary(mctx) {
|
|
// Mark this module so that .sdump / .lsdump for this library can be generated.
|
|
m.sabi.Properties.ShouldCreateSourceAbiDump = true
|
|
// Mark all of its static library dependencies.
|
|
mctx.VisitDirectDeps(func(child android.Module) {
|
|
depTag := mctx.OtherModuleDependencyTag(child)
|
|
if IsStaticDepTag(depTag) || depTag == reuseObjTag {
|
|
if c, ok := child.(*Module); ok && c.sabi != nil {
|
|
// Mark this module so that .sdump for this static library can be generated.
|
|
c.sabi.Properties.ShouldCreateSourceAbiDump = true
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
}
|
|
|
|
// Add an entry to the global list of lsdump. The list is exported to a Make variable by
|
|
// `cc.makeVarsProvider`.
|
|
func addLsdumpPath(lsdumpPath string) {
|
|
lsdumpPathsLock.Lock()
|
|
defer lsdumpPathsLock.Unlock()
|
|
lsdumpPaths = append(lsdumpPaths, lsdumpPath)
|
|
}
|