ee30d5e132
Bug: http://b/128524141 The goal is to add a static library (libprofile-extras) to modules that require coverage. Since the coverageMutator is a post-deps mutator, the results of the coverageMutator are not available when the dependencies get constructed in deps(). This change moves the detection from the coverageMutator to begin(). Test: m NATIVE_COVERAGE=true COVERAGE_PATHS=* Test: blueline_coverage target in internal branch (using forrest) Change-Id: I4e7c8b31ed5060642c6218ea33c532a0f6619967
161 lines
4.9 KiB
Go
161 lines
4.9 KiB
Go
// Copyright 2017 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package cc
|
|
|
|
import (
|
|
"strconv"
|
|
|
|
"android/soong/android"
|
|
)
|
|
|
|
type CoverageProperties struct {
|
|
Native_coverage *bool
|
|
|
|
NeedCoverageVariant bool `blueprint:"mutated"`
|
|
NeedCoverageBuild bool `blueprint:"mutated"`
|
|
|
|
CoverageEnabled bool `blueprint:"mutated"`
|
|
IsCoverageVariant bool `blueprint:"mutated"`
|
|
}
|
|
|
|
type coverage struct {
|
|
Properties CoverageProperties
|
|
|
|
// Whether binaries containing this module need --coverage added to their ldflags
|
|
linkCoverage bool
|
|
}
|
|
|
|
func (cov *coverage) props() []interface{} {
|
|
return []interface{}{&cov.Properties}
|
|
}
|
|
|
|
func (cov *coverage) deps(ctx BaseModuleContext, deps Deps) Deps {
|
|
return deps
|
|
}
|
|
|
|
func (cov *coverage) flags(ctx ModuleContext, flags Flags) Flags {
|
|
if !ctx.DeviceConfig().NativeCoverageEnabled() {
|
|
return flags
|
|
}
|
|
|
|
if cov.Properties.CoverageEnabled {
|
|
flags.Coverage = true
|
|
flags.GlobalFlags = append(flags.GlobalFlags, "--coverage", "-O0")
|
|
cov.linkCoverage = true
|
|
|
|
// Override -Wframe-larger-than and non-default optimization
|
|
// flags that the module may use.
|
|
flags.CFlags = append(flags.CFlags, "-Wno-frame-larger-than=", "-O0")
|
|
}
|
|
|
|
// Even if we don't have coverage enabled, if any of our object files were compiled
|
|
// with coverage, then we need to add --coverage to our ldflags.
|
|
if !cov.linkCoverage {
|
|
if ctx.static() && !ctx.staticBinary() {
|
|
// For static libraries, the only thing that changes our object files
|
|
// are included whole static libraries, so check to see if any of
|
|
// those have coverage enabled.
|
|
ctx.VisitDirectDepsWithTag(wholeStaticDepTag, func(m android.Module) {
|
|
if cc, ok := m.(*Module); ok && cc.coverage != nil {
|
|
if cc.coverage.linkCoverage {
|
|
cov.linkCoverage = true
|
|
}
|
|
}
|
|
})
|
|
} else {
|
|
// For executables and shared libraries, we need to check all of
|
|
// our static dependencies.
|
|
ctx.VisitDirectDeps(func(m android.Module) {
|
|
cc, ok := m.(*Module)
|
|
if !ok || cc.coverage == nil {
|
|
return
|
|
}
|
|
|
|
if static, ok := cc.linker.(libraryInterface); !ok || !static.static() {
|
|
return
|
|
}
|
|
|
|
if cc.coverage.linkCoverage {
|
|
cov.linkCoverage = true
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
if cov.linkCoverage {
|
|
flags.LdFlags = append(flags.LdFlags, "--coverage")
|
|
}
|
|
|
|
return flags
|
|
}
|
|
|
|
func (cov *coverage) begin(ctx BaseModuleContext) {
|
|
// Coverage is disabled globally
|
|
if !ctx.DeviceConfig().NativeCoverageEnabled() {
|
|
return
|
|
}
|
|
|
|
var needCoverageVariant bool
|
|
var needCoverageBuild bool
|
|
|
|
if ctx.Host() {
|
|
// TODO(dwillemsen): because of -nodefaultlibs, we must depend on libclang_rt.profile-*.a
|
|
// Just turn off for now.
|
|
} else if ctx.isStubs() {
|
|
// Do not enable coverage for platform stub libraries
|
|
} else if ctx.isNDKStubLibrary() {
|
|
// Do not enable coverage for NDK stub libraries
|
|
} else {
|
|
// Check if Native_coverage is set to false. This property defaults to true.
|
|
needCoverageVariant = BoolDefault(cov.Properties.Native_coverage, true)
|
|
|
|
if sdk_version := ctx.sdkVersion(); ctx.useSdk() && sdk_version != "current" {
|
|
// Native coverage is not supported for SDK versions < 23
|
|
if fromApi, err := strconv.Atoi(sdk_version); err == nil && fromApi < 23 {
|
|
needCoverageVariant = false
|
|
}
|
|
}
|
|
|
|
if needCoverageVariant {
|
|
// Coverage variant is actually built with coverage if enabled for its module path
|
|
needCoverageBuild = ctx.DeviceConfig().CoverageEnabledForPath(ctx.ModuleDir())
|
|
}
|
|
}
|
|
|
|
cov.Properties.NeedCoverageBuild = needCoverageBuild
|
|
cov.Properties.NeedCoverageVariant = needCoverageVariant
|
|
}
|
|
|
|
func coverageMutator(mctx android.BottomUpMutatorContext) {
|
|
if c, ok := mctx.Module().(*Module); ok && c.coverage != nil {
|
|
needCoverageVariant := c.coverage.Properties.NeedCoverageVariant
|
|
needCoverageBuild := c.coverage.Properties.NeedCoverageBuild
|
|
if needCoverageVariant {
|
|
m := mctx.CreateVariations("", "cov")
|
|
|
|
// Setup the non-coverage version and set HideFromMake and
|
|
// PreventInstall to true.
|
|
m[0].(*Module).coverage.Properties.CoverageEnabled = false
|
|
m[0].(*Module).coverage.Properties.IsCoverageVariant = false
|
|
m[0].(*Module).Properties.HideFromMake = true
|
|
m[0].(*Module).Properties.PreventInstall = true
|
|
|
|
// The coverage-enabled version inherits HideFromMake,
|
|
// PreventInstall from the original module.
|
|
m[1].(*Module).coverage.Properties.CoverageEnabled = needCoverageBuild
|
|
m[1].(*Module).coverage.Properties.IsCoverageVariant = true
|
|
}
|
|
}
|
|
}
|