40067de675
This CL adds support to bp2build for declaring the location of the Starlark rule definition when creating BazelTargetModules. This is needed for non-native rules that needs to be loaded from .bzl files somewhere in the tree. Since load statements are aggregated at the top of the BUILD file, away from the targets that actually use them, this CL also introduces an abstraction to group BazelTargets together and compute their load statements and target string representations separately, allowing load statements to be decoupled and written into a BUILD file before the targets themselves. Test: soong tests Test: TH Test: GENERATE_BAZEL_FILES=true m nothing && build/bazel/scripts/bp2build-sync.sh write && bazel cquery //bionic/... Fixes: 178531760 Test: TH Change-Id: Ie5f793a00006eb024eaef07ddd9fde7aaefc054e
107 lines
2.7 KiB
Go
107 lines
2.7 KiB
Go
// Copyright 2020 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package bp2build
|
|
|
|
import (
|
|
"sort"
|
|
"testing"
|
|
)
|
|
|
|
type filepath struct {
|
|
dir string
|
|
basename string
|
|
}
|
|
|
|
func assertFilecountsAreEqual(t *testing.T, actual []BazelFile, expected []filepath) {
|
|
if a, e := len(actual), len(expected); a != e {
|
|
t.Errorf("Expected %d files, got %d", e, a)
|
|
}
|
|
}
|
|
|
|
func assertFileContent(t *testing.T, actual []BazelFile, expected []filepath) {
|
|
for i := range actual {
|
|
if g, w := actual[i], expected[i]; g.Dir != w.dir || g.Basename != w.basename {
|
|
t.Errorf("Did not find expected file %s/%s", g.Dir, g.Basename)
|
|
} else if g.Basename == "BUILD" || g.Basename == "WORKSPACE" {
|
|
if g.Contents != "" {
|
|
t.Errorf("Expected %s to have no content.", g)
|
|
}
|
|
} else if g.Contents == "" {
|
|
t.Errorf("Contents of %s unexpected empty.", g)
|
|
}
|
|
}
|
|
}
|
|
|
|
func sortFiles(files []BazelFile) {
|
|
sort.Slice(files, func(i, j int) bool {
|
|
if dir1, dir2 := files[i].Dir, files[j].Dir; dir1 == dir2 {
|
|
return files[i].Basename < files[j].Basename
|
|
} else {
|
|
return dir1 < dir2
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestCreateBazelFiles_QueryView_AddsTopLevelFiles(t *testing.T) {
|
|
files := CreateBazelFiles(map[string]RuleShim{}, map[string]BazelTargets{}, QueryView)
|
|
expectedFilePaths := []filepath{
|
|
{
|
|
dir: "",
|
|
basename: "BUILD",
|
|
},
|
|
{
|
|
dir: "",
|
|
basename: "WORKSPACE",
|
|
},
|
|
{
|
|
dir: bazelRulesSubDir,
|
|
basename: "BUILD",
|
|
},
|
|
{
|
|
dir: bazelRulesSubDir,
|
|
basename: "providers.bzl",
|
|
},
|
|
{
|
|
dir: bazelRulesSubDir,
|
|
basename: "soong_module.bzl",
|
|
},
|
|
}
|
|
|
|
assertFilecountsAreEqual(t, files, expectedFilePaths)
|
|
sortFiles(files)
|
|
assertFileContent(t, files, expectedFilePaths)
|
|
}
|
|
|
|
func TestCreateBazelFiles_Bp2Build_AddsTopLevelFiles(t *testing.T) {
|
|
files := CreateBazelFiles(map[string]RuleShim{}, map[string]BazelTargets{}, Bp2Build)
|
|
expectedFilePaths := []filepath{
|
|
{
|
|
dir: "",
|
|
basename: "BUILD",
|
|
},
|
|
{
|
|
dir: "",
|
|
basename: "WORKSPACE",
|
|
},
|
|
{
|
|
dir: bazelRulesSubDir,
|
|
basename: "BUILD",
|
|
},
|
|
}
|
|
|
|
assertFilecountsAreEqual(t, files, expectedFilePaths)
|
|
sortFiles(files)
|
|
assertFileContent(t, files, expectedFilePaths)
|
|
}
|