tequilaOS/platform_build_soong
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
platform_build_soong/android
History
Paul Duffin 44885e29d6 Simplify visibility rules that include //visibility:public 
While it is invalid to mix //visibility:public with other rules in the
visibility property in a .bp file tt was possible, by overriding
defaults, to have //visibility:public mixed in with other rules in the
effective visibility rules. That caused problems when those effective
rules were used in an sdk snapshot.

This change replaces any set of rules that include //visibility:public
with just the //visibility:public rule. That simplifies those rules,
making them cheaper to process and ensures that the effective rules are
valid in the visibility property.

Adding test support required some refactoring of the
effectiveVisibilityRules(BaseModuleContext, ...) and underlying methods
to take a Config instead of BaseModuleContext as the tests do not have
access to BaseModuleContext.

Bug: 142935992
Test: m nothing - new tests failed without change, work with it
      Add dex2oat to art-module-host-exports, build it and check the
      generated Android.bp file in the snapshot to ensure the
	  visibility property for the dex2oat prebuilt does not mix
	  //visibility:public with other rules.
Change-Id: I08e7f0dcb40838d426fe88fedf69eae27b77473c
2020-02-20 11:41:17 +00:00
..
soongconfig Simplify vendor conditionals 2020-01-24 16:43:40 -08:00
android_test.go Share buildDir for android/soong/android tests 2019-06-10 15:51:06 -07:00
androidmk.go Sandbox soong_build by changing to root directory 2020-01-11 01:11:46 +00:00
androidmk_test.go Move filesystem into Config 2019-12-18 08:19:10 -08:00
apex.go Statically link the unwinder into binaries packaged into an unbundled APEX with legacy_android10_support: true. 2020-02-13 22:29:44 -08:00
api_levels.go Merge changes I9f8df94f,I2d7f5c56,I0ebb7381,Ieefcfc1a am: a6bf56d4be 2019-06-10 10:00:33 -07:00
arch.go Simple refactoring of prefix related functions. 2020-02-14 14:33:49 -08:00
arch_test.go Do a better job removing tags from arch structs 2020-01-22 18:30:56 -08:00
config.go Simple refactoring of prefix related functions. 2020-02-14 14:33:49 -08:00
config_test.go Fix go vet issues 2018-07-22 21:18:45 -07:00
csuite_config.go Create C-Suite config module 2019-10-18 18:28:00 +00:00
csuite_config_test.go Move filesystem into Config 2019-12-18 08:19:10 -08:00
defaults.go Fix product variables in defaults modules 2020-02-06 17:43:29 -08:00
defaults_test.go Fix product variables in defaults modules 2020-02-06 17:43:29 -08:00
defs.go Create a highmem pool and put metalava into it 2020-01-24 11:44:23 -08:00
env.go Sandbox soong_build by changing to root directory 2020-01-11 01:11:46 +00:00
expand.go Fix android.Expand and ninja escaping 2019-07-11 14:52:17 -07:00
expand_test.go Fix android.Expand and ninja escaping 2019-07-11 14:52:17 -07:00
filegroup.go Replace ctx.ExpandSources with android.PathsForModuleSrc 2019-03-20 19:36:13 +00:00
hooks.go Follow input changes to proptools.CloneEmptyProperties 2020-01-28 12:17:06 -08:00
image.go Add ramdisk image. 2020-01-22 16:54:18 -08:00
makevars.go Sandbox soong_build by changing to root directory 2020-01-11 01:11:46 +00:00
module.go Add apex name to description 2020-02-14 12:33:52 -08:00
module_test.go Move filesystem into Config 2019-12-18 08:19:10 -08:00
mutator.go Follow input changes to proptools.CloneEmptyProperties 2020-01-28 12:17:06 -08:00
mutator_test.go Add FinalDeps mutator phase, where CreateVariations is disallowed. 2020-01-21 11:40:02 +00:00
namespace.go Simplify vendor conditionals 2020-01-24 16:43:40 -08:00
namespace_test.go Move filesystem into Config 2019-12-18 08:19:10 -08:00
neverallow.go Simple refactoring of prefix related functions. 2020-02-14 14:33:49 -08:00
neverallow_test.go Move filesystem into Config 2019-12-18 08:19:10 -08:00
notices.go Separate InstallPath from OutputPath 2019-10-03 10:07:53 -07:00
onceper.go Convert droidstubs to android.RuleBuilder 2019-07-18 14:28:14 -07:00
onceper_test.go Prevent hangs in OncePer when the callback panics 2019-05-14 18:40:13 +00:00
override_module.go Rename OverridableModuleBase.properties. 2020-01-10 13:26:00 -08:00
package.go Dedup package build components registration 2020-01-15 11:17:57 +00:00
package_ctx.go Add support for experimentally enabling RBE support on specific rules. 2020-01-28 12:42:47 -05:00
package_test.go Dedup package build components registration 2020-01-15 11:17:57 +00:00
path_properties.go Dedup path properties across property structs 2019-07-16 09:52:23 -07:00
path_properties_test.go Move filesystem into Config 2019-12-18 08:19:10 -08:00
paths.go Allocate OutputPath.String in PathForOutput 2020-01-29 16:56:37 -08:00
paths_test.go Add ramdisk image. 2020-01-22 16:54:18 -08:00
prebuilt.go java_sdk_library - Use prebuilt/prefer for unbundled app builds 2020-02-05 08:09:57 +00:00
prebuilt_etc.go Add ramdisk image. 2020-01-22 16:54:18 -08:00
prebuilt_etc_test.go Move filesystem into Config 2019-12-18 08:19:10 -08:00
prebuilt_test.go Exclude source->prebuilt deps from visibility enforcement 2020-01-15 11:17:57 +00:00
proto.go Add method to determine variations from a Target 2019-10-16 14:52:30 -07:00
register.go Add FinalDeps mutator phase, where CreateVariations is disallowed. 2020-01-21 11:40:02 +00:00
rule_builder.go Add support for experimentally enabling RBE support on specific rules. 2020-01-28 12:42:47 -05:00
rule_builder_test.go Move filesystem into Config 2019-12-18 08:19:10 -08:00
sandbox.go Sandbox soong_build by changing to root directory 2020-01-11 01:11:46 +00:00
sdk.go Add java_system_modules to sdk/module_exports 2020-02-07 14:03:03 +00:00
sh_binary.go Make sh_binary a HostToolProvider 2019-12-19 09:22:36 -08:00
sh_binary_test.go Move filesystem into Config 2019-12-18 08:19:10 -08:00
singleton.go Create a highmem pool and put metalava into it 2020-01-24 11:44:23 -08:00
soong_config_modules.go Add dependency on Soong config module definition file 2020-02-06 19:35:49 +00:00
soong_config_modules_test.go Add test for capitalized Soong config variable 2020-02-06 19:36:05 +00:00
testing.go Add FinalDeps mutator phase, where CreateVariations is disallowed. 2020-01-21 11:40:02 +00:00
util.go Simple refactoring of prefix related functions. 2020-02-14 14:33:49 -08:00
util_test.go Simple refactoring of prefix related functions. 2020-02-14 14:33:49 -08:00
variable.go Remove execute-only support. 2020-02-13 13:50:34 -05:00
variable_test.go Fix product variables in defaults modules 2020-02-06 17:43:29 -08:00
visibility.go Simplify visibility rules that include //visibility:public 2020-02-20 11:41:17 +00:00
visibility_test.go Simplify visibility rules that include //visibility:public 2020-02-20 11:41:17 +00:00
vts_config.go Allow vts config to be packaged in other test suites 2020-02-13 16:06:49 -08:00
vts_config_test.go Move filesystem into Config 2019-12-18 08:19:10 -08:00
writedocs.go Split up Soong build doc. 2019-02-20 15:43:06 -08:00