Commit graph

18 commits

Author SHA1 Message Date
Michael Bestas
7bb9e7f4df
sm6225-common: gps: data-items: Fix snprintf usage
Fixes:
gps/core/data-items/DataItemConcreteTypes.cpp:465:9: error: 'snprintf'
will always be truncated; specified size is 10, but format string
expands to at least 20 [-Werror,-Wfortify-source]
  465 |         snprintf(t, sizeof(t),
        "[%02x:%02x:%02x:%02x:%02x:%02x]", d->mApSrnMacAddress[0],
      |         ^
gps/core/data-items/DataItemConcreteTypes.cpp:514:9: error: 'snprintf'
will always be truncated; specified size is 10, but format string
expands to at least 20 [-Werror,-Wfortify-source]
  514 |         snprintf(t, sizeof(t),
        "[%02x:%02x:%02x:%02x:%02x:%02x]", d->mApSrnMacAddress[0],
      |         ^
2 errors generated.

Change-Id: I37188e7497f7ade97648fb41e2becd73f6b559a9
2024-06-15 23:37:22 +03:00
Tomasz Wasilczyk
651569648c
sm6225-common: gps: Don't include cutils/threads.h
Bug: 289414897
Test: buildserver
Change-Id: I14b99f42feaae7af00cbd17cfe482eb2e5da71e8
2024-03-10 22:46:52 +02:00
Tommaso Fonda
0ea4719b77
sm6225-common: gps: Resolve more unused parameter warnings
Change-Id: I8c0b039c610ae4abc82b1bb8d975cb76b9ba2027
2024-01-05 11:41:07 +02:00
Michael Bestas
58e72f4794
sm6225-common: Update GPS HAL to LA.UM.9.15.r1-07400-KAMORTA.QSSI13.0
Change-Id: I8f0f477db0fdeed28fc4ba1c997bfe38b1c7268f
2024-01-05 11:41:07 +02:00
me-cafebabe
f258949f98
sm6225-common: gps: Fix compilation on U
Change-Id: I7ca7e78addd6385289b8449edae8b682839ecc91
2023-10-25 12:13:15 +03:00
Madhanraj Chelladurai
8d504d7312 sm6225-common: gps: Add NULL check before object access
Correct the NULL check code block and add NULL check before
object access.

Change-Id: Ic41b781b41fb4e21bbff8801d500a41a6d7219d0
CRs-fixed: 3084543
2023-09-03 15:56:58 +02:00
Michael Bestas
2ff59b0506
sm6225-common: Implement xtra-daemon control via property
Default to false if the property is not set.
Device init scripts will need to be adapted to restart
loc_launcher service when property change is detected.

Change-Id: Icbda789cd2a9a3391f437af2c07fc5127f2f09ab
2023-06-09 14:53:20 +03:00
Michael Bestas
0b7ef392e1
sm6225-common: gps: Remove all Wno-error flags
Almost all warnings/errors have been fixed.
Ignore undefined bool conversion error on purpose.

Change-Id: I00cb5f38711fa9f873da030fc6a0ebc6cde3ceeb
2023-06-09 14:53:20 +03:00
Albert I
43f7193260
sm6225-common: gps: Implement list empty error code for msg_q
This fixes enum-conversion warning due to implicit type enum casting
between linked_list and msg_q which happens only for status -6.

Change-Id: I27ba74c4d840b7ba0cb1017d69a30fc25b80d6b9
2023-06-09 14:53:20 +03:00
Albert I
7a678665fd
sm6225-common: gps: Address logical-op-parentheses warning
Change-Id: I45d621a2b995afeb7757df3f89614a0d95552f33
2023-06-09 14:53:20 +03:00
Albert I
e2c5259e43
sm6225-common: gps: Reorder initializations list to satisfy warnings
-Wreorder-ctor is a compile-time, Clang-only flag which is enabled by
default since Clang 12, which will warn whenever a specified field will
be initialized right after field specified below it. However, since it
doesn't sweep through all fields, compiler may miss some of them.

This order has been checked thoroughly through many trial and errors to
ensure that no such warns will be triggered anymore.

Change-Id: Id24cbb7277dc8d6c02767f8f365818ab6c017683
2023-06-09 14:53:19 +03:00
Michael Bestas
3011099f3c
sm6225-common: gps: Resolve unused parameter warnings
Change-Id: I0acef3da2c3567a28edd0a71dac89a5828f7725d
2023-06-09 14:53:19 +03:00
Michael Bestas
ff4965a0af
sm6225-common: Lower gps debug level
* Kill logcat spam

Change-Id: I20d1f698d3c2d1b56e79f6eb6c5c17069e43c60f
2023-05-17 20:48:48 +03:00
Ethan Chen
0f6b8dcc64
sm6225-common: gps: Increase batch size to max
* Hardware supports 40

Change-Id: I075fff615814fa105ec1493c5bdde60b8abccf0e
2023-05-17 20:48:48 +03:00
Michael Bestas
a8f5ba0aa0
sm6225-common: gps: Disable unused location services
Disable xtwifi, slim_daemon & tloc_daemon, matching Pixel setup.

Change-Id: I27156e772ef138c9b2e112469c264236ea5c398c
2023-05-17 20:48:48 +03:00
Michael Bestas
4e4403b259
sm6225-common: Move izat config to device tree
Remove unused apdr.conf while we are at it

Change-Id: I49e6a7be7b29a79739c8f66966e26213c71b6160
2023-05-17 20:48:48 +03:00
Arian
10f4d72f92
sm6225-common: gps: Fix usage of or operator on booleans
Change-Id: I1e3f9caef674d8a2cfc99092033d96bc4cdd8963
2023-05-17 20:48:47 +03:00
Michael Bestas
d5ecca2f41
sm6225-common: Import GPS HAL from LA.UM.9.15.r1-05900-KAMORTA.QSSI12.0
Change-Id: Id9a462cf8bf1140854659dcff958f9979905e3dc
2023-05-17 20:48:47 +03:00