2019-06-20 23:19:39 +02:00
|
|
|
// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
|
2006-11-29 06:45:46 +01:00
|
|
|
/*
|
|
|
|
* libfdt - Flat Device Tree manipulation
|
|
|
|
* Copyright (C) 2006 David Gibson, IBM Corporation.
|
|
|
|
*/
|
|
|
|
#include "libfdt_env.h"
|
|
|
|
|
|
|
|
#include <fdt.h>
|
|
|
|
#include <libfdt.h>
|
|
|
|
|
|
|
|
#include "libfdt_internal.h"
|
|
|
|
|
2017-10-22 07:32:15 +02:00
|
|
|
static int fdt_sw_probe_(void *fdt)
|
2006-11-29 06:45:46 +01:00
|
|
|
{
|
2020-03-02 20:02:55 +01:00
|
|
|
if (!can_assume(VALID_INPUT)) {
|
2020-02-20 22:45:52 +01:00
|
|
|
if (fdt_magic(fdt) == FDT_MAGIC)
|
|
|
|
return -FDT_ERR_BADSTATE;
|
|
|
|
else if (fdt_magic(fdt) != FDT_SW_MAGIC)
|
|
|
|
return -FDT_ERR_BADMAGIC;
|
|
|
|
}
|
|
|
|
|
2006-11-29 06:45:46 +01:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-10-22 07:32:15 +02:00
|
|
|
#define FDT_SW_PROBE(fdt) \
|
2008-05-20 09:19:11 +02:00
|
|
|
{ \
|
|
|
|
int err; \
|
2017-10-22 07:32:15 +02:00
|
|
|
if ((err = fdt_sw_probe_(fdt)) != 0) \
|
2008-05-20 09:19:11 +02:00
|
|
|
return err; \
|
|
|
|
}
|
|
|
|
|
2018-04-10 09:06:18 +02:00
|
|
|
/* 'memrsv' state: Initial state after fdt_create()
|
|
|
|
*
|
|
|
|
* Allowed functions:
|
2020-06-18 06:21:17 +02:00
|
|
|
* fdt_add_reservemap_entry()
|
2018-04-10 09:06:18 +02:00
|
|
|
* fdt_finish_reservemap() [moves to 'struct' state]
|
|
|
|
*/
|
|
|
|
static int fdt_sw_probe_memrsv_(void *fdt)
|
|
|
|
{
|
|
|
|
int err = fdt_sw_probe_(fdt);
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
2020-03-02 20:02:55 +01:00
|
|
|
if (!can_assume(VALID_INPUT) && fdt_off_dt_strings(fdt) != 0)
|
2018-04-10 09:06:18 +02:00
|
|
|
return -FDT_ERR_BADSTATE;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
#define FDT_SW_PROBE_MEMRSV(fdt) \
|
|
|
|
{ \
|
|
|
|
int err; \
|
|
|
|
if ((err = fdt_sw_probe_memrsv_(fdt)) != 0) \
|
|
|
|
return err; \
|
|
|
|
}
|
|
|
|
|
|
|
|
/* 'struct' state: Enter this state after fdt_finish_reservemap()
|
|
|
|
*
|
|
|
|
* Allowed functions:
|
|
|
|
* fdt_begin_node()
|
|
|
|
* fdt_end_node()
|
|
|
|
* fdt_property*()
|
|
|
|
* fdt_finish() [moves to 'complete' state]
|
|
|
|
*/
|
|
|
|
static int fdt_sw_probe_struct_(void *fdt)
|
|
|
|
{
|
|
|
|
int err = fdt_sw_probe_(fdt);
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
2020-03-02 20:02:55 +01:00
|
|
|
if (!can_assume(VALID_INPUT) &&
|
|
|
|
fdt_off_dt_strings(fdt) != fdt_totalsize(fdt))
|
2018-04-10 09:06:18 +02:00
|
|
|
return -FDT_ERR_BADSTATE;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
#define FDT_SW_PROBE_STRUCT(fdt) \
|
|
|
|
{ \
|
|
|
|
int err; \
|
|
|
|
if ((err = fdt_sw_probe_struct_(fdt)) != 0) \
|
|
|
|
return err; \
|
|
|
|
}
|
|
|
|
|
2019-05-09 11:41:21 +02:00
|
|
|
static inline uint32_t sw_flags(void *fdt)
|
|
|
|
{
|
|
|
|
/* assert: (fdt_magic(fdt) == FDT_SW_MAGIC) */
|
|
|
|
return fdt_last_comp_version(fdt);
|
|
|
|
}
|
|
|
|
|
2018-04-10 09:06:18 +02:00
|
|
|
/* 'complete' state: Enter this state after fdt_finish()
|
|
|
|
*
|
|
|
|
* Allowed functions: none
|
|
|
|
*/
|
|
|
|
|
2017-10-18 08:22:40 +02:00
|
|
|
static void *fdt_grab_space_(void *fdt, size_t len)
|
2006-11-29 06:45:46 +01:00
|
|
|
{
|
2020-09-21 18:52:52 +02:00
|
|
|
unsigned int offset = fdt_size_dt_struct(fdt);
|
|
|
|
unsigned int spaceleft;
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2006-12-01 05:02:10 +01:00
|
|
|
spaceleft = fdt_totalsize(fdt) - fdt_off_dt_struct(fdt)
|
|
|
|
- fdt_size_dt_strings(fdt);
|
2006-11-29 06:45:46 +01:00
|
|
|
|
|
|
|
if ((offset + len < offset) || (offset + len > spaceleft))
|
|
|
|
return NULL;
|
|
|
|
|
2007-10-25 06:29:38 +02:00
|
|
|
fdt_set_size_dt_struct(fdt, offset + len);
|
2017-10-18 08:22:40 +02:00
|
|
|
return fdt_offset_ptr_w_(fdt, offset);
|
2006-11-29 06:45:46 +01:00
|
|
|
}
|
|
|
|
|
2019-05-09 11:41:21 +02:00
|
|
|
int fdt_create_with_flags(void *buf, int bufsize, uint32_t flags)
|
2006-11-29 06:45:46 +01:00
|
|
|
{
|
2018-07-09 06:50:38 +02:00
|
|
|
const size_t hdrsize = FDT_ALIGN(sizeof(struct fdt_header),
|
|
|
|
sizeof(struct fdt_reserve_entry));
|
2006-12-15 05:12:47 +01:00
|
|
|
void *fdt = buf;
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2018-07-09 06:50:38 +02:00
|
|
|
if (bufsize < hdrsize)
|
2006-12-15 05:12:51 +01:00
|
|
|
return -FDT_ERR_NOSPACE;
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2019-05-09 11:41:21 +02:00
|
|
|
if (flags & ~FDT_CREATE_FLAGS_ALL)
|
|
|
|
return -FDT_ERR_BADFLAGS;
|
|
|
|
|
2006-11-29 06:45:46 +01:00
|
|
|
memset(buf, 0, bufsize);
|
|
|
|
|
2019-05-09 11:41:21 +02:00
|
|
|
/*
|
|
|
|
* magic and last_comp_version keep intermediate state during the fdt
|
|
|
|
* creation process, which is replaced with the proper FDT format by
|
|
|
|
* fdt_finish().
|
|
|
|
*
|
|
|
|
* flags should be accessed with sw_flags().
|
|
|
|
*/
|
2008-07-09 06:10:24 +02:00
|
|
|
fdt_set_magic(fdt, FDT_SW_MAGIC);
|
2007-10-25 06:29:38 +02:00
|
|
|
fdt_set_version(fdt, FDT_LAST_SUPPORTED_VERSION);
|
2019-05-09 11:41:21 +02:00
|
|
|
fdt_set_last_comp_version(fdt, flags);
|
|
|
|
|
2007-10-25 06:29:38 +02:00
|
|
|
fdt_set_totalsize(fdt, bufsize);
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2018-07-09 06:50:38 +02:00
|
|
|
fdt_set_off_mem_rsvmap(fdt, hdrsize);
|
2007-10-25 06:29:38 +02:00
|
|
|
fdt_set_off_dt_struct(fdt, fdt_off_mem_rsvmap(fdt));
|
2018-04-10 09:06:18 +02:00
|
|
|
fdt_set_off_dt_strings(fdt, 0);
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2006-12-15 05:12:51 +01:00
|
|
|
return 0;
|
2006-11-29 06:45:46 +01:00
|
|
|
}
|
|
|
|
|
2019-05-09 11:41:21 +02:00
|
|
|
int fdt_create(void *buf, int bufsize)
|
|
|
|
{
|
|
|
|
return fdt_create_with_flags(buf, bufsize, 0);
|
|
|
|
}
|
|
|
|
|
2013-10-25 15:17:37 +02:00
|
|
|
int fdt_resize(void *fdt, void *buf, int bufsize)
|
|
|
|
{
|
|
|
|
size_t headsize, tailsize;
|
|
|
|
char *oldtail, *newtail;
|
|
|
|
|
2017-10-22 07:32:15 +02:00
|
|
|
FDT_SW_PROBE(fdt);
|
2013-10-25 15:17:37 +02:00
|
|
|
|
2018-07-07 21:57:19 +02:00
|
|
|
headsize = fdt_off_dt_struct(fdt) + fdt_size_dt_struct(fdt);
|
2013-10-25 15:17:37 +02:00
|
|
|
tailsize = fdt_size_dt_strings(fdt);
|
|
|
|
|
2020-02-20 22:45:52 +01:00
|
|
|
if (!can_assume(VALID_DTB) &&
|
|
|
|
headsize + tailsize > fdt_totalsize(fdt))
|
2018-07-09 06:50:38 +02:00
|
|
|
return -FDT_ERR_INTERNAL;
|
|
|
|
|
2013-10-25 15:17:37 +02:00
|
|
|
if ((headsize + tailsize) > bufsize)
|
|
|
|
return -FDT_ERR_NOSPACE;
|
|
|
|
|
|
|
|
oldtail = (char *)fdt + fdt_totalsize(fdt) - tailsize;
|
|
|
|
newtail = (char *)buf + bufsize - tailsize;
|
|
|
|
|
|
|
|
/* Two cases to avoid clobbering data if the old and new
|
|
|
|
* buffers partially overlap */
|
|
|
|
if (buf <= fdt) {
|
|
|
|
memmove(buf, fdt, headsize);
|
|
|
|
memmove(newtail, oldtail, tailsize);
|
|
|
|
} else {
|
|
|
|
memmove(newtail, oldtail, tailsize);
|
|
|
|
memmove(buf, fdt, headsize);
|
|
|
|
}
|
|
|
|
|
|
|
|
fdt_set_totalsize(buf, bufsize);
|
2018-04-10 09:06:18 +02:00
|
|
|
if (fdt_off_dt_strings(buf))
|
|
|
|
fdt_set_off_dt_strings(buf, bufsize);
|
2013-10-25 15:17:37 +02:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-12-15 05:12:47 +01:00
|
|
|
int fdt_add_reservemap_entry(void *fdt, uint64_t addr, uint64_t size)
|
2006-11-29 06:45:46 +01:00
|
|
|
{
|
|
|
|
struct fdt_reserve_entry *re;
|
|
|
|
int offset;
|
|
|
|
|
2018-04-10 09:06:18 +02:00
|
|
|
FDT_SW_PROBE_MEMRSV(fdt);
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2006-12-01 05:02:10 +01:00
|
|
|
offset = fdt_off_dt_struct(fdt);
|
|
|
|
if ((offset + sizeof(*re)) > fdt_totalsize(fdt))
|
2006-12-15 05:12:51 +01:00
|
|
|
return -FDT_ERR_NOSPACE;
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2008-07-07 02:10:48 +02:00
|
|
|
re = (struct fdt_reserve_entry *)((char *)fdt + offset);
|
2006-11-29 06:45:46 +01:00
|
|
|
re->address = cpu_to_fdt64(addr);
|
|
|
|
re->size = cpu_to_fdt64(size);
|
|
|
|
|
2007-10-25 06:29:38 +02:00
|
|
|
fdt_set_off_dt_struct(fdt, offset + sizeof(*re));
|
2006-11-29 06:45:46 +01:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-12-15 05:12:47 +01:00
|
|
|
int fdt_finish_reservemap(void *fdt)
|
2006-11-29 06:45:46 +01:00
|
|
|
{
|
2018-04-10 09:06:18 +02:00
|
|
|
int err = fdt_add_reservemap_entry(fdt, 0, 0);
|
|
|
|
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
fdt_set_off_dt_strings(fdt, fdt_totalsize(fdt));
|
|
|
|
return 0;
|
2006-11-29 06:45:46 +01:00
|
|
|
}
|
|
|
|
|
2006-12-15 05:12:47 +01:00
|
|
|
int fdt_begin_node(void *fdt, const char *name)
|
2006-11-29 06:45:46 +01:00
|
|
|
{
|
|
|
|
struct fdt_node_header *nh;
|
2018-04-10 09:06:18 +02:00
|
|
|
int namelen;
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2018-04-10 09:06:18 +02:00
|
|
|
FDT_SW_PROBE_STRUCT(fdt);
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2018-04-10 09:06:18 +02:00
|
|
|
namelen = strlen(name) + 1;
|
2017-10-18 08:22:40 +02:00
|
|
|
nh = fdt_grab_space_(fdt, sizeof(*nh) + FDT_TAGALIGN(namelen));
|
2006-11-29 06:45:46 +01:00
|
|
|
if (! nh)
|
2006-12-15 05:12:51 +01:00
|
|
|
return -FDT_ERR_NOSPACE;
|
2006-11-29 06:45:46 +01:00
|
|
|
|
|
|
|
nh->tag = cpu_to_fdt32(FDT_BEGIN_NODE);
|
|
|
|
memcpy(nh->name, name, namelen);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-12-15 05:12:47 +01:00
|
|
|
int fdt_end_node(void *fdt)
|
2006-11-29 06:45:46 +01:00
|
|
|
{
|
2012-11-14 01:34:30 +01:00
|
|
|
fdt32_t *en;
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2018-04-10 09:06:18 +02:00
|
|
|
FDT_SW_PROBE_STRUCT(fdt);
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2017-10-18 08:22:40 +02:00
|
|
|
en = fdt_grab_space_(fdt, FDT_TAGSIZE);
|
2006-11-29 06:45:46 +01:00
|
|
|
if (! en)
|
2006-12-15 05:12:51 +01:00
|
|
|
return -FDT_ERR_NOSPACE;
|
2006-11-29 06:45:46 +01:00
|
|
|
|
|
|
|
*en = cpu_to_fdt32(FDT_END_NODE);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-05-09 11:41:22 +02:00
|
|
|
static int fdt_add_string_(void *fdt, const char *s)
|
|
|
|
{
|
|
|
|
char *strtab = (char *)fdt + fdt_totalsize(fdt);
|
|
|
|
int strtabsize = fdt_size_dt_strings(fdt);
|
|
|
|
int len = strlen(s) + 1;
|
|
|
|
int struct_top, offset;
|
|
|
|
|
|
|
|
offset = -strtabsize - len;
|
|
|
|
struct_top = fdt_off_dt_struct(fdt) + fdt_size_dt_struct(fdt);
|
|
|
|
if (fdt_totalsize(fdt) + offset < struct_top)
|
|
|
|
return 0; /* no more room :( */
|
|
|
|
|
|
|
|
memcpy(strtab + offset, s, len);
|
|
|
|
fdt_set_size_dt_strings(fdt, strtabsize + len);
|
|
|
|
return offset;
|
|
|
|
}
|
|
|
|
|
2019-05-09 11:41:20 +02:00
|
|
|
/* Must only be used to roll back in case of error */
|
|
|
|
static void fdt_del_last_string_(void *fdt, const char *s)
|
|
|
|
{
|
|
|
|
int strtabsize = fdt_size_dt_strings(fdt);
|
|
|
|
int len = strlen(s) + 1;
|
|
|
|
|
|
|
|
fdt_set_size_dt_strings(fdt, strtabsize - len);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int fdt_find_add_string_(void *fdt, const char *s, int *allocated)
|
2006-11-29 06:45:46 +01:00
|
|
|
{
|
2006-12-01 05:02:10 +01:00
|
|
|
char *strtab = (char *)fdt + fdt_totalsize(fdt);
|
|
|
|
int strtabsize = fdt_size_dt_strings(fdt);
|
2019-05-09 11:41:22 +02:00
|
|
|
const char *p;
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2019-05-09 11:41:20 +02:00
|
|
|
*allocated = 0;
|
|
|
|
|
2017-10-18 08:22:40 +02:00
|
|
|
p = fdt_find_string_(strtab - strtabsize, strtabsize, s);
|
2006-12-01 05:11:58 +01:00
|
|
|
if (p)
|
|
|
|
return p - strtab;
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2019-05-09 11:41:20 +02:00
|
|
|
*allocated = 1;
|
|
|
|
|
2019-05-09 11:41:22 +02:00
|
|
|
return fdt_add_string_(fdt, s);
|
2006-11-29 06:45:46 +01:00
|
|
|
}
|
|
|
|
|
2017-04-01 17:31:41 +02:00
|
|
|
int fdt_property_placeholder(void *fdt, const char *name, int len, void **valp)
|
2006-11-29 06:45:46 +01:00
|
|
|
{
|
|
|
|
struct fdt_property *prop;
|
|
|
|
int nameoff;
|
2019-05-09 11:41:20 +02:00
|
|
|
int allocated;
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2018-04-10 09:06:18 +02:00
|
|
|
FDT_SW_PROBE_STRUCT(fdt);
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2019-05-09 11:41:22 +02:00
|
|
|
/* String de-duplication can be slow, _NO_NAME_DEDUP skips it */
|
|
|
|
if (sw_flags(fdt) & FDT_CREATE_FLAG_NO_NAME_DEDUP) {
|
|
|
|
allocated = 1;
|
|
|
|
nameoff = fdt_add_string_(fdt, name);
|
|
|
|
} else {
|
|
|
|
nameoff = fdt_find_add_string_(fdt, name, &allocated);
|
|
|
|
}
|
2006-11-29 06:45:46 +01:00
|
|
|
if (nameoff == 0)
|
2006-12-15 05:12:51 +01:00
|
|
|
return -FDT_ERR_NOSPACE;
|
2006-11-29 06:45:46 +01:00
|
|
|
|
2017-10-18 08:22:40 +02:00
|
|
|
prop = fdt_grab_space_(fdt, sizeof(*prop) + FDT_TAGALIGN(len));
|
2019-05-09 11:41:20 +02:00
|
|
|
if (! prop) {
|
|
|
|
if (allocated)
|
|
|
|
fdt_del_last_string_(fdt, name);
|
2006-12-15 05:12:51 +01:00
|
|
|
return -FDT_ERR_NOSPACE;
|
2019-05-09 11:41:20 +02:00
|
|
|
}
|
2006-11-29 06:45:46 +01:00
|
|
|
|
|
|
|
prop->tag = cpu_to_fdt32(FDT_PROP);
|
|
|
|
prop->nameoff = cpu_to_fdt32(nameoff);
|
|
|
|
prop->len = cpu_to_fdt32(len);
|
2017-04-01 17:31:41 +02:00
|
|
|
*valp = prop->data;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int fdt_property(void *fdt, const char *name, const void *val, int len)
|
|
|
|
{
|
|
|
|
void *ptr;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = fdt_property_placeholder(fdt, name, len, &ptr);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
memcpy(ptr, val, len);
|
2006-11-29 06:45:46 +01:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-12-15 05:12:47 +01:00
|
|
|
int fdt_finish(void *fdt)
|
2006-11-29 06:45:46 +01:00
|
|
|
{
|
|
|
|
char *p = (char *)fdt;
|
2012-11-14 01:34:30 +01:00
|
|
|
fdt32_t *end;
|
2006-12-01 05:02:10 +01:00
|
|
|
int oldstroffset, newstroffset;
|
2006-11-29 06:45:46 +01:00
|
|
|
uint32_t tag;
|
|
|
|
int offset, nextoffset;
|
|
|
|
|
2018-04-10 09:06:18 +02:00
|
|
|
FDT_SW_PROBE_STRUCT(fdt);
|
2006-11-29 06:45:46 +01:00
|
|
|
|
|
|
|
/* Add terminator */
|
2017-10-18 08:22:40 +02:00
|
|
|
end = fdt_grab_space_(fdt, sizeof(*end));
|
2006-11-29 06:45:46 +01:00
|
|
|
if (! end)
|
2006-12-15 05:12:51 +01:00
|
|
|
return -FDT_ERR_NOSPACE;
|
2006-11-29 06:45:46 +01:00
|
|
|
*end = cpu_to_fdt32(FDT_END);
|
|
|
|
|
|
|
|
/* Relocate the string table */
|
2006-12-01 05:02:10 +01:00
|
|
|
oldstroffset = fdt_totalsize(fdt) - fdt_size_dt_strings(fdt);
|
2006-12-01 06:25:39 +01:00
|
|
|
newstroffset = fdt_off_dt_struct(fdt) + fdt_size_dt_struct(fdt);
|
2006-12-01 05:02:10 +01:00
|
|
|
memmove(p + newstroffset, p + oldstroffset, fdt_size_dt_strings(fdt));
|
2007-10-25 06:29:38 +02:00
|
|
|
fdt_set_off_dt_strings(fdt, newstroffset);
|
2006-11-29 06:45:46 +01:00
|
|
|
|
|
|
|
/* Walk the structure, correcting string offsets */
|
|
|
|
offset = 0;
|
2007-10-24 03:06:09 +02:00
|
|
|
while ((tag = fdt_next_tag(fdt, offset, &nextoffset)) != FDT_END) {
|
2006-11-29 06:45:46 +01:00
|
|
|
if (tag == FDT_PROP) {
|
2007-06-13 06:18:10 +02:00
|
|
|
struct fdt_property *prop =
|
2017-10-18 08:22:40 +02:00
|
|
|
fdt_offset_ptr_w_(fdt, offset);
|
2006-11-29 06:45:46 +01:00
|
|
|
int nameoff;
|
|
|
|
|
|
|
|
nameoff = fdt32_to_cpu(prop->nameoff);
|
2006-12-01 05:02:10 +01:00
|
|
|
nameoff += fdt_size_dt_strings(fdt);
|
2006-11-29 06:45:46 +01:00
|
|
|
prop->nameoff = cpu_to_fdt32(nameoff);
|
|
|
|
}
|
|
|
|
offset = nextoffset;
|
|
|
|
}
|
libfdt: Rework/cleanup fdt_next_tag()
Currently, callers of fdt_next_tag() must usually follow the call with
some sort of call to fdt_offset_ptr() to verify that the blob isn't
truncated in the middle of the tag data they're going to process.
This is a bit silly, since fdt_next_tag() generally has to call
fdt_offset_ptr() on at least some of the data following the tag for
its own operation.
This patch alters fdt_next_tag() to always use fdt_offset_ptr() to
verify the data between its starting offset and the offset it returns
in nextoffset. This simplifies fdt_get_property() which no longer has
to verify itself that the property data is all present.
At the same time, I neaten and clarify the error handling for
fdt_next_tag(). Previously, fdt_next_tag() could return -1 instead of
a tag value in some circumstances - which almost none of the callers
checked for. Also, fdt_next_tag() could return FDT_END either because
it encountered an FDT_END tag, or because it reached the end of the
structure block - no way was provided to tell between these cases.
With this patch, fdt_next_tag() always returns FDT_END with a negative
value in nextoffset for an error. This means the several places which
loop looking for FDT_END will still work correctly - they only need to
check for errors at the end. The errors which fdt_next_tag() can
report are:
- -FDT_ERR_TRUNCATED if it reached the end of the structure
block instead of finding a tag.
- -FDT_BADSTRUCTURE if a bad tag was encountered, or if the
tag data couldn't be verified with fdt_offset_ptr().
This patch also updates the callers of fdt_next_tag(), where
appropriate, to make use of the new error reporting.
Finally, the prototype for the long gone _fdt_next_tag() is removed
from libfdt_internal.h.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2009-02-06 04:03:24 +01:00
|
|
|
if (nextoffset < 0)
|
|
|
|
return nextoffset;
|
2006-11-29 06:45:46 +01:00
|
|
|
|
|
|
|
/* Finally, adjust the header */
|
2007-10-25 06:29:38 +02:00
|
|
|
fdt_set_totalsize(fdt, newstroffset + fdt_size_dt_strings(fdt));
|
2019-05-09 11:41:21 +02:00
|
|
|
|
|
|
|
/* And fix up fields that were keeping intermediate state. */
|
|
|
|
fdt_set_last_comp_version(fdt, FDT_FIRST_SUPPORTED_VERSION);
|
2007-10-25 06:29:38 +02:00
|
|
|
fdt_set_magic(fdt, FDT_MAGIC);
|
2019-05-09 11:41:21 +02:00
|
|
|
|
2006-11-29 06:45:46 +01:00
|
|
|
return 0;
|
|
|
|
}
|