tequilaOS/platform_external_dtc
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

dtc: Fix signedness comparisons warnings: reservednum

Browse source 
With -Wsign-compare, compilers warn about a mismatching signedness
in comparisons in code using the "reservednum" variable.

There is obviously little sense in having a negative number of reserved
memory entries, so let's make this variable and all its users unsigned.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Message-Id: <20210611171040.25524-6-andre.przywara@arm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
Andre Przywara 2021-06-11 18:10:37 +01:00 committed by David Gibson
parent 24e7f511fd
commit 5bec74a6d1
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
dtc.c
View file

@ -12,7 +12,7 @@
* Command line options * Command line options
*/ */
int quiet; /* Level of quietness */ int quiet; /* Level of quietness */
int reservenum; /* Number of memory reservation slots */ unsigned int reservenum;/* Number of memory reservation slots */
int minsize; /* Minimum blob size */ int minsize; /* Minimum blob size */
int padsize; /* Additional padding to blob */ int padsize; /* Additional padding to blob */
int alignsize; /* Additional padding to blob accroding to the alignsize */ int alignsize; /* Additional padding to blob accroding to the alignsize */
@ -197,7 +197,7 @@ int main(int argc, char *argv[])
depname = optarg; depname = optarg;
break; break;
case 'R': case 'R':
reservenum = strtol(optarg, NULL, 0); reservenum = strtoul(optarg, NULL, 0);
break; break;
case 'S': case 'S':
minsize = strtol(optarg, NULL, 0); minsize = strtol(optarg, NULL, 0);

2
dtc.h
View file

@ -35,7 +35,7 @@
* Command line options * Command line options
*/ */
extern int quiet; /* Level of quietness */ extern int quiet; /* Level of quietness */
extern int reservenum; /* Number of memory reservation slots */ extern unsigned int reservenum; /* Number of memory reservation slots */
extern int minsize; /* Minimum blob size */ extern int minsize; /* Minimum blob size */
extern int padsize; /* Additional padding to blob */ extern int padsize; /* Additional padding to blob */
extern int alignsize; /* Additional padding to blob accroding to the alignsize */ extern int alignsize; /* Additional padding to blob accroding to the alignsize */

2
flattree.c
View file

@ -295,7 +295,7 @@ static struct data flatten_reserve_list(struct reserve_info *reservelist,
{ {
struct reserve_info *re; struct reserve_info *re;
struct data d = empty_data; struct data d = empty_data;
int j; unsigned int j;
for (re = reservelist; re; re = re->next) { for (re = reservelist; re; re = re->next) {
d = data_append_re(d, re->address, re->size); d = data_append_re(d, re->address, re->size);