From a1fe86f380cbae3fb1aea85654d44637dd13d6c3 Mon Sep 17 00:00:00 2001 From: "kevans@FreeBSD.org" Date: Tue, 2 Jan 2018 21:05:38 -0600 Subject: [PATCH] fdtoverlay: Switch from using alloca to malloc alloca entails a complicated header situation when using other platforms, where some split it out in alloca.h while others include it as a standard part of stdlib.h. The cons don't seem to outweigh the pros, so switch it to malloc. Signed-off-by: Kyle Evans Signed-off-by: David Gibson --- fdtoverlay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fdtoverlay.c b/fdtoverlay.c index 7f124fc..62a942d 100644 --- a/fdtoverlay.c +++ b/fdtoverlay.c @@ -26,7 +26,6 @@ #include #include #include -#include #include #include @@ -79,7 +78,7 @@ static int do_fdtoverlay(const char *input_filename, ret = 0; /* allocate blob pointer array */ - ovblob = alloca(sizeof(*ovblob) * argc); + ovblob = malloc(sizeof(*ovblob) * argc); memset(ovblob, 0, sizeof(*ovblob) * argc); /* read and keep track of the overlay blobs */ @@ -121,6 +120,7 @@ out_err: if (ovblob[i]) free(ovblob[i]); } + free(ovblob); } free(blob);