tequilaOS/platform_external_dtc
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

libfdt: fix an incorrect integer promotion

Browse source 
UINT32_MAX is an integer of type unsigned int. UINT32_MAX + 1 overflows
unless explicitly computed as unsigned long long. This led to some
invalid addresses being treated as valid.

Cast UINT32_MAX to uint64_t explicitly.

Signed-off-by: Elvira Khabirova <e.khabirova@omp.ru>
This commit is contained in:
Elvira Khabirova 2021-11-09 18:47:19 +03:00 committed by David Gibson
parent 1cc41b1c96
commit c19a4bafa5
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libfdt/fdt_addresses.c
View file

@ -73,7 +73,7 @@ int fdt_appendprop_addrrange(void *fdt, int parent, int nodeoffset,
/* check validity of address */ /* check validity of address */
prop = data; prop = data;
if (addr_cells == 1) { if (addr_cells == 1) {
if ((addr > UINT32_MAX) || ((UINT32_MAX + 1 - addr) < size)) if ((addr > UINT32_MAX) || (((uint64_t) UINT32_MAX + 1 - addr) < size))
return -FDT_ERR_BADVALUE; return -FDT_ERR_BADVALUE;
fdt32_st(prop, (uint32_t)addr); fdt32_st(prop, (uint32_t)addr);