c14223fb22
libfdt is never supposed to access memory outside the the blob, or outside the sub-blocks within it, even if the blob is badly corrupted. We can leverage valgrind's client requests to do better testing of this. This adds a vg_prepare_blob() function which marks just the valid parts of an fdt blob as properly initialized, explicitly marking the rest as uninitialized. This means valgrind should catch any bad accesses. We add a call to vg_prepare_blob() to load_blob() so that lots of the existing testcases will benefit from the extra checking. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Tested-by: Alexey Kardashevskiy <aik@ozlabs.ru> Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
49 lines
1.5 KiB
C
49 lines
1.5 KiB
C
/*
|
|
* libfdt - Flat Device Tree manipulation
|
|
* Testcase for misbehaviour on a truncated property
|
|
* Copyright (C) 2006 David Gibson, IBM Corporation.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public License
|
|
* as published by the Free Software Foundation; either version 2.1 of
|
|
* the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#include <stdlib.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <stdint.h>
|
|
|
|
#include <libfdt.h>
|
|
|
|
#include "tests.h"
|
|
#include "testdata.h"
|
|
|
|
int main(int argc, char *argv[])
|
|
{
|
|
void *fdt = &truncated_property;
|
|
const void *prop;
|
|
int len;
|
|
|
|
test_init(argc, argv);
|
|
|
|
vg_prepare_blob(fdt, fdt_totalsize(fdt));
|
|
|
|
prop = fdt_getprop(fdt, 0, "truncated", &len);
|
|
if (prop)
|
|
FAIL("fdt_getprop() succeeded on truncated property");
|
|
if (len != -FDT_ERR_BADSTRUCTURE)
|
|
FAIL("fdt_getprop() failed with \"%s\" instead of \"%s\"",
|
|
fdt_strerror(len), fdt_strerror(-FDT_ERR_BADSTRUCTURE));
|
|
|
|
PASS();
|
|
}
|