No description
Find a file
Greg Kurz 9619c8619c Kill bogus TYPE_BLOB marker type
Since commit 32b9c61307 "Preserve datatype markers when emitting dts
format", we no longer try to guess the value type. Instead, we reuse
the type of the datatype markers when they are present, if the type
is either TYPE_UINT* or TYPE_STRING.

This causes 'dtc -I fs' to crash:

Starting program: /root/dtc -q -f -O dts -I fs /proc/device-tree
/dts-v1/;

/ {

Program received signal SIGSEGV, Segmentation fault.
__strlen_power8 () at ../sysdeps/powerpc/powerpc64/power8/strlen.S:47
47              ld      r12,0(r4)     /* Load doubleword from memory.  */
(gdb) bt
#0  __strlen_power8 () at ../sysdeps/powerpc/powerpc64/power8/strlen.S:47
#1  0x00007ffff7de3d10 in __GI__IO_fputs (str=<optimized out>,
    fp=<optimized out>) at iofputs.c:33
#2  0x000000001000c7a0 in write_propval (prop=0x100525e0,
    f=0x7ffff7f718a0 <_IO_2_1_stdout_>) at treesource.c:245

The offending line is:

                fprintf(f, "%s", delim_start[emit_type]);

where emit_type is TYPE_BLOB and:

static const char *delim_start[] = {
        [TYPE_UINT8] = "[",
        [TYPE_UINT16] = "/bits/ 16 <",
        [TYPE_UINT32] = "<",
        [TYPE_UINT64] = "/bits/ 64 <",
        [TYPE_STRING] = "",
};

/* Data blobs */
enum markertype {
        TYPE_NONE,
        REF_PHANDLE,
        REF_PATH,
        LABEL,
        TYPE_UINT8,
        TYPE_UINT16,
        TYPE_UINT32,
        TYPE_UINT64,
        TYPE_BLOB,
        TYPE_STRING,
};

Because TYPE_BLOB < TYPE_STRING and delim_start[] is a static array,
delim_start[emit_type] is 0x0. The glibc usually prints out "(null)"
when one passes 0x0 to %s, but it seems to call fputs() internally if
the format is exactly "%s", hence the crash.

TYPE_BLOB basically means the data comes from a file and we don't know
its type. We don't care for the former, and the latter is TYPE_NONE.

So let's drop TYPE_BLOB completely and use TYPE_NONE instead when reading
the file. Then, try to guess the data type at emission time, like the
code already does for refs and labels.

Instead of adding yet another check for TYPE_NONE, an helper is introduced
to check if the data marker has type information, ie, >= TYPE_UINT8.

Fixes: 32b9c61307
Suggested-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2018-08-31 11:13:33 +10:00
Documentation fdtput: Add documentation 2018-06-07 21:54:38 +10:00
libfdt libfdt: fdt_address_cells() and fdt_size_cells() 2018-07-20 11:56:49 +10:00
pylibfdt pylibfdt: Support the sequential-write interface 2018-07-11 16:21:20 +10:00
scripts dtc: Add maintainer script for signing and upload to kernel.org 2014-11-12 14:27:02 +11:00
tests tests: Correction to vg_prepare_blob() 2018-07-23 12:16:09 +10:00
.gitignore Add fdtoverlay to .gitignore 2017-09-27 20:00:10 +10:00
.travis.yml tests: Use valgrind client requests for better checking 2018-06-07 11:49:17 +10:00
checks.c checks: add SPI bus checks 2018-07-27 13:42:50 +10:00
convert-dtsv0-lexer.l Fix assorted sparse warnings 2017-03-06 12:08:53 +11:00
data.c Kill bogus TYPE_BLOB marker type 2018-08-31 11:13:33 +10:00
dtc-lexer.l dtc: add ability to make nodes conditional on them being referenced 2018-05-04 11:48:46 +10:00
dtc-parser.y parser: add TYPE_STRING marker to path references 2018-08-01 10:02:38 +10:00
dtc.c livetree: avoid assertion of orphan phandles with overlays 2017-10-27 16:25:54 +02:00
dtc.h Kill bogus TYPE_BLOB marker type 2018-08-31 11:13:33 +10:00
dtdiff dtc: Add code to make diffing trees easier 2010-11-13 15:47:29 -06:00
fdtdump.c Use <inttypes.h> format specifiers in a bunch of places we should 2018-06-07 11:49:17 +10:00
fdtget.c libfdt: Add helpers for accessing unaligned words 2018-06-26 15:09:46 +10:00
fdtoverlay.c Use size_t for blob lengths in utilfdt_read* 2018-06-07 11:49:17 +10:00
fdtput.c Consolidate utilfdt_read_len() variants 2018-06-07 11:48:20 +10:00
flattree.c Use <inttypes.h> format specifiers in a bunch of places we should 2018-06-07 11:49:17 +10:00
fstree.c Rename boot_info 2016-12-09 16:30:43 +11:00
GPL dtc: Remove redundant copy of the GPL 2007-06-25 21:43:11 -05:00
livetree.c livetree: Set phandle properties type to uint32 2018-07-13 10:38:25 +10:00
Makefile dtc: Bump version to v1.4.7 2018-07-23 13:00:50 +10:00
Makefile.convert-dtsv0 Implement and use an xstrdup() function 2008-10-03 11:12:33 -05:00
Makefile.dtc Implement and use an xstrdup() function 2008-10-03 11:12:33 -05:00
Makefile.utils fdtoverlay: A tool that applies overlays 2017-06-15 15:37:07 +08:00
README README: Add a note about test_tree1.dts 2017-08-21 10:18:25 +10:00
README.license dtc/libfdt: Add README clarifying licensing 2008-01-04 08:37:36 -06:00
srcpos.c srcpos: drop special handling of tab 2018-01-23 17:05:00 +11:00
srcpos.h Remove leading underscores from identifiers 2017-10-26 09:25:14 +02:00
TODO dtc: Update TODO files 2007-12-19 08:20:26 -06:00
treesource.c Kill bogus TYPE_BLOB marker type 2018-08-31 11:13:33 +10:00
util.c Use size_t for blob lengths in utilfdt_read* 2018-06-07 11:49:17 +10:00
util.h Use size_t for blob lengths in utilfdt_read* 2018-06-07 11:49:17 +10:00

The source tree contains the Device Tree Compiler (dtc) toolchain for
working with device tree source and binary files and also libfdt, a
utility library for reading and manipulating the binary format.

DTC and LIBFDT are maintained by:

David Gibson <david@gibson.dropbear.id.au>
Jon Loeliger <jdl@jdl.com>


Python library
--------------

A Python library is also available. To build this you will need to install
swig and Python development files. On Debian distributions:

   sudo apt-get install swig python-dev

The library provides an Fdt class which you can use like this:

$ PYTHONPATH=../pylibfdt python
>>> import libfdt
>>> fdt = libfdt.Fdt(open('test_tree1.dtb').read())
>>> node = fdt.path_offset('/subnode@1')
>>> print node
124
>>> prop_offset = fdt.first_property_offset(node)
>>> prop = fdt.get_property_by_offset(prop_offset)
>>> print '%s=%r' % (prop.name, prop.value)
compatible=bytearray(b'subnode1\x00')
>>> print '%s=%s' % (prop.name, prop.value)
compatible=subnode1
>>> node2 = fdt.path_offset('/')
>>> print fdt.getprop(node2, 'compatible')
test_tree1

You will find tests in tests/pylibfdt_tests.py showing how to use each
method. Help is available using the Python help command, e.g.:

    $ cd pylibfdt
    $ python -c "import libfdt; help(libfdt)"

If you add new features, please check code coverage:

    $ sudo apt-get install python-pip python-pytest
    $ sudo pip install coverage
    $ cd tests
    $ coverage run pylibfdt_tests.py
    $ coverage html
    # Open 'htmlcov/index.html' in your browser


To install the library via the normal setup.py method, use:

    ./pylibfdt/setup.py [--prefix=/path/to/install_dir]

If --prefix is not provided, the default prefix is used, typically '/usr'
or '/usr/local'. See Python's distutils documentation for details. You can
also install via the Makefile if you like, but the above is more common.

To install both libfdt and pylibfdt you can use:

    make install [SETUP_PREFIX=/path/to/install_dir] \
            [PREFIX=/path/to/install_dir]

To disable building the python library, even if swig and Python are available,
use:

    make NO_PYTHON=1


More work remains to support all of libfdt, including access to numeric
values.


Tests
-----

Test files are kept in the tests/ directory. Use 'make check' to build and run
all tests.

If you want to adjust a test file, be aware that tree_tree1.dts is compiled
and checked against a binary tree from assembler macros in trees.S. So
if you change that file you must change tree.S also.


Mailing list
------------
The following list is for discussion about dtc and libfdt implementation
mailto:devicetree-compiler@vger.kernel.org

Core device tree bindings are discussed on the devicetree-spec list:
mailto:devicetree-spec@vger.kernel.org