b8d6eca782
c12b2b0c20 "libfdt: fdt_address_cells() and fdt_size_cells()" introduced
a bug as it consolidated code between the helpers for getting
#address-cells and #size-cells. Specifically #size-cells is allowed to
be 0, and is frequently found so in practice for /cpus. IEEE1275 only
requires implementations to handle 1..4 for #address-cells, although one
could make a case for #address-cells == #size-cells == 0 being used to
represent a bridge with a single port.
While we're there, it's not totally obvious that the existing implicit
cast of a u32 to int will give the correct results according to strict C,
although it does work in practice. Straighten that up to cast only after
we've made our range checks.
Reported-by: yonghuhaige via https://github.com/dgibson/dtc/issues/28
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
56 lines
1.4 KiB
C
56 lines
1.4 KiB
C
// SPDX-License-Identifier: LGPL-2.1-or-later
|
|
/*
|
|
* libfdt - Flat Device Tree manipulation
|
|
* Testcase for #address-cells and #size-cells handling
|
|
* Copyright (C) 2014 David Gibson, <david@gibson.dropbear.id.au>
|
|
*/
|
|
#include <stdlib.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <stdint.h>
|
|
|
|
#include <libfdt.h>
|
|
|
|
#include "tests.h"
|
|
#include "testdata.h"
|
|
|
|
static void check_node(const void *fdt, const char *path, int ac, int sc)
|
|
{
|
|
int offset;
|
|
int xac, xsc;
|
|
|
|
offset = fdt_path_offset(fdt, path);
|
|
if (offset < 0)
|
|
FAIL("Couldn't find path %s", path);
|
|
|
|
xac = fdt_address_cells(fdt, offset);
|
|
xsc = fdt_size_cells(fdt, offset);
|
|
|
|
if (xac != ac)
|
|
FAIL("Address cells for %s is %d instead of %d\n",
|
|
path, xac, ac);
|
|
if (xsc != sc)
|
|
FAIL("Size cells for %s is %d instead of %d\n",
|
|
path, xsc, sc);
|
|
}
|
|
|
|
int main(int argc, char *argv[])
|
|
{
|
|
void *fdt;
|
|
|
|
if (argc != 2)
|
|
CONFIG("Usage: %s <dtb file>\n", argv[0]);
|
|
|
|
test_init(argc, argv);
|
|
fdt = load_blob(argv[1]);
|
|
|
|
check_node(fdt, "/", 2, 2);
|
|
check_node(fdt, "/identity-bus@0", 2, 1);
|
|
check_node(fdt, "/simple-bus@1000000", 2, 1);
|
|
check_node(fdt, "/discrete-bus@2000000", 1, 0);
|
|
check_node(fdt, "/c0", -FDT_ERR_BADNCELLS, -FDT_ERR_BADNCELLS);
|
|
check_node(fdt, "/c1", -FDT_ERR_BADNCELLS, -FDT_ERR_BADNCELLS);
|
|
check_node(fdt, "/c2", -FDT_ERR_BADNCELLS, -FDT_ERR_BADNCELLS);
|
|
check_node(fdt, "/c3", -FDT_ERR_BADNCELLS, 0);
|
|
PASS();
|
|
}
|