No description
d966f08fcd
With -Wsign-compare, compilers warn about a mismatching signedness in comparisons in various files in the tests/ directory. For about half of the cases we can simply change the signed variable to be of an unsigned type, because they will never need to store negative values (which is the best fix of the problem). In the remaining cases we can cast the signed variable to an unsigned type, provided we know for sure it is not negative. We see two different scenarios here: - We either just explicitly checked for this variable to be positive (if (rc < 0) FAIL();), or - We rely on a function returning only positive values in the "length" pointer if the function returned successfully: which we just checked. At two occassions we compare with a constant "-1" (even though the variable is unsigned), so we just change this to ~0U to create an unsigned comparison value. Since this is about the tests, let's also add explicit tests for those values really not being negative. This fixes "make tests" (but not "make check" yet), when compiled with -Wsign-compare. Signed-off-by: Andre Przywara <andre.przywara@arm.com> Message-Id: <20210618172030.9684-2-andre.przywara@arm.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au> |
||
---|---|---|
Documentation | ||
libfdt | ||
pylibfdt | ||
scripts | ||
tests | ||
.cirrus.yml | ||
.editorconfig | ||
.gitignore | ||
.travis.yml | ||
BSD-2-Clause | ||
checks.c | ||
convert-dtsv0-lexer.l | ||
data.c | ||
dtc-lexer.l | ||
dtc-parser.y | ||
dtc.c | ||
dtc.h | ||
dtdiff | ||
fdtdump.c | ||
fdtget.c | ||
fdtoverlay.c | ||
fdtput.c | ||
flattree.c | ||
fstree.c | ||
GPL | ||
livetree.c | ||
Makefile | ||
Makefile.convert-dtsv0 | ||
Makefile.dtc | ||
Makefile.utils | ||
meson.build | ||
meson_options.txt | ||
README | ||
README.license | ||
srcpos.c | ||
srcpos.h | ||
TODO | ||
treesource.c | ||
util.c | ||
util.h | ||
version_gen.h.in | ||
yamltree.c |
The source tree contains the Device Tree Compiler (dtc) toolchain for working with device tree source and binary files and also libfdt, a utility library for reading and manipulating the binary format. DTC and LIBFDT are maintained by: David Gibson <david@gibson.dropbear.id.au> Jon Loeliger <loeliger@gmail.com> Python library -------------- A Python library is also available. To build this you will need to install swig and Python development files. On Debian distributions: sudo apt-get install swig python3-dev The library provides an Fdt class which you can use like this: $ PYTHONPATH=../pylibfdt python3 >>> import libfdt >>> fdt = libfdt.Fdt(open('test_tree1.dtb', mode='rb').read()) >>> node = fdt.path_offset('/subnode@1') >>> print(node) 124 >>> prop_offset = fdt.first_property_offset(node) >>> prop = fdt.get_property_by_offset(prop_offset) >>> print('%s=%s' % (prop.name, prop.as_str())) compatible=subnode1 >>> node2 = fdt.path_offset('/') >>> print(fdt.getprop(node2, 'compatible').as_str()) test_tree1 You will find tests in tests/pylibfdt_tests.py showing how to use each method. Help is available using the Python help command, e.g.: $ cd pylibfdt $ python3 -c "import libfdt; help(libfdt)" If you add new features, please check code coverage: $ sudo apt-get install python3-coverage $ cd tests # It's just 'coverage' on most other distributions $ python3-coverage run pylibfdt_tests.py $ python3-coverage html # Open 'htmlcov/index.html' in your browser To install the library via the normal setup.py method, use: ./pylibfdt/setup.py install [--prefix=/path/to/install_dir] If --prefix is not provided, the default prefix is used, typically '/usr' or '/usr/local'. See Python's distutils documentation for details. You can also install via the Makefile if you like, but the above is more common. To install both libfdt and pylibfdt you can use: make install [SETUP_PREFIX=/path/to/install_dir] \ [PREFIX=/path/to/install_dir] To disable building the python library, even if swig and Python are available, use: make NO_PYTHON=1 More work remains to support all of libfdt, including access to numeric values. Tests ----- Test files are kept in the tests/ directory. Use 'make check' to build and run all tests. If you want to adjust a test file, be aware that tree_tree1.dts is compiled and checked against a binary tree from assembler macros in trees.S. So if you change that file you must change tree.S also. Mailing list ------------ The following list is for discussion about dtc and libfdt implementation mailto:devicetree-compiler@vger.kernel.org Core device tree bindings are discussed on the devicetree-spec list: mailto:devicetree-spec@vger.kernel.org