d966f08fcd
With -Wsign-compare, compilers warn about a mismatching signedness in comparisons in various files in the tests/ directory. For about half of the cases we can simply change the signed variable to be of an unsigned type, because they will never need to store negative values (which is the best fix of the problem). In the remaining cases we can cast the signed variable to an unsigned type, provided we know for sure it is not negative. We see two different scenarios here: - We either just explicitly checked for this variable to be positive (if (rc < 0) FAIL();), or - We rely on a function returning only positive values in the "length" pointer if the function returned successfully: which we just checked. At two occassions we compare with a constant "-1" (even though the variable is unsigned), so we just change this to ~0U to create an unsigned comparison value. Since this is about the tests, let's also add explicit tests for those values really not being negative. This fixes "make tests" (but not "make check" yet), when compiled with -Wsign-compare. Signed-off-by: Andre Przywara <andre.przywara@arm.com> Message-Id: <20210618172030.9684-2-andre.przywara@arm.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
129 lines
3.4 KiB
C
129 lines
3.4 KiB
C
// SPDX-License-Identifier: LGPL-2.1-or-later
|
|
/*
|
|
* libfdt - Flat Device Tree manipulation
|
|
* Testcase for phandle references in dtc
|
|
* Copyright (C) 2006 David Gibson, IBM Corporation.
|
|
*/
|
|
#include <stdlib.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <stdint.h>
|
|
|
|
#include <libfdt.h>
|
|
|
|
#include "tests.h"
|
|
#include "testdata.h"
|
|
|
|
static void check_ref(const void *fdt, int node, uint32_t checkref)
|
|
{
|
|
const fdt32_t *p;
|
|
uint32_t ref;
|
|
int len;
|
|
|
|
p = fdt_getprop(fdt, node, "ref", &len);
|
|
if (!p)
|
|
FAIL("fdt_getprop(%d, \"ref\"): %s", node, fdt_strerror(len));
|
|
if (len != sizeof(*p))
|
|
FAIL("'ref' in node at %d has wrong size (%d instead of %zd)",
|
|
node, len, sizeof(*p));
|
|
ref = fdt32_to_cpu(*p);
|
|
if (ref != checkref)
|
|
FAIL("'ref' in node at %d has value 0x%x instead of 0x%x",
|
|
node, ref, checkref);
|
|
|
|
p = fdt_getprop(fdt, node, "lref", &len);
|
|
if (!p)
|
|
FAIL("fdt_getprop(%d, \"lref\"): %s", node, fdt_strerror(len));
|
|
if (len != sizeof(*p))
|
|
FAIL("'lref' in node at %d has wrong size (%d instead of %zd)",
|
|
node, len, sizeof(*p));
|
|
ref = fdt32_to_cpu(*p);
|
|
if (ref != checkref)
|
|
FAIL("'lref' in node at %d has value 0x%x instead of 0x%x",
|
|
node, ref, checkref);
|
|
}
|
|
|
|
static void check_rref(const void *fdt)
|
|
{
|
|
const fdt32_t *p;
|
|
uint32_t ref;
|
|
int len;
|
|
|
|
p = fdt_getprop(fdt, 0, "rref", &len);
|
|
if (!p)
|
|
FAIL("fdt_getprop(0, \"rref\"): %s", fdt_strerror(len));
|
|
if (len != sizeof(*p))
|
|
FAIL("'rref' in root node has wrong size (%d instead of %zd)",
|
|
len, sizeof(*p));
|
|
ref = fdt32_to_cpu(*p);
|
|
if (ref != fdt_get_phandle(fdt, 0))
|
|
FAIL("'rref' in root node has value 0x%x instead of 0x0", ref);
|
|
}
|
|
|
|
int main(int argc, char *argv[])
|
|
{
|
|
void *fdt;
|
|
int n1, n2, n3, n4, n5, n6, err;
|
|
uint32_t h1, h2, h4, h5, h6, hn;
|
|
|
|
test_init(argc, argv);
|
|
fdt = load_blob_arg(argc, argv);
|
|
|
|
n1 = fdt_path_offset(fdt, "/node1");
|
|
if (n1 < 0)
|
|
FAIL("fdt_path_offset(/node1): %s", fdt_strerror(n1));
|
|
n2 = fdt_path_offset(fdt, "/node2");
|
|
if (n2 < 0)
|
|
FAIL("fdt_path_offset(/node2): %s", fdt_strerror(n2));
|
|
n3 = fdt_path_offset(fdt, "/node3");
|
|
if (n3 < 0)
|
|
FAIL("fdt_path_offset(/node3): %s", fdt_strerror(n3));
|
|
n4 = fdt_path_offset(fdt, "/node4");
|
|
if (n4 < 0)
|
|
FAIL("fdt_path_offset(/node4): %s", fdt_strerror(n4));
|
|
n5 = fdt_path_offset(fdt, "/node5");
|
|
if (n5 < 0)
|
|
FAIL("fdt_path_offset(/node5): %s", fdt_strerror(n5));
|
|
n6 = fdt_path_offset(fdt, "/node6");
|
|
if (n6 < 0)
|
|
FAIL("fdt_path_offset(/node6): %s", fdt_strerror(n6));
|
|
|
|
h1 = fdt_get_phandle(fdt, n1);
|
|
h2 = fdt_get_phandle(fdt, n2);
|
|
h4 = fdt_get_phandle(fdt, n4);
|
|
h5 = fdt_get_phandle(fdt, n5);
|
|
h6 = fdt_get_phandle(fdt, n6);
|
|
|
|
if (h1 != 0x2000)
|
|
FAIL("/node1 has wrong phandle, 0x%x instead of 0x%x",
|
|
h1, 0x2000);
|
|
if (h2 != 0x1)
|
|
FAIL("/node2 has wrong phandle, 0x%x instead of 0x%x",
|
|
h2, 0x1);
|
|
if (h6 != FDT_MAX_PHANDLE)
|
|
FAIL("/node6 has wrong phandle, 0x%x instead of 0x%x",
|
|
h6, FDT_MAX_PHANDLE);
|
|
if ((h4 == 0x2000) || (h4 == 0x1) || (h4 == 0))
|
|
FAIL("/node4 has bad phandle, 0x%x", h4);
|
|
|
|
if ((h5 == 0) || (h5 == ~0U))
|
|
FAIL("/node5 has bad phandle, 0x%x", h5);
|
|
if ((h5 == h4) || (h5 == h2) || (h5 == h1))
|
|
FAIL("/node5 has duplicate phandle, 0x%x", h5);
|
|
|
|
/*
|
|
* /node6 has phandle FDT_MAX_PHANDLE, so fdt_generate_phandle() is
|
|
* expected to fail.
|
|
*/
|
|
err = fdt_generate_phandle(fdt, &hn);
|
|
if (err != -FDT_ERR_NOPHANDLES)
|
|
FAIL("generated invalid phandle 0x%x\n", hn);
|
|
|
|
check_ref(fdt, n1, h2);
|
|
check_ref(fdt, n2, h1);
|
|
check_ref(fdt, n3, h4);
|
|
|
|
check_rref(fdt);
|
|
|
|
PASS();
|
|
}
|