No description
Find a file
David Gibson ff5afb96d0 Handle integer overflow in check_property_phandle_args()
If the corresponding '#xxx-cells' value is much too large, an integer
overflow can prevent the checks in check_property_phandle_args() from
correctly determining that the checked property is too short for the
given cells value.  This leads to an infinite loops.

This patch fixes the bug, and adds a testcase for it.  Further
information in https://github.com/dgibson/dtc/issues/64

Reported-by: Anciety <anciety@pku.edu.cn>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2021-12-29 17:04:18 +11:00
Documentation Support 'r' format for printing raw bytes with fdtget 2021-12-09 17:48:58 +11:00
libfdt Fix a UB when fdt_get_string return null 2021-12-28 20:11:11 +11:00
pylibfdt pylibfdt: add Property.as_*int*_array() 2021-12-28 15:30:33 +11:00
scripts dtc: Add GPLv2 SPDX tags to files missing license text 2019-06-21 21:06:10 +10:00
tests Handle integer overflow in check_property_phandle_args() 2021-12-29 17:04:18 +11:00
.cirrus.yml CI: Cirrus: bump used FreeBSD from 12.1 to 13.0 2021-11-01 14:02:44 +11:00
.editorconfig Add .editorconfig 2019-10-09 22:41:44 +11:00
.gitignore pylibfdt: Move setup.py to the top level 2021-11-11 14:34:51 +11:00
.travis.yml travis.yml: Run tests on the non-x86 builders, too 2019-12-04 16:54:04 +11:00
BSD-2-Clause README.license: Update to reflect SPDX tag usage 2019-06-21 21:06:10 +10:00
checks.c Handle integer overflow in check_property_phandle_args() 2021-12-29 17:04:18 +11:00
convert-dtsv0-lexer.l convert-dtsv0: Fix signedness comparisons warning 2020-10-13 15:48:40 +11:00
data.c dtc: Fix signedness comparisons warnings: Wrap (-1) 2020-10-13 15:58:53 +11:00
dtc-lexer.l Make handling of cpp line information more tolerant 2021-06-08 14:15:25 +10:00
dtc-parser.y dtc: Avoid UB when shifting 2020-07-15 20:40:54 +10:00
dtc.c dtc: Fix signedness comparisons warnings: reservednum 2021-06-15 12:48:25 +10:00
dtc.h asm: Use .asciz and .ascii instead of .string 2021-09-25 16:11:41 +10:00
dtdiff dtc: Add GPLv2 SPDX tags to files missing license text 2019-06-21 21:06:10 +10:00
fdtdump.c fdtdump: fix -Werror=int-to-pointer-cast 2021-08-26 10:58:26 +10:00
fdtget.c Support 'r' format for printing raw bytes with fdtget 2021-12-09 17:48:58 +11:00
fdtoverlay.c fdtoverlay: Return non-zero exit code if overlays can't be applied 2019-10-11 15:58:18 +11:00
fdtput.c Support 'r' format for printing raw bytes with fdtget 2021-12-09 17:48:58 +11:00
flattree.c flattree: Use '\n', not ';' to separate asm pseudo-ops 2021-09-27 11:54:56 +10:00
fstree.c fstree: replace lstat with stat 2019-10-14 17:07:10 +11:00
GPL Update the GPL2 text to the latest revision 2019-05-21 09:58:37 +10:00
livetree.c dtc: Wrap phandle validity check 2021-06-21 15:28:21 +10:00
Makefile Makefile: add -Wsign-compare to warning options 2021-06-21 15:34:49 +10:00
Makefile.convert-dtsv0 dtc: Add GPLv2 SPDX tags to files missing license text 2019-06-21 21:06:10 +10:00
Makefile.dtc dtc: Replace GPLv2 boilerplate/reference with SPDX tags 2019-06-21 21:06:10 +10:00
Makefile.utils dtc: Add GPLv2 SPDX tags to files missing license text 2019-06-21 21:06:10 +10:00
MANIFEST.in pylibfdt: Add packaging metadata 2021-11-12 15:58:23 +11:00
meson.build meson: fix -Wall warning 2020-12-08 15:30:28 +11:00
meson_options.txt build-sys: add meson build 2020-10-21 14:36:07 +11:00
README README: Explain how to add a new API function 2021-12-28 20:14:05 +11:00
README.license README.license: Update to reflect SPDX tag usage 2019-06-21 21:06:10 +10:00
setup.py pylibfdt: Add packaging metadata 2021-11-12 15:58:23 +11:00
srcpos.c srcpos: increase MAX_SRCFILE_DEPTH 2021-01-13 12:05:26 +11:00
srcpos.h dtc: Replace GPLv2 boilerplate/reference with SPDX tags 2019-06-21 21:06:10 +10:00
TODO dtc: Update TODO files 2007-12-19 08:20:26 -06:00
treesource.c treesource: Maintain phandle label/path on output 2021-10-11 16:20:53 +11:00
util.c Support 'r' format for printing raw bytes with fdtget 2021-12-09 17:48:58 +11:00
util.h Support 'r' format for printing raw bytes with fdtget 2021-12-09 17:48:58 +11:00
version_gen.h.in build-sys: add meson build 2020-10-21 14:36:07 +11:00
yamltree.c yamltree: Remove marker ordering dependency 2021-06-08 11:53:19 +10:00

The source tree contains the Device Tree Compiler (dtc) toolchain for
working with device tree source and binary files and also libfdt, a
utility library for reading and manipulating the binary format.

DTC and LIBFDT are maintained by:

David Gibson <david@gibson.dropbear.id.au>
Jon Loeliger <loeliger@gmail.com>


Python library
--------------

A Python library is also available. To build this you will need to install
swig and Python development files. On Debian distributions:

   sudo apt-get install swig python3-dev

The library provides an Fdt class which you can use like this:

$ PYTHONPATH=../pylibfdt python3
>>> import libfdt
>>> fdt = libfdt.Fdt(open('test_tree1.dtb', mode='rb').read())
>>> node = fdt.path_offset('/subnode@1')
>>> print(node)
124
>>> prop_offset = fdt.first_property_offset(node)
>>> prop = fdt.get_property_by_offset(prop_offset)
>>> print('%s=%s' % (prop.name, prop.as_str()))
compatible=subnode1
>>> node2 = fdt.path_offset('/')
>>> print(fdt.getprop(node2, 'compatible').as_str())
test_tree1

You will find tests in tests/pylibfdt_tests.py showing how to use each
method. Help is available using the Python help command, e.g.:

    $ cd pylibfdt
    $ python3 -c "import libfdt; help(libfdt)"

If you add new features, please check code coverage:

    $ sudo apt-get install python3-coverage
    $ cd tests
    # It's just 'coverage' on most other distributions
    $ python3-coverage run pylibfdt_tests.py
    $ python3-coverage html
    # Open 'htmlcov/index.html' in your browser


The library can be installed with pip from a local source tree:

    pip install . [--user|--prefix=/path/to/install_dir]

Or directly from a remote git repo:

    pip install git+git://git.kernel.org/pub/scm/utils/dtc/dtc.git@main

The install depends on libfdt shared library being installed on the host system
first. Generally, using --user or --prefix is not necessary and pip will use the
default location for the Python installation which varies if the user is root or
not.

You can also install everything via make if you like, but pip is recommended.

To install both libfdt and pylibfdt you can use:

    make install [PREFIX=/path/to/install_dir]

To disable building the python library, even if swig and Python are available,
use:

    make NO_PYTHON=1


More work remains to support all of libfdt, including access to numeric
values.


Adding a new function to libfdt.h
---------------------------------

The shared library uses libfdt/version.lds to list the exported functions, so
add your new function there. Check that your function works with pylibfdt. If
it cannot be supported, put the declaration in libfdt.h behind #ifndef SWIG so
that swig ignores it.


Tests
-----

Test files are kept in the tests/ directory. Use 'make check' to build and run
all tests.

If you want to adjust a test file, be aware that tree_tree1.dts is compiled
and checked against a binary tree from assembler macros in trees.S. So
if you change that file you must change tree.S also.


Mailing list
------------
The following list is for discussion about dtc and libfdt implementation
mailto:devicetree-compiler@vger.kernel.org

Core device tree bindings are discussed on the devicetree-spec list:
mailto:devicetree-spec@vger.kernel.org