tequilaOS/platform_external_selinux
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

libsemanage: close hll file descriptors

Browse source 
Stops leaking of file descriptors to things like load_policy and
setfiles.

Reported-by: Sven Vermeulen <sven.vermeulen@siphos.be>
Signed-off-by: Steve Lawrence <slawrence@tresys.com>
Reviewed-by: Yuli Khodorkovskiy <ykhodorkovskiy@tresys.com>
This commit is contained in:
Steve Lawrence 2014-11-24 10:15:05 -05:00
parent 678ec5df79
commit b817a523c4
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
libsemanage/src/direct_api.c
View file

@ -837,7 +837,8 @@ static int semanage_compile_hll(semanage_handle_t *sh,
ssize_t hll_data_len = 0;
ssize_t bzip_status;
int status = 0;
int i, compressed, in_fd;
int i, compressed;
int in_fd = -1;
size_t cil_data_len;
size_t err_data_len;
@ -891,6 +892,9 @@ static int semanage_compile_hll(semanage_handle_t *sh,
goto cleanup;
}
if (in_fd >= 0) close(in_fd);
in_fd = -1;
status = semanage_pipe_data(sh, compiler_path, hll_data, (size_t)hll_data_len, &cil_data, &cil_data_len, &err_data, &err_data_len);
if (err_data_len > 0) {
for (start = end = err_data; end < err_data + err_data_len; end++) {
@ -935,6 +939,7 @@ static int semanage_compile_hll(semanage_handle_t *sh,
cleanup:
if (hll_data_len > 0) munmap(hll_data, hll_data_len);
if (in_fd >= 0) close(in_fd);
free(cil_data);
free(err_data);
free(compiler_path);