tequilaOS/platform_frameworks_native
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

NFC: Directly initialize the 's' variable.

Browse source 
As part of enabling -Wconditional-uninitialized, there are some false
positives. See https://bugs.llvm.org/show_bug.cgi?id=38856 for more info
about the limited flow analysis. To facilitate turning this flag on more
widely, we can just directly initialize these variables.

Bug: http://b/131390872
Test: Builds with -Wconditional-uninitialized.
Change-Id: Id6633a06478dfb0c51a1a3b0cabf4c4e5d57abaa
This commit is contained in:
Stephen Hines 2019-05-09 13:03:40 -07:00
parent 67923215fe
commit 6896f0626b
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cmds/bugreport/bugreport.cpp
View file

@ -37,7 +37,7 @@ int main() {
property_set("ctl.start", "dumpstate");
// Socket will not be available until service starts.
int s;
int s = -1;
for (int i = 0; i < 20; i++) {
s = socket_local_client("dumpstate", ANDROID_SOCKET_NAMESPACE_RESERVED,
SOCK_STREAM);

2
cmds/bugreportz/main.cpp
View file

@ -72,7 +72,7 @@ int main(int argc, char* argv[]) {
property_set("ctl.start", "dumpstatez");
// Socket will not be available until service starts.
int s;
int s = -1;
for (int i = 0; i < 20; i++) {
s = socket_local_client("dumpstate", ANDROID_SOCKET_NAMESPACE_RESERVED, SOCK_STREAM);
if (s >= 0) break;