tequilaOS/platform_frameworks_native
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove unused BufferHubBase::GetBlobFds method

Browse source 
This method is not used in DVR buffering system. BufferHubBuffer may
consider having it later when it meets an use case when the buffer
contains multiple fds in buffer handle, and directly have it implemented
in BufferHubBuffer class.

Test: build
Bug: None
Change-Id: I95cd71d936695eeb77bd049f43fe350fb60d9154
This commit is contained in:
Tianyu Jiang 2019-01-31 14:25:47 -08:00
parent b469e92644
commit 8870520fdd
2 changed files with 0 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
libs/vr/libbufferhub/buffer_hub_base.cpp
View file

@ -218,12 +218,5 @@ int BufferHubBase::GetBlobReadWritePointer(size_t size, void** addr) {
return ret;
}
void BufferHubBase::GetBlobFds(int* fds, size_t* fds_count,
size_t max_fds_count) const {
size_t numFds = static_cast<size_t>(native_handle()->numFds);
*fds_count = std::min(max_fds_count, numFds);
std::copy(native_handle()->data, native_handle()->data + *fds_count, fds);
}
} // namespace dvr
} // namespace android

4
libs/vr/libbufferhub/include/private/dvr/buffer_hub_base.h
View file

@ -52,10 +52,6 @@ class BufferHubBase : public pdx::Client {
return LocalHandle(dup(native_handle()->data[0]));
}
// Get up to |max_fds_count| file descriptors for accessing the blob shared
// memory. |fds_count| will contain the actual number of file descriptors.
void GetBlobFds(int* fds, size_t* fds_count, size_t max_fds_count) const;
using Client::event_fd;
Status<int> GetEventMask(int events) {