Commit graph

76279 commits

Author SHA1 Message Date
JW Wang
fda19ecdd6 Delete APK snapshots during restoration (3/n)
The snapshots are no longer needed after restore is done.

We do this in keeping with the fact that apk/apex code data is
deleted immediately after the rollback is committed.

See go/rollbackmanager-snapshot-deletion for more details.

Bug: 151805360
Test: N/A. Will be added in the next CL.
Change-Id: I5a7540aa08922c4b0c617c9cb37e1bec2ff23fc1
2020-05-19 14:18:26 +08:00
Jooyung Han
55a7e2342d Merge "gui/math: Set min_sdk_version" am: ef685e33a0
Change-Id: I361b2fc0ab69b99c90553ca5c86d4692572fd7f9
2020-05-19 04:29:38 +00:00
Jooyung Han
ef685e33a0 Merge "gui/math: Set min_sdk_version" 2020-05-19 04:14:57 +00:00
Jooyung Han
394c177463 gui/math: Set min_sdk_version
Modules contributing mainline modules (APK/APEX) should set
min_sdk_version as well as apex_available.

For now setting min_sdk_version doesn't change build outputs.
But build-time checks will be added soon.

Exempt-From-Owner-Approval: cherry-pick from internal

Bug: 152655956
Test: m
Merged-In: Ib7685f5f4f924ac145eb4f10ad83a6c0548b2206
Change-Id: Ib7685f5f4f924ac145eb4f10ad83a6c0548b2206
(cherry picked from commit 54042e0ae4)
2020-05-19 04:14:38 +00:00
Treehugger Robot
f4b4f48ae2 Merge "Add isStable in Parcelable interface" am: ed760b0671
Change-Id: Ic16f3b95a14c9fde705a35c5f66cc8491b296688
2020-05-18 22:16:05 +00:00
Treehugger Robot
ed760b0671 Merge "Add isStable in Parcelable interface" 2020-05-18 22:11:37 +00:00
Steven Moreland
ad849b6371 Merge "libbinder: do not destruct SM global" am: 5921fa4151
Change-Id: Ib230829ed00632d7f2b54885fa4b134dd52cfdd7
2020-05-18 17:06:43 +00:00
Steven Moreland
5921fa4151 Merge "libbinder: do not destruct SM global" 2020-05-18 16:50:16 +00:00
Jon Spivack
e82eaa845b Add flag to cmd for dynamic services
When cmd is called with the -w flag, it will call ServiceManager::waitForService instead of checkService. This will make dynamic services start and block until they are ready for use.

Bug: 149526916
Test: atest ApexRollbackTests (with and without this flag applied within for dynamic apexd)
Change-Id: Iad0c3d7aa75e5830da10a84bd753d3011438259f
Merged-In: Iad0c3d7aa75e5830da10a84bd753d3011438259f
(cherry picked from commit 77f83368b1)
2020-05-18 13:16:59 +01:00
Jeongik Cha
9e8086658d Add isStable in Parcelable interface
Bug: 156242606
Test: m
Change-Id: I0edc64c8c7f8c9c08384f9d48832549eb026b9d0
2020-05-18 09:22:52 +00:00
Steven Moreland
1698ffd088 libbinder: do not destruct SM global
Let linux clean it up, since this may be accessed by some threads after
the main thread is destructed.

Bug: 154507808 # longterm
Bug: 156785633

Test: w/ repro which calls defaultServiceManager off main thread
Change-Id: Ic109f4bdca3893e6b0b192ac27f3ff03ada6f9e2
2020-05-16 00:27:55 +00:00
Jooyung Han
2804e79b5c Merge "setDefaultImpl aborts on a second call" am: 196feae688
Change-Id: Ieea885b8da74402cb90fcd0ba391b63bc1dd4a4a
2020-05-15 00:04:13 +00:00
Jooyung Han
196feae688 Merge "setDefaultImpl aborts on a second call" 2020-05-14 23:18:24 +00:00
Jooyung Han
81087399e9 setDefaultImpl aborts on a second call
The actual problem is that default implementation is set globally.
setDefaultImpl might not work as expected when it is called twice with
different instances.

Because we don't have a proper solution for the problem, we prevent
calling setDefaultImpl() twice by aborting.

Bug: 140139809
Test: ./runtests.sh (in /system/tools/aidl)
Change-Id: I659d3eaad3a45dcba608fa79a08f083f84bc4d58
2020-05-14 10:21:57 +09:00
Alec Mouri
348141ce2d Merge "[RenderEngine] Reorder when ImageManager thread starts" am: dd44f7465d
Change-Id: Ic1cea0343e18bac209f575c7b493af01fe1d2fd9
2020-05-12 22:00:41 +00:00
Alec Mouri
dd44f7465d Merge "[RenderEngine] Reorder when ImageManager thread starts" 2020-05-12 21:43:58 +00:00
Treehugger Robot
c5539cbf33 Merge "Updated OWNERS files" am: 22dfdb7283
Change-Id: I6f22cd45d462fa6b6320a562af857d84c3ae8357
2020-05-12 19:44:34 +00:00
Treehugger Robot
22dfdb7283 Merge "Updated OWNERS files" 2020-05-12 19:26:09 +00:00
Alec Mouri
6193c3b2e7 [RenderEngine] Reorder when ImageManager thread starts
Previously the background thread for managing EglImages was intialized
as a member variable before the constructor completed running. In very
rare circumstances this can potentially stop the running thread if the
thread ran before mRunning was initialized. To be less error-prone,
require that ImageManger::initThread be explicitly called to guarantee
that class member variables are well-defined when the thread begins
executing.

In case the issue resurfaces after this change, added a debug log to add
context.

Bug: 146416748
Bug: 155852355
Test: builds. There is no reliable repro, so this fix is speculative
Test: systrace to verify thread is running and configured correctly.
Change-Id: I141c86240b90c7f87c22b3768c2e188293987b76
Merged-In: I141c86240b90c7f87c22b3768c2e188293987b76
2020-05-12 19:05:37 +00:00
chaviw
bf5b42355b Updated OWNERS files
Test: Nothing
Bug: None
Change-Id: Ib055cbb8884b7a3ffa24f70d1e3ed610ac5024be
2020-05-12 10:00:16 -07:00
Treehugger Robot
72240b0926 Merge "sf: Fix issue with dequeueBuffer when multiple display present" am: fa5cda8260
Change-Id: Id157dba1141b394ac2689f3532ba7f6c07215eac
2020-05-11 20:20:42 +00:00
Treehugger Robot
fa5cda8260 Merge "sf: Fix issue with dequeueBuffer when multiple display present" 2020-05-11 20:05:02 +00:00
Baldev Sahu
0560e0e8ea sf: Fix issue with dequeueBuffer when multiple display present
swapBuffers is called even for device composition when a flip client
target request is present. dequeueBuffer call is skipped
as there is no client composition. This is fine for single display
but if multiple display i.e. vds is present, this will be an issue
as current surface will not be switched and swapBuffers will fail

When flip client target request is present, make sure buffer is
dequeued before swapBuffers.

Bug: 151698217
Test: atest libsurfaceflinger_unittest
Change-Id: I933cbae2f09f81eef6555b1bb1e5991d2c450930
Merged-In: Ia8a1470affb2596b27986cc4153417f48cf4ed1c
2020-05-11 12:06:06 -07:00
Treehugger Robot
fc822e7d93 Merge "libbinder_ndk: test -> tests" am: 8729d923ad
Change-Id: I338e2a59b2f504b5bfb5a7be68ab6e706eca0482
2020-05-08 05:21:00 +00:00
Treehugger Robot
8729d923ad Merge "libbinder_ndk: test -> tests" 2020-05-08 05:09:59 +00:00
Steven Moreland
03139dc103 libbinder_ndk: test -> tests
Since there is more than one test here.

Bug: 155793159
Test: N/A
Change-Id: I3d9195f670e108a3e4e72bdd41a9bcead0638dd4
2020-05-07 18:22:15 -07:00
Treehugger Robot
a9ac84cd52 Merge "Add svv@ to OWNERS for EndToEndNativeInputTest" am: 856e0b377e
Change-Id: I776f031da0ef7efb21aa1e415501e18ef24f5a46
2020-05-07 23:07:05 +00:00
Treehugger Robot
856e0b377e Merge "Add svv@ to OWNERS for EndToEndNativeInputTest" 2020-05-07 22:47:27 +00:00
Siarhei Vishniakou
6cdeb8c6aa Add svv@ to OWNERS for EndToEndNativeInputTest
Since svv@ changes this file a lot, add to owners.

Bug: none
Test: none
Change-Id: Id77b83cb4e09194e76ffca8670473ede59c6b3e4
2020-05-07 10:44:28 -07:00
Kris Alder
809e61ab77 Merge "media_plugin_headers: Add host support" am: 3e3cdc9b33
Change-Id: If72e7d3a4216646bb2f4f592f9116d93253842c4
2020-05-06 22:00:41 +00:00
Kris Alder
3e3cdc9b33 Merge "media_plugin_headers: Add host support" 2020-05-06 21:35:51 +00:00
S Vasudev Prasad
3d1c2f61f0 media_plugin_headers: Add host support
Test: Build media_plugin_headers
Bug: 151789258

Change-Id: I46553563666e81393a0237224cc19b3694123322
2020-05-05 11:08:16 +05:30
Treehugger Robot
b9fe624f3d Merge "Handle the boot profile format when analyzing profiles" am: dbd5b4325b
Change-Id: I6657784360dc5c5b16f6c25c773d3e8fab761c67
2020-05-04 23:59:29 +00:00
Treehugger Robot
dbd5b4325b Merge "Handle the boot profile format when analyzing profiles" 2020-05-04 23:40:38 +00:00
Calin Juravle
f85ddb9cce Handle the boot profile format when analyzing profiles
When analyzing profiles for dexopt, use the boot image profile format
if the system is configured to profile the boot image.

Test: atest installd_dexopt_test
Bug: 155423653

(cherry-picked from commit: c8a0442cad)

Merged-In: I83ff959389bafcfce291485f78e1b05d6ca42625
Change-Id: I83ff959389bafcfce291485f78e1b05d6ca42625
2020-05-04 14:16:12 -07:00
Treehugger Robot
26fa117faa Merge "libbinder: Document future direction of getService." am: aaa7aee168
Change-Id: I17d5eb021c504034cc1be41c4a20d60148f30a31
2020-05-01 20:42:31 +00:00
Treehugger Robot
aaa7aee168 Merge "libbinder: Document future direction of getService." 2020-05-01 20:27:36 +00:00
Suren Baghdasaryan
978e527bff Merge "Replace direct pid writes with setting task profiles" am: a72f314893
Change-Id: I3784ebd05c472dacd9a4f77ce634c7dcca45047a
2020-05-01 18:13:41 +00:00
Suren Baghdasaryan
a72f314893 Merge "Replace direct pid writes with setting task profiles" 2020-05-01 18:00:58 +00:00
Jooyung Han
84ae3bfe95 Merge "Set min_sdk_version to be part of mainline modules" am: ad9387dd8a
Change-Id: I23ad1935effe456c3b5252951b3867b76cb70c97
2020-05-01 17:51:53 +00:00
Suren Baghdasaryan
7a5ff88143 Replace direct pid writes with setting task profiles
For easy transition from SchedTune to UtilClamp, direct access to these
cgroups should be abstracted by using task profiles. Replace writepid
commands with new task_profiles command.

Bug: 155419956
Test: change .rc file and confirm task profile is applied
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Change-Id: I3e06e25a75cf79674d8381b3356c64790fd5a597
2020-05-01 17:46:48 +00:00
Jooyung Han
ad9387dd8a Merge "Set min_sdk_version to be part of mainline modules" 2020-05-01 17:35:35 +00:00
Steven Moreland
6dd0cae03d Merge changes from topic "vintf-manifest-error-logs-part-ii" am: 4c51ebbbe6
Change-Id: Ic6cc30c397dff8f859dbc01f03217d865e4afb33
2020-05-01 02:22:49 +00:00
Steven Moreland
4c51ebbbe6 Merge changes from topic "vintf-manifest-error-logs-part-ii"
* changes:
  Log VINTF manifest success/failure cases.
  servicemanager: remove performance hack
2020-05-01 02:06:46 +00:00
Steven Moreland
2edde8e605 Log VINTF manifest success/failure cases.
These logs are critical to understand the operation of the system, and
do not spam (1/hal start or 1/hal request). Most importantly, if a
manifest fails to be read for whatever reason, this is logged (null
manifest case).

Bug: 151696835
Test: boot, and verify logs of successful hal retrivals
Test: boot, and verify logs w/ patch which causes VINTF to fail the
  first time, and verify that this causes a single crash which gives us
  the ability to still find and detect a critical error, but allows the
  system functionality to continue to work.
Change-Id: I0a26b875947878656d6eda03ffebce97ebb6139e
2020-04-30 17:11:04 -07:00
Steven Moreland
8d0c9a7526 servicemanager: remove performance hack
See details in TODO.

This hack is either causing a bug or may be preventing us from solving
another bug. Until the more critical bug can be fixed, avoiding
early-boot reads of VINTF manifest files.

Bug: 151696835
Test: run, boot, check manifest logs that HAL services register
Change-Id: Iba34afe451026a30e695d6728b4172007aaf7fbd
2020-04-30 16:51:56 -07:00
Devin Moore
f967969a4f Merge "Drop unnecessary semicolon from end of file" am: 1101172876
Change-Id: If5f0c40772cb168d107c97d76e0a95d7a5343df8
2020-04-30 15:45:58 +00:00
Devin Moore
1101172876 Merge "Drop unnecessary semicolon from end of file" 2020-04-30 15:27:27 +00:00
Steven Moreland
5af7d855f4 libbinder: Document future direction of getService.
I've had a CL a long time which did this here:
https://android-review.googlesource.com/c/platform/frameworks/native/+/1225405/

However, I am not sure how to get confidence in it, and it changes
threading structure, scheduling structure, etc... So I don't think it's
quite the right time to merge it yet.

Bug: n/a
Test: n/a
Change-Id: I83549b920a470387484245587a4714b69765f03f
2020-04-29 22:42:02 +00:00
Devin Moore
b34bfce1d0 Drop unnecessary semicolon from end of file
Remove unnecessary semicolon to avoid a warning about C++98
incompatibility:
error: extra ';' outside of a function is incompatible with
C++98 [-Werror,-Wc++98-compat-extra-semi]

Test: Built an AIDL interface with trace.h methods, ran on device, collected traces.

Change-Id: I307a36eeef861d4c28aa85dc3e0b15500bfac7c8
2020-04-29 15:32:14 -07:00