tequilaOS/platform_hardware_interfaces
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Add missing newline to health/wifi AIDL interfaces

Browse source 
This change adds a missing newline character to the end of dump() for
the default health and wifi int

Add missing newline to health/wifi AIDL interfaces

This change adds a missing newline character to the end of dump() for
health and wifi.

Test: Take a bugreport and verify that the "X was the duration of
      dumpsys Y" lines aren't preceded by the final line of the dump.
Test: Run "dumpsys android.hardware.health.IHealth/default" and verify
      that the new line exists.
Test: Run "dumpsys android.hardware.wifi.IWifi/default" and verify that
      the new line exists.
Bug: 278081288
Change-Id: I173dd174b5bab808c6296f7163982393e60ba0c6
This commit is contained in:
Kevin Jeon 2023-04-13 12:14:11 -04:00
parent b4a4dbad24
commit 0331772902
2 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
health/aidl/default/Health.cpp
View file

@ -214,6 +214,7 @@ binder_status_t Health::dump(int fd, const char**, uint32_t) {
} else {
::android::base::WriteStringToFd(res.getDescription(), fd);
}
::android::base::WriteStringToFd("\n", fd);
fsync(fd);
return STATUS_OK;

2
wifi/aidl/default/wifi.cpp
View file

@ -16,6 +16,7 @@
#include "wifi.h"
#include <android-base/file.h>
#include <android-base/logging.h>
#include "aidl_return_util.h"
@ -88,6 +89,7 @@ binder_status_t Wifi::dump(int fd, const char** args, uint32_t numArgs) {
if (!chip.get()) continue;
chip->dump(fd, args, numArgs);
}
::android::base::WriteStringToFd("\n", fd);
return STATUS_OK;
}