tequilaOS/platform_hardware_interfaces
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[ConfigStore] Slient log spam.

Browse source 
Previously ConfigStore keeps logging info of each function, this patch moves it
to verbose to avoid log spam.

BUG: 123312783
Test: Build, flash and boot. Verify with adb logcat
Change-Id: I8dce745122ca05d18cd899c536342521432f5325
This commit is contained in:
Peiyong Lin 2019-02-05 17:46:14 -08:00
parent 892624d06d
commit 09dbd3df37
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
configstore/utils/ConfigStoreUtils.cpp
View file

@ -23,12 +23,12 @@ namespace android {
namespace hardware {
namespace details {
bool wouldLogInfo() {
return WOULD_LOG(INFO);
bool wouldLogVerbose() {
return WOULD_LOG(VERBOSE);
}
void logAlwaysInfo(const std::string& message) {
LOG(INFO) << message;
void logAlwaysVerbose(const std::string& message) {
LOG(VERBOSE) << message;
}
void logAlwaysError(const std::string& message) {

8
configstore/utils/include/configstore/Utils.h
View file

@ -29,8 +29,8 @@ namespace hardware {
namespace details {
// Templated classes can use the below method
// to avoid creating dependencies on liblog.
bool wouldLogInfo();
void logAlwaysInfo(const std::string& message);
bool wouldLogVerbose();
void logAlwaysVerbose(const std::string& message);
void logAlwaysError(const std::string& message);
} // namespace details
@ -92,7 +92,7 @@ decltype(V::value) get(const decltype(V::value) &defValue) {
};
static V cachedValue = getHelper();
if (wouldLogInfo()) {
if (wouldLogVerbose()) {
std::string iname = __PRETTY_FUNCTION__;
// func name starts with "func = " in __PRETTY_FUNCTION__
auto pos = iname.find("func = ");
@ -107,7 +107,7 @@ decltype(V::value) get(const decltype(V::value) &defValue) {
oss << iname << " retrieved: "
<< (cachedValue.specified ? cachedValue.value : defValue)
<< (cachedValue.specified ? "" : " (default)");
logAlwaysInfo(oss.str());
logAlwaysVerbose(oss.str());
}
return cachedValue.specified ? cachedValue.value : defValue;