tequilaOS/platform_hardware_interfaces
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge "Test ITuner::setConfiguration against bad input."

Browse source
This commit is contained in:
Tomasz Wasilczyk 2017-03-08 20:00:25 +00:00 committed by Android (Google) Code Review
commit 0d6118f767
1 changed files with 32 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
broadcastradio/1.0/vts/functional/VtsHalBroadcastradioV1_0TargetTest.cpp
View file

@ -416,6 +416,38 @@ TEST_F(BroadcastRadioHidlTest, SetAndGetConfiguration) {
EXPECT_EQ(mHalProperties.bands[1], halConfig);
}
/**
* Test ITuner::setConfiguration() with invalid arguments.
*
* Verifies that:
* - the methods returns INVALID_ARGUMENTS on invalid arguments
* - the method recovers and succeeds after passing correct arguments
*/
TEST_F(BroadcastRadioHidlTest, SetConfigurationFails) {
ASSERT_EQ(true, openTuner());
// Let's define a config that's bad for sure.
BandConfig badConfig = {};
badConfig.type = Band::FM;
badConfig.lowerLimit = 0xFFFFFFFF;
badConfig.upperLimit = 0;
badConfig.spacings = (std::vector<uint32_t>){ 0 };
// Test setConfiguration failing on bad data.
mCallbackCalled = false;
auto setResult = mTuner->setConfiguration(badConfig);
EXPECT_TRUE(setResult.isOk());
EXPECT_EQ(Result::INVALID_ARGUMENTS, setResult);
// Test setConfiguration recovering after passing good data.
mCallbackCalled = false;
setResult = mTuner->setConfiguration(mHalProperties.bands[0]);
EXPECT_TRUE(setResult.isOk());
EXPECT_EQ(Result::OK, setResult);
EXPECT_EQ(true, waitForCallback(kConfigCallbacktimeoutNs));
EXPECT_EQ(Result::OK, mResultCallbackData);
}
/**
* Test ITuner::scan
*