tequilaOS/platform_hardware_interfaces
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Note confusion-causing breaks in HIDL convention.

Browse source 
These were either made at a time when the convention was not fully
formed or missed during review.

It is somewhat misleading since method overloading isn't supported
and method names need this kind of prefix, but nothing else does.

The reason for this is that everything is namespaced, but methods are
all in the same namespace. The reason method overloading is not supported
in HIDL is because the HIDL types may map to types that collide in the
target languages, and this would cause any sort of overloading rules
to require complicated machinery.

Bug: N/A
Test: hidl-gen -Lcheck android.hardware.usb@1.1 android.hardware.vibrator@1.1 && echo ":)"
:)

Change-Id: Iac23c9311925ed140ff1e15d1366829b078c8866
This commit is contained in:
Steven Moreland 2018-09-06 17:58:16 -07:00
parent 0a0fa7209e
commit 146405b58a
3 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
current.txt
View file

@ -392,3 +392,5 @@ da33234403ff5d60f3473711917b9948e6484a4260b5247acdafb111193a9de2 android.hardwar
1d4a5776614c08b5d794a5ec5ab04697260cbd4b3441d5935cd53ee71d19da02 android.hardware.radio@1.0::IRadioResponse 1d4a5776614c08b5d794a5ec5ab04697260cbd4b3441d5935cd53ee71d19da02 android.hardware.radio@1.0::IRadioResponse
271187e261b30c01a33011aea257c07a2d2f05b72943ebee89e973e997849973 android.hardware.radio@1.0::types 271187e261b30c01a33011aea257c07a2d2f05b72943ebee89e973e997849973 android.hardware.radio@1.0::types
1d19720d4fd38b1095f0f555a4bd92b3b12c9b1d0f560b0e9a474cd6dcc20db6 android.hardware.radio@1.2::IRadio 1d19720d4fd38b1095f0f555a4bd92b3b12c9b1d0f560b0e9a474cd6dcc20db6 android.hardware.radio@1.2::IRadio
1722ad002317b1fae1400de709e90f442d94ef22864e05f7a12af48c32e8edc8 android.hardware.usb@1.1::types
29c8da7a13c40d488f569c812441d5754ee45bdcdb8ce6564f524b708d10a057 android.hardware.vibrator@1.1::types

4
usb/1.1/types.hal
View file

@ -18,6 +18,8 @@ package android.hardware.usb@1.1;
import android.hardware.usb@1.0; import android.hardware.usb@1.0;
// NOTE: suffix '_1_1' is for legacy ABI compatibility. It cannot be
// changed to 'PortMode' which the convention dictates.
@export @export
enum PortMode_1_1 : PortMode { enum PortMode_1_1 : PortMode {
/* /*
@ -37,6 +39,8 @@ enum PortMode_1_1 : PortMode {
* Used as the container to report data back to the caller. * Used as the container to report data back to the caller.
* Represents the current connection status of a single USB port. * Represents the current connection status of a single USB port.
*/ */
// NOTE: suffix '_1_1' is for legacy ABI compatibility. It cannot be
// changed to 'PortStatus' which the convention dictates.
struct PortStatus_1_1 { struct PortStatus_1_1 {
/* /*
* The supportedModes and the currentMode fields of the status * The supportedModes and the currentMode fields of the status

2
vibrator/1.1/types.hal
View file

@ -18,6 +18,8 @@ package android.hardware.vibrator@1.1;
import @1.0::Effect; import @1.0::Effect;
// NOTE: suffix '_1_1' is for legacy ABI compatibility. It cannot be
// changed to 'Effect' which the convention dictates.
@export @export
enum Effect_1_1 : @1.0::Effect { enum Effect_1_1 : @1.0::Effect {
/** /**