From 4fe33ed200c901e6ee54a21eb52be11f5275f504 Mon Sep 17 00:00:00 2001 From: Henry Fang Date: Thu, 13 Feb 2020 17:02:29 -0800 Subject: [PATCH] Add comments for invalid IP/port and add Invalid filterID/avSyncId To allow client to identify and specify invalid value bug: 148110220 Test: Manual Change-Id: Ib5e88a13cdcca0b62f55fab992293ed17e0ed708 (cherry picked from commit 460b9610bf3665f3d42d1cd67228ec799695259b) --- tv/tuner/1.0/types.hal | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/tv/tuner/1.0/types.hal b/tv/tuner/1.0/types.hal index 944da5a840..cfd5fbb0b6 100644 --- a/tv/tuner/1.0/types.hal +++ b/tv/tuner/1.0/types.hal @@ -1922,7 +1922,7 @@ safe_union DemuxPid { }; @export -enum Constant : uint16_t { +enum Constant : uint32_t { /** * An invalid packet ID in transport stream according to ISO/IEC 13818-1. */ @@ -1931,6 +1931,14 @@ enum Constant : uint16_t { * An invalid Stream ID. */ INVALID_STREAM_ID = 0xFFFF, + /** + * An invalid Filter ID. + */ + INVALID_FILTER_ID = 0xFFFFFFFF, + /** + * An invalid AV sync hardware ID. + */ + INVALID_AV_SYNC_ID = 0xFFFFFFFF, }; /** @@ -2152,19 +2160,37 @@ struct DemuxFilterDownloadSettings { */ struct DemuxIpAddress { safe_union SrcIpAddress { + /** + * 0.0.0.0 is invalid. should be ignored. + */ uint8_t[4] v4; + /** + * 0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0 is invalid. should be ignored. + */ uint8_t[16] v6; } srcIpAddress; safe_union DstIpAddress { + /** + * 0.0.0.0 is invalid. should be ignored. + */ uint8_t[4] v4; + /** + * 0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0 is invalid. should be ignored. + */ uint8_t[16] v6; } dstIpAddress; + /** + * 0 is invalid. should be ignored. + */ uint16_t srcPort; + /** + * 0 is invalid. should be ignored. + */ uint16_t dstPort; };