tequilaOS/platform_hardware_interfaces
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Free version buffer in the Vendor HAL's

Browse source 
XML parsing logic.

Fixes a minor memory leak that results from
not freeing that buffer.

Bug: 269520490
Test: Manual test
       1. Create several XML files under
          /vendor/etc/wifi/vendor_hals
       2. Modify the codepath to run the
          initVendorHalsDescriptorList method
	  (does not run by default on Pixel).
       3. Check that the XML parsing logic is
          working as intended.
Change-Id: I42944169b70c759998d94e8523d2aa55d0366ffd
This commit is contained in:
Gabriel Biren 2023-02-16 18:10:17 +00:00
parent cb34a1dc4d
commit 204e17171b
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
wifi/aidl/default/wifi_legacy_hal_factory.cpp
View file

@ -128,7 +128,7 @@ bool WifiLegacyHalFactory::initLinkedHalFunctionTable(wifi_hal_fn* hal_fn) {
void WifiLegacyHalFactory::initVendorHalsDescriptorList() {
xmlDocPtr xml;
xmlNodePtr node, cnode;
char* version;
char* version = NULL;
std::string path;
xmlChar* value;
wifi_hal_lib_desc desc;
@ -200,6 +200,10 @@ void WifiLegacyHalFactory::initVendorHalsDescriptorList() {
}
skip:
xmlFreeDoc(xml);
if (version) {
xmlFree(version);
version = NULL;
}
}
::closedir(dirPtr);
}