tequilaOS/platform_hardware_interfaces
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Audio Effects: Skip CheckConfig test for non-matching HAL versions

Browse source 
In vts-core a test suite for version N can be called for HAL
of version M. Since in the case of the Effects HAL the XSD
configuration for the effects is version-dependent, the test
must not validate the effects config using XSD file for other
version. Thus, the configuration validity check must be skipped
if no corresponding version of IEffectsFactory is found
on the device.

Bug: 142397658
Bug: 146015418
Test: atest VtsHalAudioEffectV6_0TargetTest
      on a device that uses earlier version of Audio HAL;
      CheckConfig#audioEffectsConfigurationValidation must
      be IGNORED
Change-Id: I4b34cc34091447c04bf8d3e988c9bd4048dc8ef9
This commit is contained in:
Mikhail Naganov 2020-03-18 14:37:43 -07:00
parent 775bd7cb9a
commit 248708f63c
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
audio/effect/all-versions/vts/functional/ValidateAudioEffectsConfiguration.cpp
View file

@ -18,6 +18,12 @@
#include <iterator>
#include <media/EffectsConfig.h>
// clang-format off
#include PATH(android/hardware/audio/effect/FILE_VERSION/IEffectsFactory.h)
// clang-format on
#include <gtest/gtest.h>
#include <hidl/ServiceManagement.h>
#include "utility/ValidateXml.h"
@ -29,6 +35,11 @@ TEST(CheckConfig, audioEffectsConfigurationValidation) {
RecordProperty("description",
"Verify that the effects configuration file is valid according to the schema");
using namespace android::effectsConfig;
if (android::hardware::getAllHalInstanceNames(
::android::hardware::audio::effect::CPP_VERSION::IEffectsFactory::descriptor)
.size() == 0) {
GTEST_SKIP() << "No Effects HAL version " STRINGIFY(CPP_VERSION) " on this device";
}
std::vector<const char*> locations(std::begin(DEFAULT_LOCATIONS), std::end(DEFAULT_LOCATIONS));
const char* xsd = "/data/local/tmp/audio_effects_conf_" STRINGIFY(CPP_VERSION) ".xsd";