Revert "nfc: update default implementation to match style."

This reverts commit 6b6381cb58.

Change-Id: I2891a4ea774ad0047d9f99074fe773808dae0f7c
This commit is contained in:
Steven Moreland 2016-10-04 16:25:35 +00:00
parent 1d4862a6c2
commit 3768be324b
2 changed files with 19 additions and 18 deletions

View file

@ -19,19 +19,19 @@ Nfc::Nfc(nfc_nci_device_t* device) : mDevice(device) {
// Methods from ::android::hardware::nfc::V1_0::INfc follow.
::android::hardware::Return<int32_t> Nfc::open(const sp<INfcClientCallback>& clientCallback) {
mCallback = clientCallback;
return mDevice->open(mDevice, eventCallback, dataCallback);
return mDevice->open(mDevice, event_callback, data_callback);
}
::android::hardware::Return<int32_t> Nfc::write(const hidl_vec<uint8_t>& data) {
return mDevice->write(mDevice, data.size(), &data[0]);
::android::hardware::Return<int32_t> Nfc::write(const nfc_data_t& data) {
return mDevice->write(mDevice, data.data.size(), &data.data[0]);
}
::android::hardware::Return<int32_t> Nfc::coreInitialized(const hidl_vec<uint8_t>& data) {
::android::hardware::Return<int32_t> Nfc::core_initialized(const hidl_vec<uint8_t>& data) {
hidl_vec<uint8_t> copy = data;
return mDevice->core_initialized(mDevice, &copy[0]);
}
::android::hardware::Return<int32_t> Nfc::prediscover() {
::android::hardware::Return<int32_t> Nfc::pre_discover() {
return mDevice->pre_discover(mDevice);
}
@ -39,11 +39,11 @@ Nfc::Nfc(nfc_nci_device_t* device) : mDevice(device) {
return mDevice->close(mDevice);
}
::android::hardware::Return<int32_t> Nfc::controlGranted() {
::android::hardware::Return<int32_t> Nfc::control_granted() {
return mDevice->control_granted(mDevice);
}
::android::hardware::Return<int32_t> Nfc::powerCycle() {
::android::hardware::Return<int32_t> Nfc::power_cycle() {
return mDevice->power_cycle(mDevice);
}

View file

@ -13,6 +13,7 @@ namespace implementation {
using ::android::hardware::nfc::V1_0::INfc;
using ::android::hardware::nfc::V1_0::INfcClientCallback;
using ::android::hardware::nfc::V1_0::nfc_data_t;
using ::android::hardware::Return;
using ::android::hardware::Void;
using ::android::hardware::hidl_vec;
@ -22,23 +23,23 @@ using ::android::sp;
struct Nfc : public INfc {
Nfc(nfc_nci_device_t* device);
::android::hardware::Return<int32_t> open(const sp<INfcClientCallback>& clientCallback) override;
::android::hardware::Return<int32_t> write(const hidl_vec<uint8_t>& data) override;
::android::hardware::Return<int32_t> coreInitialized(const hidl_vec<uint8_t>& data) override;
::android::hardware::Return<int32_t> prediscover() override;
::android::hardware::Return<int32_t> write(const nfc_data_t& data) override;
::android::hardware::Return<int32_t> core_initialized(const hidl_vec<uint8_t>& data) override;
::android::hardware::Return<int32_t> pre_discover() override;
::android::hardware::Return<int32_t> close() override;
::android::hardware::Return<int32_t> controlGranted() override;
::android::hardware::Return<int32_t> powerCycle() override;
::android::hardware::Return<int32_t> control_granted() override;
::android::hardware::Return<int32_t> power_cycle() override;
static void eventCallback(uint8_t event, uint8_t status) {
static void event_callback(uint8_t event, uint8_t status) {
if (mCallback != nullptr) {
mCallback->sendEvent(
(::android::hardware::nfc::V1_0::NfcEvent) event,
(::android::hardware::nfc::V1_0::NfcStatus) status);
(::android::hardware::nfc::V1_0::nfc_event_t) event,
(::android::hardware::nfc::V1_0::nfc_status_t) status);
}
}
static void dataCallback(uint16_t data_len, uint8_t* p_data) {
hidl_vec<uint8_t> data;
data.setToExternal(p_data, data_len);
static void data_callback(uint16_t data_len, uint8_t* p_data) {
nfc_data_t data;
data.data.setToExternal(p_data, data_len);
if (mCallback != nullptr) {
mCallback->sendData(data);
}