diff --git a/radio/1.0/vts/functional/radio_hidl_hal_data.cpp b/radio/1.0/vts/functional/radio_hidl_hal_data.cpp index 655b869333..38cb33b07e 100644 --- a/radio/1.0/vts/functional/radio_hidl_hal_data.cpp +++ b/radio/1.0/vts/functional/radio_hidl_hal_data.cpp @@ -87,12 +87,19 @@ TEST_P(RadioHidlTest, getDataRegistrationState) { cellIdentities.cellIdentityTdscdma.size()); if (checkMccMnc) { - // 32 bit system gets result: "\xff\xff\xff..." from RIL, which is not testable. Only - // test for 64 bit here. TODO: remove this limit after b/113181277 being fixed. - if (hidl_mcc.size() < 4 && hidl_mnc.size() < 4) { + // 32 bit system gets result: "\xff\xff\xff..." from RIL, which is not testable. + // Only test for 64 bit here. TODO: remove this limit after b/113181277 being fixed. + int mccSize = hidl_mcc.size(); + EXPECT_TRUE(mccSize == 0 || mccSize == 3); + if (mccSize > 0) { int mcc = stoi(hidl_mcc); - int mnc = stoi(hidl_mnc); EXPECT_TRUE(mcc >= 0 && mcc <= 999); + } + + int mncSize = hidl_mnc.size(); + EXPECT_TRUE(mncSize == 0 || mncSize == 2 || mncSize == 3); + if (mncSize > 0) { + int mnc = stoi(hidl_mnc); EXPECT_TRUE(mnc >= 0 && mnc <= 999); } } diff --git a/radio/1.2/vts/functional/radio_hidl_hal_api.cpp b/radio/1.2/vts/functional/radio_hidl_hal_api.cpp index 2400bde9ae..2bce2f957b 100644 --- a/radio/1.2/vts/functional/radio_hidl_hal_api.cpp +++ b/radio/1.2/vts/functional/radio_hidl_hal_api.cpp @@ -120,7 +120,7 @@ TEST_P(RadioHidlTest_v1_2, startNetworkScan_InvalidInterval1) { serial = GetRandomSerialNumber(); ::android::hardware::radio::V1_2::NetworkScanRequest request = { - .type = ScanType::ONE_SHOT, + .type = ScanType::PERIODIC, .interval = 4, .specifiers = {::GERAN_SPECIFIER_P900, ::GERAN_SPECIFIER_850}, .maxSearchTime = 60, @@ -155,7 +155,7 @@ TEST_P(RadioHidlTest_v1_2, startNetworkScan_InvalidInterval2) { serial = GetRandomSerialNumber(); ::android::hardware::radio::V1_2::NetworkScanRequest request = { - .type = ScanType::ONE_SHOT, + .type = ScanType::PERIODIC, .interval = 301, .specifiers = {::GERAN_SPECIFIER_P900, ::GERAN_SPECIFIER_850}, .maxSearchTime = 60, @@ -821,11 +821,20 @@ TEST_P(RadioHidlTest_v1_2, getDataRegistrationState) { cellIdentities.cellIdentityTdscdma.size()); // 32 bit system might return invalid mcc and mnc hidl string "\xff\xff..." - if (checkMccMnc && hidl_mcc.size() < 4 && hidl_mnc.size() < 4) { - int mcc = stoi(hidl_mcc); - int mnc = stoi(hidl_mnc); - EXPECT_TRUE(mcc >= 0 && mcc <= 999); - EXPECT_TRUE(mnc >= 0 && mnc <= 999); + if (checkMccMnc) { + int mccSize = hidl_mcc.size(); + EXPECT_TRUE(mccSize == 0 || mccSize == 3); + if (mccSize > 0) { + int mcc = stoi(hidl_mcc); + EXPECT_TRUE(mcc >= 0 && mcc <= 999); + } + + int mncSize = hidl_mnc.size(); + EXPECT_TRUE(mncSize == 0 || mncSize == 2 || mncSize == 3); + if (mncSize > 0) { + int mnc = stoi(hidl_mnc); + EXPECT_TRUE(mnc >= 0 && mnc <= 999); + } } } diff --git a/radio/1.4/vts/functional/radio_hidl_hal_api.cpp b/radio/1.4/vts/functional/radio_hidl_hal_api.cpp index 8f357a0f5c..744af7546a 100644 --- a/radio/1.4/vts/functional/radio_hidl_hal_api.cpp +++ b/radio/1.4/vts/functional/radio_hidl_hal_api.cpp @@ -335,7 +335,7 @@ TEST_P(RadioHidlTest_v1_4, startNetworkScan_InvalidInterval1) { serial = GetRandomSerialNumber(); ::android::hardware::radio::V1_2::NetworkScanRequest request = { - .type = ScanType::ONE_SHOT, + .type = ScanType::PERIODIC, .interval = 4, .specifiers = {::GERAN_SPECIFIER_P900, ::GERAN_SPECIFIER_850}, .maxSearchTime = 60, @@ -368,7 +368,7 @@ TEST_P(RadioHidlTest_v1_4, startNetworkScan_InvalidInterval2) { serial = GetRandomSerialNumber(); ::android::hardware::radio::V1_2::NetworkScanRequest request = { - .type = ScanType::ONE_SHOT, + .type = ScanType::PERIODIC, .interval = 301, .specifiers = {::GERAN_SPECIFIER_P900, ::GERAN_SPECIFIER_850}, .maxSearchTime = 60, diff --git a/radio/1.5/vts/functional/radio_hidl_hal_api.cpp b/radio/1.5/vts/functional/radio_hidl_hal_api.cpp index 316c308115..fd44e9309e 100644 --- a/radio/1.5/vts/functional/radio_hidl_hal_api.cpp +++ b/radio/1.5/vts/functional/radio_hidl_hal_api.cpp @@ -661,7 +661,7 @@ TEST_P(RadioHidlTest_v1_5, startNetworkScan_InvalidInterval1) { .channels = {128, 129}}; ::android::hardware::radio::V1_5::NetworkScanRequest request = { - .type = ScanType::ONE_SHOT, + .type = ScanType::PERIODIC, .interval = 4, .specifiers = {specifierP900, specifier850}, .maxSearchTime = 60, @@ -705,7 +705,7 @@ TEST_P(RadioHidlTest_v1_5, startNetworkScan_InvalidInterval2) { .channels = {128, 129}}; ::android::hardware::radio::V1_5::NetworkScanRequest request = { - .type = ScanType::ONE_SHOT, + .type = ScanType::PERIODIC, .interval = 301, .specifiers = {specifierP900, specifier850}, .maxSearchTime = 60,