diff --git a/biometrics/fingerprint/aidl/default/Android.bp b/biometrics/fingerprint/aidl/default/Android.bp index 3bb3f3a944..a173a00d12 100644 --- a/biometrics/fingerprint/aidl/default/Android.bp +++ b/biometrics/fingerprint/aidl/default/Android.bp @@ -11,8 +11,6 @@ cc_binary { name: "android.hardware.biometrics.fingerprint-service.example", vendor: true, relative_install_path: "hw", - init_rc: [":fingerprint-example.rc"], - vintf_fragments: [":fingerprint-example.xml"], local_include_dirs: ["include"], srcs: [ "FakeLockoutTracker.cpp", @@ -24,15 +22,21 @@ cc_binary { "Session.cpp", "main.cpp", ], + stl: "c++_static", shared_libs: [ - "libbase", "libbinder_ndk", + "liblog", + ], + static_libs: [ + "libandroid.hardware.biometrics.fingerprint.VirtualProps", + "libbase", "android.hardware.biometrics.fingerprint-V3-ndk", "android.hardware.biometrics.common-V3-ndk", "android.hardware.biometrics.common.thread", "android.hardware.biometrics.common.util", + "android.hardware.keymaster-V4-ndk", ], - static_libs: ["libandroid.hardware.biometrics.fingerprint.VirtualProps"], + installable: false, // install APEX instead } cc_test { @@ -143,12 +147,35 @@ sysprop_library { vendor: true, } -filegroup { +prebuilt_etc { name: "fingerprint-example.rc", - srcs: ["fingerprint-example.rc"], + src: "fingerprint-example.rc", + installable: false, } -filegroup { +prebuilt_etc { name: "fingerprint-example.xml", - srcs: ["fingerprint-example.xml"], + src: "fingerprint-example.xml", + sub_dir: "vintf", + installable: false, +} + +apex { + name: "com.android.hardware.biometrics.fingerprint.virtual", + manifest: "apex_manifest.json", + file_contexts: "apex_file_contexts", + key: "com.android.hardware.key", + certificate: ":com.android.hardware.certificate", + updatable: false, + vendor: true, + + binaries: [ + "android.hardware.biometrics.fingerprint-service.example", + ], + prebuilts: [ + // init_rc + "fingerprint-example.rc", + // vintf_fragment + "fingerprint-example.xml", + ], } diff --git a/biometrics/fingerprint/aidl/default/README.md b/biometrics/fingerprint/aidl/default/README.md index 823cd18f43..4b4533ae67 100644 --- a/biometrics/fingerprint/aidl/default/README.md +++ b/biometrics/fingerprint/aidl/default/README.md @@ -10,12 +10,6 @@ emulators. This HAL can be used on emulators, like cuttlefish, or on real devices. Add the following to your device's `.mk` file to include it: -``` -PRODUCT_PACKAGES_DEBUG += android.hardware.biometrics.fingerprint-service.example -``` - -or add the following to include it as an apex: - ``` PRODUCT_PACKAGES_DEBUG += com.android.hardware.biometrics.fingerprint.virtual ``` diff --git a/biometrics/fingerprint/aidl/default/apex/Android.bp b/biometrics/fingerprint/aidl/default/apex/Android.bp deleted file mode 100644 index 75d84a94da..0000000000 --- a/biometrics/fingerprint/aidl/default/apex/Android.bp +++ /dev/null @@ -1,61 +0,0 @@ -// Copyright (C) 2023 The Android Open Source Project -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -package { - default_applicable_licenses: ["Android-Apache-2.0"], -} - -apex { - name: "com.android.hardware.biometrics.fingerprint.virtual", - manifest: "manifest.json", - file_contexts: "file_contexts", - key: "com.android.hardware.key", - certificate: ":com.android.hardware.certificate", - updatable: false, - vendor: true, - - binaries: [ - "android.hardware.biometrics.fingerprint-service.example", - ], - prebuilts: [ - // init_rc - "fingerprint-example-apex.rc", - // vintf_fragment - "fingerprint-example-apex.xml", - ], - - overrides: [ - "android.hardware.biometrics.fingerprint-service.example", - ], -} - -genrule { - name: "gen-fingerprint-example-apex.rc", - srcs: [":fingerprint-example.rc"], - out: ["fingerprint-example-apex.rc"], - cmd: "sed -e 's@/vendor/bin/@/apex/com.android.hardware.biometrics.fingerprint.virtual/bin/@' $(in) > $(out)", -} - -prebuilt_etc { - name: "fingerprint-example-apex.rc", - src: ":gen-fingerprint-example-apex.rc", - installable: false, -} - -prebuilt_etc { - name: "fingerprint-example-apex.xml", - src: ":fingerprint-example.xml", - sub_dir: "vintf", - installable: false, -} diff --git a/biometrics/fingerprint/aidl/default/apex/file_contexts b/biometrics/fingerprint/aidl/default/apex_file_contexts similarity index 100% rename from biometrics/fingerprint/aidl/default/apex/file_contexts rename to biometrics/fingerprint/aidl/default/apex_file_contexts diff --git a/biometrics/fingerprint/aidl/default/apex/manifest.json b/biometrics/fingerprint/aidl/default/apex_manifest.json similarity index 100% rename from biometrics/fingerprint/aidl/default/apex/manifest.json rename to biometrics/fingerprint/aidl/default/apex_manifest.json diff --git a/biometrics/fingerprint/aidl/default/fingerprint-example.rc b/biometrics/fingerprint/aidl/default/fingerprint-example.rc index ee4713c158..da4ea45696 100644 --- a/biometrics/fingerprint/aidl/default/fingerprint-example.rc +++ b/biometrics/fingerprint/aidl/default/fingerprint-example.rc @@ -1,4 +1,4 @@ -service vendor.fingerprint-example /vendor/bin/hw/android.hardware.biometrics.fingerprint-service.example +service vendor.fingerprint-example /apex/com.android.hardware.biometrics.fingerprint.virtual/bin/hw/android.hardware.biometrics.fingerprint-service.example class hal user nobody group nobody