tequilaOS/platform_hardware_interfaces
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove length arg from transmit() in IR HAL

Browse source 
The length argument is not necessary since the pattern is
passed to transmit() as a hidl_vec, so remove it.

Test: Built and called new transmit() function.
Change-Id: I4bee4557c2cca6562a43df5e22a7d6b846f20bb4
Signed-off-by: Connor O'Brien <connoro@google.com>
This commit is contained in:
Connor O'Brien 2016-12-19 15:55:12 -08:00
parent fcbb5d2213
commit 542a11b42b
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ir/1.0/IConsumerIr.hal
View file

@ -28,7 +28,7 @@ interface IConsumerIr {
*
* returns: true on success, false on error.
*/
transmit(int32_t carrierFreq, vec<int32_t> pattern, int32_t patternLen) generates (bool success);
transmit(int32_t carrierFreq, vec<int32_t> pattern) generates (bool success);
/*
* getCarrierFreqs() enumerates which frequencies the IR transmitter supports.

4
ir/1.0/default/ConsumerIr.cpp
View file

@ -32,8 +32,8 @@ ConsumerIr::ConsumerIr(consumerir_device_t *device) {
}
// Methods from ::android::hardware::consumerir::V1_0::IConsumerIr follow.
Return<bool> ConsumerIr::transmit(int32_t carrierFreq, const hidl_vec<int32_t>& pattern, int32_t patternLen) {
return mDevice->transmit(mDevice, carrierFreq, pattern.data(), patternLen) == 0;
Return<bool> ConsumerIr::transmit(int32_t carrierFreq, const hidl_vec<int32_t>& pattern) {
return mDevice->transmit(mDevice, carrierFreq, pattern.data(), pattern.size()) == 0;
}
Return<void> ConsumerIr::getCarrierFreqs(getCarrierFreqs_cb _hidl_cb) {

2
ir/1.0/default/ConsumerIr.h
View file

@ -40,7 +40,7 @@ using ::android::sp;
struct ConsumerIr : public IConsumerIr {
ConsumerIr(consumerir_device_t *device);
// Methods from ::android::hardware::ir::V1_0::IConsumerIr follow.
Return<bool> transmit(int32_t carrierFreq, const hidl_vec<int32_t>& pattern, int32_t patternLen) override;
Return<bool> transmit(int32_t carrierFreq, const hidl_vec<int32_t>& pattern) override;
Return<void> getCarrierFreqs(getCarrierFreqs_cb _hidl_cb) override;
private:
consumerir_device_t *mDevice;